-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Pin google_mobile_ads to 5.1.0 #156911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin google_mobile_ads to 5.1.0 #156911
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
c24e679 to
28fcea9
Compare
28fcea9 to
5c32953
Compare
|
It looks like there are errors in rolling the Dart SDK. I've removed the manual pub roll from this change so that it only pins |
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ship it
google_mobile_ads5.2.0 is known to break the builds of Flutter apps: googleads/googleads-mobile-flutter#1193This pins google_mobile_ads to 5.1.0 to unblock the pub autoroller.
See: #156606
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.