Skip to content

Conversation

@loic-sharma
Copy link
Member

google_mobile_ads 5.2.0 is known to break the builds of Flutter apps: googleads/googleads-mobile-flutter#1193

This pins google_mobile_ads to 5.1.0 to unblock the pub autoroller.

See: #156606

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 15, 2024
@loic-sharma loic-sharma mentioned this pull request Oct 15, 2024
3 tasks
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Oct 15, 2024
@loic-sharma loic-sharma changed the title Pin google_mobile_ads to 5.1.0 Pin google_mobile_ads to 5.1.0 and roll pub dependencies Oct 15, 2024
@loic-sharma loic-sharma force-pushed the pin_google_ads_manager branch from c24e679 to 28fcea9 Compare October 15, 2024 21:19
@loic-sharma loic-sharma force-pushed the pin_google_ads_manager branch from 28fcea9 to 5c32953 Compare October 15, 2024 21:33
@loic-sharma loic-sharma changed the title Pin google_mobile_ads to 5.1.0 and roll pub dependencies Pin google_mobile_ads to 5.1.0 Oct 15, 2024
@github-actions github-actions bot removed a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Oct 15, 2024
@loic-sharma
Copy link
Member Author

It looks like there are errors in rolling the Dart SDK. I've removed the manual pub roll from this change so that it only pins google_mobile_ads. That'll allow us to land this change and investigate other pub roll failures separately.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ship it

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants