Skip to content

Fix JS compilation to use the command 'compile js' instead of using snapshot names to invoke dart2js #156735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a-siva merged 9 commits into from
Oct 15, 2024
Merged

Fix JS compilation to use the command 'compile js' instead of using snapshot names to invoke dart2js #156735

a-siva merged 9 commits into from
Oct 15, 2024

Conversation

@a-siva
Copy link
Contributor

@a-siva a-siva commented Oct 14, 2024 •
edited
Loading

Fix JS compilation to use the command 'compile js' instead of using snapshot names to invoke dart2js

The Dart SDK is switching all tools to use AOT snapshots instead of JIT snapshots and using snapshot names directly causes things to break.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 14, 2024
@a-siva a-siva requested a review from yjbanov October 15, 2024 17:25
@a-siva a-siva requested a review from yjbanov October 15, 2024 22:09
yjbanov
yjbanov approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@a-siva a-siva merged commit 4715296 into flutter:master Oct 15, 2024
@a-siva a-siva deleted the fix-snapshot branch October 15, 2024 22:29
@a-siva a-siva mentioned this pull request Oct 15, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 16, 2024
@engine-flutter-autoroll
4715296 Fix JS compilation to use the command 'compile js' instead of…
626596b 
… using snapshot names to invoke dart2js (flutter/flutter#156735)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 17, 2024
@engine-flutter-autoroll
4715296 Fix JS compilation to use the command 'compile js' instead of…
965396e 
… using snapshot names to invoke dart2js (flutter/flutter#156735)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
4715296 Fix JS compilation to use the command 'compile js' instead of…
af48a32 
… using snapshot names to invoke dart2js (flutter/flutter#156735)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
4715296 Fix JS compilation to use the command 'compile js' instead of…
d89157b 
… using snapshot names to invoke dart2js (flutter/flutter#156735)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
4715296 Fix JS compilation to use the command 'compile js' instead of…
3881f60 
… using snapshot names to invoke dart2js (flutter/flutter#156735)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
4715296 Fix JS compilation to use the command 'compile js' instead of…
c00a606 
… using snapshot names to invoke dart2js (flutter/flutter#156735)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
4715296 Fix JS compilation to use the command 'compile js' instead of…
6572653 
… using snapshot names to invoke dart2js (flutter/flutter#156735)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a-siva @yjbanov