Add test for material_state_property.0.dart
#156719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleroux
reviewed
Oct 14, 2024
Contributor
bleroux
left a comment
There was a problem hiding this comment.
Thanks for the contribution !
See my comment about the finder vs helper.
| const example.MaterialStatePropertyExampleApp(), | ||
| ); | ||
|
|
||
| expect(findForegroundColor(Colors.red), findsOne); |
Contributor
There was a problem hiding this comment.
Using a finder here feels somewhat unintuitive to me.
Maybe a helper function such as getButtonForegroundColor and an expect such as expect(getButtonForegroundColor(), Colors.red) would be easier to understand?
Contributor
Author
There was a problem hiding this comment.
Sure! What do you think of revamp: Change findForegroundColor into getButtonForegroundColor?
| ); | ||
|
|
||
| testWidgets( | ||
| 'The foreground color of the TextButton should blue when hovered', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'The foreground color of the TextButton should blue when hovered', | |
| 'The foreground color of the TextButton should be blue when hovered', |
bleroux
approved these changes
Oct 15, 2024
Contributor
bleroux
left a comment
There was a problem hiding this comment.
LGTM!
You should propably rebase to fix the failing CI check.
1670c7f to
eb9c756
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #130459
It adds a test for
examples/api/test/material/material_state/material_state_property.0_test.dartPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.