Reverts "Roll Flutter Engine from 3f0e2fb48145 to e41a7629654a (4 revisions) (#156562)" #156594
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
fluttergithubbot
approved these changes
Oct 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
Contributor
|
reason for revert: workaround landed? |
auto-submit bot
added a commit
that referenced
this pull request
Oct 11, 2024
…sions) (#156562)" (#156594)" (#156597) Reverts: #156594 Initiated by: jonahwilliams Reason for reverting: workaround landed? Original PR Author: auto-submit[bot] Reviewed By: {fluttergithubbot} This change reverts the following previous change: Reverts: #156562 Initiated by: zanderso Reason for reverting: Linux_mokey flutter_gallery__back_button_memory is failing repeatedly on framework CI Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@3f0e2fb...e41a762 2024-10-11 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view] Fix Platform view gesture recognizer with iPad pencil getting stuck (flutter/engine#55724) 2024-10-11 flar@google.com [DisplayList] Create DlFoo type variants to start moving away from Skia types in API (flutter/engine#55812) 2024-10-10 jonahwilliams@google.com [engine] remove merge thread setting and fix default value. (flutter/engine#55810) 2024-10-10 skia-flutter-autoroll@skia.org Roll Skia from 1e269594df9d to 97cebfb06139 (3 revisions) (flutter/engine#55811) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 16, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 17, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 21, 2024
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
…a (4 revisions) (#156562)" (flutter/flutter#156594)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
…a (4 revisions) (#156562)" (flutter/flutter#156594)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #156562
Initiated by: zanderso
Reason for reverting: Linux_mokey flutter_gallery__back_button_memory is failing repeatedly on framework CI
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
flutter/engine@3f0e2fb...e41a762
2024-10-11 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view] Fix Platform view gesture recognizer with iPad pencil getting stuck (flutter/engine#55724)
2024-10-11 flar@google.com [DisplayList] Create DlFoo type variants to start moving away from Skia types in API (flutter/engine#55812)
2024-10-10 jonahwilliams@google.com [engine] remove merge thread setting and fix default value. (flutter/engine#55810)
2024-10-10 skia-flutter-autoroll@skia.org Roll Skia from 1e269594df9d to 97cebfb06139 (3 revisions) (flutter/engine#55811)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md