Skip to content

Flutter tool assumes impeller is enabled by default #156540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Oct 10, 2024
Merged

Flutter tool assumes impeller is enabled by default #156540

auto-submit merged 1 commit into from
Oct 10, 2024

Conversation

@jtmcdole
Copy link
Member

@jtmcdole jtmcdole commented Oct 10, 2024

... because it is.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 10, 2024
@jtmcdole
Copy link
Member Author

jtmcdole commented Oct 10, 2024

See #132712

@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2024
@auto-submit auto-submit bot merged commit 9a9b921 into flutter:master Oct 10, 2024
@jtmcdole jtmcdole added the cp: stable cherry pick this pull request to stable release candidate branch label Oct 10, 2024
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Oct 10, 2024
@jtmcdole
Flutter tool assumes impeller is enabled by default (flutter#156540)
0c198c4 
... because it is.
@jtmcdole jtmcdole removed the cp: stable cherry pick this pull request to stable release candidate branch label Oct 10, 2024
jtmcdole added a commit to jtmcdole/flutter that referenced this pull request Oct 10, 2024
@jtmcdole
Flutter tool assumes impeller is enabled by default (flutter#156540)
54d6a4b 
... because it is.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
ff4a6e3 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
734748e 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
4bd360f 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
1258c9c 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
d5010bd 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
9f1c580 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
6ee6495 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
175a6e2 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
7357e87 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
3337abc 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
fc3123d 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
7a89b3d 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
2567d09 
…flutter#156540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 16, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
ea53316 
…flutter#156540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 17, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
5b2b146 
…flutter#156540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 21, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 21, 2024
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
e04d086 
…flutter#156540)
auto-submit bot pushed a commit that referenced this pull request Nov 5, 2024
@jtmcdole
Flutter tool assumes impeller is enabled by default (#156540) (#156545)
1806f2c 
Cherry pick request to get correct analytics
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
b523975 
…flutter#156540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
b2e48dd 
…flutter#156540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
8fa24a3 
…flutter#156540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
ec1dadd 
…flutter#156540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
9a9b921 Flutter tool assumes impeller is enabled by default (flutter/…
0345587 
…flutter#156540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

+1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtmcdole @chinmaygarde @matanlurey