Add test for AutofillGroup api example #156439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b77893b to
997817c
Compare
997817c to
16b8a54
Compare
Contributor
Author
|
@bleroux can you check it,please? |
bleroux
reviewed
Oct 10, 2024
Contributor
bleroux
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
See my comment about the formatting.
Also can you add more checks to verify all TextField's autofillHints value? (Reading the sample code, I see some have AutofillHints.streetAddressLine2 and also creditCardNumber, creditCardSecurityCode and telephoneNumber.
Because this example is related to the AutofillGroup feature, it probably would make sense to check the number of AutofilGroup widgets created (similarly to how you checked the number of TextField).
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
bleroux
reviewed
Oct 10, 2024
Contributor
bleroux
left a comment
There was a problem hiding this comment.
Minor comments before merging:
- consider adding a check for shippingAddress2, this way all the 7 text fields will be verified.
- small typos, see my specific comments.
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
Contributor
Author
|
I accidentally remove the test for shipping address 2, but it's already fixed, thank you @bleroux |
bleroux
approved these changes
Oct 10, 2024
Contributor
bleroux
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution 🙏
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
Contributor
Author
|
@bleroux can be merged?🫡 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write Tests for API Examples of
autoffil_groupas part of #130459This are tests of snippets used in AutofillGroup class
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.