[tool] fix android studio preview's version parsing #156293

Sameri11 · 2024-10-06T17:05:05Z

This PR willing to fix issue when flutter doctor validator can't determine version of Android Studio EAP.

These are before/after outputs of flutter doctor -v showcasing change in behaviour of validator. Each output has 3 Android Studio sections, 1 for stable and 2 for different EAP versions.

before, (stable, 3.24.3), 2 issues related to versions of Android Studio

[✓] Flutter (Channel stable, 3.24.3, on macOS 14.7 23H124 darwin-arm64, locale en-RU)
    • Flutter version 3.24.3 on channel stable at /Users/samer/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (4 weeks ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/samer/Library/Android/sdk
    • Platform android-35, build-tools 34.0.0
    • Java binary at: /Users/samer/Library/Java/JavaVirtualMachines/jbr-17.0.7/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment JBR-17.0.7+7-964.1-nomod (build 17.0.7+7-b964.1)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
    • Xcode at /Applications/Xcode-16.0.app/Contents/Developer
    • Build 16A242d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Users/samer/Applications/Android Studio Koala Feature Drop 2024.1.2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[!] Android Studio (version unknown)
    • Android Studio at /Users/samer/Applications/Android Studio Ladybug Feature Drop 2024.2.2 Canary 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)

[!] Android Studio (version unknown)
    • Android Studio at /Users/samer/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)

[✓] IntelliJ IDEA Ultimate Edition (version EAP IU-243.12818.47)
    • IntelliJ at /Users/samer/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.94.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.98.0

[✓] Connected device (5 available)
    • sdk gphone64 arm64 (mobile)     • emulator-5554             • android-arm64  • Android 15 (API 35) (emulator)
    • iPhone (Михаил) (mobile)        • 00008020-001254DA1E39002E • ios            • iOS 17.6.1 21G93
    • macOS (desktop)                 • macos                     • darwin-arm64   • macOS 14.7 23H124 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad     • darwin         • macOS 14.7 23H124 darwin-arm64
    • Chrome (web)                    • chrome                    • web-javascript • Google Chrome 129.0.6668.90
    ! Error: Browsing on the local area network for Михаил Новосельцев’s iPad. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

after, no issues regarding Android Studio

[!] Flutter (Channel [user-branch], 3.26.0-1.0.pre.383, on macOS 14.7 23H124 darwin-arm64, locale en-RU)
    ! Flutter version 3.26.0-1.0.pre.383 on channel [user-branch] at /Users/samer/projects/flutter
      Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
      If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/setup.
    • Upstream repository git@github.com:Sameri11/flutter.git
    • FLUTTER_GIT_URL = git@github.com:Sameri11/flutter.git
    • Framework revision 852508425d (20 minutes ago), 2024-10-07 21:22:45 +0500
    • Engine revision 683a14c1f1
    • Dart version 3.6.0 (build 3.6.0-326.0.dev)
    • DevTools version 2.40.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update
      checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/samer/Library/Android/sdk
    • Platform android-35, build-tools 34.0.0
    • Java binary at: /Users/samer/Library/Java/JavaVirtualMachines/jbr-17.0.7/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment JBR-17.0.7+7-964.1-nomod (build 17.0.7+7-b964.1)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
    • Xcode at /Applications/Xcode-16.0.app/Contents/Developer
    • Build 16A242d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Users/samer/Applications/Android Studio Koala Feature Drop 2024.1.2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] Android Studio (version 2024.2.2)
    • Android Studio at /Users/samer/Applications/Android Studio Ladybug Feature Drop 2024.2.2 Canary 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)

[✓] Android Studio (version 2024.2.1)
    • Android Studio at /Users/samer/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)

[✓] IntelliJ IDEA Ultimate Edition (version EAP IU-243.12818.47)
    • IntelliJ at /Users/samer/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.94.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.98.0

[✓] Connected device (5 available)
    • sdk gphone64 arm64 (mobile)     • emulator-5554             • android-arm64  • Android 15 (API 35) (emulator)
    • iPhone (Михаил) (mobile)        • 00008020-001254DA1E39002E • ios            • iOS 17.6.1 21G93
    • macOS (desktop)                 • macos                     • darwin-arm64   • macOS 14.7 23H124 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad     • darwin         • macOS 14.7 23H124 darwin-arm64
    • Chrome (web)                    • chrome                    • web-javascript • Google Chrome 129.0.6668.90
    ! Error: Browsing on the local area network for Михаил Новосельцев’s iPad. Ensure the device is unlocked and attached with a cable or
      associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Logic behind these changes explained in #121925 (comment)

fixes #121925

Tests: updated existing tests by adding version checking, but I don't mind writing new ones if necessary – please tell me if so.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter_tools/lib/src/android/android_studio.dart

andrewkolos · 2024-10-11T20:22:37Z

I verified that this works with Ladybug Feature Drop 2024.2.2 Canary 5 installed via JetBrains Toolbox on my M1 MacBook (the PR description includes verification, but I figured it would be nice to test this on another machine):

Before:

[!] Android Studio (version unknown)
    • Android Studio at /Users/andrewkolos/Applications/Android Studio Ladybug
      Feature Drop 2024.2.2 Canary 5.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 21.0.4+-12422083-b607.1)

After:

[✓] Android Studio (version 2024.2.2)
    • Android Studio at /Users/andrewkolos/Applications/Android Studio Ladybug
      Feature Drop 2024.2.2 Canary 5.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.4+-12422083-b607.1)

I'll be reviewing the diff shortly.

andrewkolos

Thanks for well-written PR description and informative comment on the parent issue!

The approach looks good to me, especially when considering #121925 (comment).

I agree that relying on a un-documented version pattern isn't ideal, but the ideal fix of getting Android Studio to use legal values for CFBundleVersion is unlikely to happen, pragmatically speaking (context/prior effort: #121925 (comment)).

With this being said, I do think we should have at least one test that verifies that this parsing works when something like EAP AI-242.21829.142.2422.12358220 is encountered.

packages/flutter_tools/lib/src/android/android_studio.dart

Sameri11 · 2024-10-12T16:19:09Z

With this being said, I do think we should have at least one test that verifies that this parsing works when something like EAP AI-242.21829.142.2422.12358220 is encountered.

Thanks for review @andrewkolos ! Totally agree with the need of test, but isn't it tested here in discovers Android Studio EAP location test? Just to be clear, this is Info.plist used for this test, and CFBundleShortVersionString is in that exact format there:

flutter/packages/flutter_tools/test/general.shard/android/android_studio_test.dart

Lines 76 to 87 in 2629eb0

    
           const Map<String, Object> macStudioInfoPlistEap_2022_3_1_11 = <String, Object>{ 
        
             'CFBundleGetInfoString': 'Android Studio EAP AI-223.8836.35.2231.9848316, build AI-223.8836.35.2231.9848316. Copyright JetBrains s.r.o., (c) 2000-2023', 
        
             'CFBundleShortVersionString': 'EAP AI-223.8836.35.2231.9848316', 
        
             'CFBundleVersion': 'AI-223.8836.35.2231.9848316', 
        
             'JVMOptions': <String, Object>{ 
        
               'Properties': <String, Object>{ 
        
                 'idea.vendor.name' : 'Google', 
        
                 'idea.paths.selector': 'AndroidStudioPreview2022.3', 
        
                 'idea.platform.prefix': 'AndroidStudio', 
        
               }, 
        
             }, 
        
           };

As I said, I do not mind to add another test for these changes, but I just want our understanding of necessity to be in sync.

andrewkolos · 2024-10-13T21:46:21Z

Ah, I failed to realize that we already have a test for detecting EAP versions. Since you added an expect against the version on that test, we're good here. Thanks for letting me know so patiently 🙂

andrewkolos

LGTM with a nitpick

Thanks again for the well-written PR

packages/flutter_tools/lib/src/android/android_studio.dart

bkonyi

LGTM!

bkonyi · 2024-10-15T14:23:24Z

packages/flutter_tools/lib/src/android/android_studio.dart

+      return null;
+    }
+
+    final int? major = int.tryParse('20${rawVersionMatch[0]}${rawVersionMatch[1]}');


This will break for Android Studio versions released starting in 2100 😉

Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>

Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>

Sameri11 · 2024-10-16T14:57:49Z

@andrewkolos @bkonyi thanks for your reviews guys, appreciate it! Now, when PR has 2 LGTMs, it is ready to merge as per tree hygiene, right? If so, would you be so kind to provide "autosubmit" label here, please? :)

bkonyi · 2024-10-16T15:34:17Z

@andrewkolos @bkonyi thanks for your reviews guys, appreciate it! Now, when PR has 2 LGTMs, it is ready to merge as per tree hygiene, right? If so, would you be so kind to provide "autosubmit" label here, please? :)

Yep! Just need to rerun that failing check. Hopefully it'll pass and should land on its own :)

…flutter#156293)

This PR willing to fix issue when `flutter doctor` validator can't determine version of Android Studio EAP. These are before/after outputs of `flutter doctor -v` showcasing change in behaviour of validator. Each output has 3 `Android Studio` sections, 1 for stable and 2 for different EAP versions. <details> <summary>before, (stable, 3.24.3), 2 issues related to versions of Android Studio</summary> ```console [â��] Flutter (Channel stable, 3.24.3, on macOS 14.7 23H124 darwin-arm64, locale en-RU) â�¢ Flutter version 3.24.3 on channel stable at /Users/samer/fvm/versions/stable â�¢ Upstream repository https://github.com/flutter/flutter.git â�¢ Framework revision 2663184 (4 weeks ago), 2024-09-11 16:27:48 -0500 â�¢ Engine revision 36335019a8 â�¢ Dart version 3.5.3 â�¢ DevTools version 2.37.3 [â��] Android toolchain - develop for Android devices (Android SDK version 34.0.0) â�¢ Android SDK at /Users/samer/Library/Android/sdk â�¢ Platform android-35, build-tools 34.0.0 â�¢ Java binary at: /Users/samer/Library/Java/JavaVirtualMachines/jbr-17.0.7/Contents/Home/bin/java â�¢ Java version OpenJDK Runtime Environment JBR-17.0.7+7-964.1-nomod (build 17.0.7+7-b964.1) â�¢ All Android licenses accepted. [â��] Xcode - develop for iOS and macOS (Xcode 16.0) â�¢ Xcode at /Applications/Xcode-16.0.app/Contents/Developer â�¢ Build 16A242d â�¢ CocoaPods version 1.15.2 [â��] Chrome - develop for the web â�¢ Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [â��] Android Studio (version 2024.1) â�¢ Android Studio at /Users/samer/Applications/Android Studio Koala Feature Drop 2024.1.2.app/Contents â�¢ Flutter plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/9212-flutter â�¢ Dart plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/6351-dart â�¢ Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314) [!] Android Studio (version unknown) â�¢ Android Studio at /Users/samer/Applications/Android Studio Ladybug Feature Drop 2024.2.2 Canary 2.app/Contents â�¢ Flutter plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/9212-flutter â�¢ Dart plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/6351-dart â�� Unable to determine Android Studio version. â�¢ Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11) [!] Android Studio (version unknown) â�¢ Android Studio at /Users/samer/Applications/Android Studio.app/Contents â�¢ Flutter plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/9212-flutter â�¢ Dart plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/6351-dart â�� Unable to determine Android Studio version. â�¢ Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11) [â��] IntelliJ IDEA Ultimate Edition (version EAP IU-243.12818.47) â�¢ IntelliJ at /Users/samer/Applications/IntelliJ IDEA Ultimate.app â�¢ Flutter plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/9212-flutter â�¢ Dart plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/6351-dart [â��] VS Code (version 1.94.0) â�¢ VS Code at /Applications/Visual Studio Code.app/Contents â�¢ Flutter extension version 3.98.0 [â��] Connected device (5 available) â�¢ sdk gphone64 arm64 (mobile) â�¢ emulator-5554 â�¢ android-arm64 â�¢ Android 15 (API 35) (emulator) â�¢ iPhone (Ð�Ð¸Ñ�Ð°Ð¸Ð») (mobile) â�¢ 00008020-001254DA1E39002E â�¢ ios â�¢ iOS 17.6.1 21G93 â�¢ macOS (desktop) â�¢ macos â�¢ darwin-arm64 â�¢ macOS 14.7 23H124 darwin-arm64 â�¢ Mac Designed for iPad (desktop) â�¢ mac-designed-for-ipad â�¢ darwin â�¢ macOS 14.7 23H124 darwin-arm64 â�¢ Chrome (web) â�¢ chrome â�¢ web-javascript â�¢ Google Chrome 129.0.6668.90 ! Error: Browsing on the local area network for Ð�Ð¸Ñ�Ð°Ð¸Ð» Ð�Ð¾Ð²Ð¾Ñ�ÐµÐ»Ñ�Ñ�ÐµÐ²â��s iPad. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac. The device must be opted into Developer Mode to connect wirelessly. (code -27) [â��] Network resources â�¢ All expected network resources are available. ! Doctor found issues in 2 categories. ``` </details> <details> <summary>after, no issues regarding Android Studio</summary> ```console [!] Flutter (Channel [user-branch], 3.26.0-1.0.pre.383, on macOS 14.7 23H124 darwin-arm64, locale en-RU) ! Flutter version 3.26.0-1.0.pre.383 on channel [user-branch] at /Users/samer/projects/flutter Currently on an unknown channel. Run `flutter channel` to switch to an official channel. If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/setup. â�¢ Upstream repository git@github.com:Sameri11/flutter.git â�¢ FLUTTER_GIT_URL = git@github.com:Sameri11/flutter.git â�¢ Framework revision 852508425d (20 minutes ago), 2024-10-07 21:22:45 +0500 â�¢ Engine revision 683a14c â�¢ Dart version 3.6.0 (build 3.6.0-326.0.dev) â�¢ DevTools version 2.40.0 â�¢ If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades. [â��] Android toolchain - develop for Android devices (Android SDK version 34.0.0) â�¢ Android SDK at /Users/samer/Library/Android/sdk â�¢ Platform android-35, build-tools 34.0.0 â�¢ Java binary at: /Users/samer/Library/Java/JavaVirtualMachines/jbr-17.0.7/Contents/Home/bin/java â�¢ Java version OpenJDK Runtime Environment JBR-17.0.7+7-964.1-nomod (build 17.0.7+7-b964.1) â�¢ All Android licenses accepted. [â��] Xcode - develop for iOS and macOS (Xcode 16.0) â�¢ Xcode at /Applications/Xcode-16.0.app/Contents/Developer â�¢ Build 16A242d â�¢ CocoaPods version 1.15.2 [â��] Chrome - develop for the web â�¢ Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [â��] Android Studio (version 2024.1) â�¢ Android Studio at /Users/samer/Applications/Android Studio Koala Feature Drop 2024.1.2.app/Contents â�¢ Flutter plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/9212-flutter â�¢ Dart plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/6351-dart â�¢ Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314) [â��] Android Studio (version 2024.2.2) â�¢ Android Studio at /Users/samer/Applications/Android Studio Ladybug Feature Drop 2024.2.2 Canary 2.app/Contents â�¢ Flutter plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/9212-flutter â�¢ Dart plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/6351-dart â�¢ Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11) [â��] Android Studio (version 2024.2.1) â�¢ Android Studio at /Users/samer/Applications/Android Studio.app/Contents â�¢ Flutter plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/9212-flutter â�¢ Dart plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/6351-dart â�¢ Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11) [â��] IntelliJ IDEA Ultimate Edition (version EAP IU-243.12818.47) â�¢ IntelliJ at /Users/samer/Applications/IntelliJ IDEA Ultimate.app â�¢ Flutter plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/9212-flutter â�¢ Dart plugin can be installed from: ð��¨ https://plugins.jetbrains.com/plugin/6351-dart [â��] VS Code (version 1.94.0) â�¢ VS Code at /Applications/Visual Studio Code.app/Contents â�¢ Flutter extension version 3.98.0 [â��] Connected device (5 available) â�¢ sdk gphone64 arm64 (mobile) â�¢ emulator-5554 â�¢ android-arm64 â�¢ Android 15 (API 35) (emulator) â�¢ iPhone (Ð�Ð¸Ñ�Ð°Ð¸Ð») (mobile) â�¢ 00008020-001254DA1E39002E â�¢ ios â�¢ iOS 17.6.1 21G93 â�¢ macOS (desktop) â�¢ macos â�¢ darwin-arm64 â�¢ macOS 14.7 23H124 darwin-arm64 â�¢ Mac Designed for iPad (desktop) â�¢ mac-designed-for-ipad â�¢ darwin â�¢ macOS 14.7 23H124 darwin-arm64 â�¢ Chrome (web) â�¢ chrome â�¢ web-javascript â�¢ Google Chrome 129.0.6668.90 ! Error: Browsing on the local area network for Ð�Ð¸Ñ�Ð°Ð¸Ð» Ð�Ð¾Ð²Ð¾Ñ�ÐµÐ»Ñ�Ñ�ÐµÐ²â��s iPad. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac. The device must be opted into Developer Mode to connect wirelessly. (code -27) [â��] Network resources â�¢ All expected network resources are available. ! Doctor found issues in 1 category. ``` </details> Logic behind these changes explained in flutter#121925 (comment) fixes flutter#121925 **Tests**: updated existing tests by adding version checking, but I don't mind writing new ones if necessary â�� please tell me if so.

…flutter#156293)

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 6, 2024

Sameri11 force-pushed the fix-android-studio-preview-version branch from b6e1084 to 22425b0 Compare October 6, 2024 17:06

navaronbracke reviewed Oct 7, 2024

View reviewed changes

packages/flutter_tools/lib/src/android/android_studio.dart Outdated Show resolved Hide resolved

Sameri11 marked this pull request as ready for review October 7, 2024 17:06

Sameri11 requested a review from navaronbracke October 7, 2024 17:06

navaronbracke reviewed Oct 7, 2024

View reviewed changes

packages/flutter_tools/lib/src/android/android_studio.dart Outdated Show resolved Hide resolved

Sameri11 force-pushed the fix-android-studio-preview-version branch from 8e7252d to 43ddfaa Compare October 8, 2024 06:28

Sameri11 requested a review from navaronbracke October 8, 2024 16:03

bkonyi requested review from andrewkolos and bkonyi and removed request for navaronbracke October 10, 2024 20:33

Sameri11 force-pushed the fix-android-studio-preview-version branch from 43ddfaa to c64bb02 Compare October 11, 2024 17:25

andrewkolos requested changes Oct 11, 2024

View reviewed changes

packages/flutter_tools/lib/src/android/android_studio.dart Outdated Show resolved Hide resolved

packages/flutter_tools/lib/src/android/android_studio.dart Outdated Show resolved Hide resolved

packages/flutter_tools/lib/src/android/android_studio.dart Show resolved Hide resolved

Sameri11 force-pushed the fix-android-studio-preview-version branch from 3acaf5a to 2629eb0 Compare October 12, 2024 16:11

Sameri11 requested a review from andrewkolos October 12, 2024 16:24

andrewkolos approved these changes Oct 13, 2024

View reviewed changes

packages/flutter_tools/lib/src/android/android_studio.dart Outdated Show resolved Hide resolved

Sameri11 force-pushed the fix-android-studio-preview-version branch 2 times, most recently from 63140bf to c94fa0d Compare October 15, 2024 07:49

bkonyi approved these changes Oct 15, 2024

View reviewed changes

Sameri11 force-pushed the fix-android-studio-preview-version branch 3 times, most recently from be7ba27 to 7b0f373 Compare October 16, 2024 12:51

Sameri11 and others added 5 commits October 16, 2024 19:52

fix android studio preview's version parsing

50ba6bf

Update packages/flutter_tools/lib/src/android/android_studio.dart

e96cbd5

Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>

convert throwing parsing to tryParse

a29ce46

adapt existing test

80274f8

test version parsing for Android Studio on MacOS

45909a9

Sameri11 and others added 5 commits October 16, 2024 19:52

Update packages/flutter_tools/lib/src/android/android_studio.dart

d7c1aaa

Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>

fix github-applied change (something broke in automatic suggestion)

41e954a

Update packages/flutter_tools/lib/src/android/android_studio.dart

86b9fd1

Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>

review fixes

66c36f1

Update packages/flutter_tools/lib/src/android/android_studio.dart

0cc0e2b

Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>

Sameri11 force-pushed the fix-android-studio-preview-version branch from 7b0f373 to 0cc0e2b Compare October 16, 2024 14:52

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 16, 2024

auto-submit bot merged commit ae6d793 into flutter:master Oct 16, 2024

engine-flutter-autoroll mentioned this pull request Oct 16, 2024

Manual roll Flutter from 6790525ce673 to 5644c032b388 (67 revisions) flutter/packages#7884

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 16, 2024

ae6d793 [tool] fix android studio preview's version parsing (flutter/…

b9af187

…flutter#156293)

engine-flutter-autoroll mentioned this pull request Oct 17, 2024

Manual roll Flutter from 6790525ce673 to 62414ee44e10 (80 revisions) flutter/packages#7888

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 17, 2024

ae6d793 [tool] fix android studio preview's version parsing (flutter/…

579a137

…flutter#156293)

Piinks mentioned this pull request Oct 18, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

ae6d793 [tool] fix android studio preview's version parsing (flutter/…

52b6e4e

…flutter#156293)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

ae6d793 [tool] fix android studio preview's version parsing (flutter/…

7df469d

…flutter#156293)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

ae6d793 [tool] fix android studio preview's version parsing (flutter/…

3d0bd9e

…flutter#156293)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

ae6d793 [tool] fix android studio preview's version parsing (flutter/…

fb7b236

…flutter#156293)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

ae6d793 [tool] fix android studio preview's version parsing (flutter/…

bc6bf22

…flutter#156293)

[tool] fix android studio preview's version parsing #156293

[tool] fix android studio preview's version parsing #156293

Uh oh!

Conversation

Sameri11 commented Oct 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

andrewkolos commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewkolos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sameri11 commented Oct 12, 2024

Uh oh!

andrewkolos commented Oct 13, 2024

Uh oh!

andrewkolos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

bkonyi Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sameri11 commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkonyi commented Oct 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sameri11 commented Oct 6, 2024 •

edited

Loading

andrewkolos commented Oct 11, 2024 •

edited

Loading

andrewkolos left a comment •

edited

Loading

andrewkolos left a comment •

edited

Loading

bkonyi Oct 15, 2024 •

edited

Loading

Sameri11 commented Oct 16, 2024 •

edited

Loading