Normalize ThemeData.tabBarTheme
#156253
Merged
Normalize ThemeData.tabBarTheme
#156253
+84
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34a2c76 to
74d362e
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 9, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 9, 2024
Roll Flutter from 0917e9d to 2d45fb3 (50 revisions) flutter/flutter@0917e9d...2d45fb3 2024-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4a97943e0556 to fb0b59d9438b (3 revisions) (flutter/flutter#156487) 2024-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from db0c0b7ca428 to 4a97943e0556 (9 revisions) (flutter/flutter#156478) 2024-10-09 engine-flutter-autoroll@skia.org Roll Packages from 8fbf4cd to 9d00fb1 (9 revisions) (flutter/flutter#156477) 2024-10-09 30870216+gaaclarke@users.noreply.github.com Started handling duplicate validation layer messages (flutter/flutter#156375) 2024-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0e7344ae240d to db0c0b7ca428 (4 revisions) (flutter/flutter#156443) 2024-10-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll pub packages (#156440)" (flutter/flutter#156473) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from ea4a00f1c123 to 0e7344ae240d (4 revisions) (flutter/flutter#156435) 2024-10-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#156440) 2024-10-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#156284) 2024-10-08 kevmoo@users.noreply.github.com [tool] Update description of where to install platforms in XCode (flutter/flutter#156432) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 167a42e50fa2 to ea4a00f1c123 (1 revision) (flutter/flutter#156433) 2024-10-08 36861262+QuncCccccc@users.noreply.github.com Normalize `ThemeData.tabBarTheme` (flutter/flutter#156253) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 82c1dfcf588c to 167a42e50fa2 (3 revisions) (flutter/flutter#156428) 2024-10-08 bruno.leroux@gmail.com Update MenuAnchor API examples (flutter/flutter#156404) 2024-10-08 jason-simmons@users.noreply.github.com Roll Dartdoc to 8.2.0 (flutter/flutter#156426) 2024-10-08 admosity@users.noreply.github.com Add `bySemanticsIdentifier` finder for finding by identifier (flutter/flutter#155571) 2024-10-08 120297255+PurplePolyhedron@users.noreply.github.com Update `DropdownMenu` tests to remove some dependence on platforms (flutter/flutter#156131) 2024-10-08 engine-flutter-autoroll@skia.org Roll Packages from bb00d34 to 8fbf4cd (10 revisions) (flutter/flutter#156407) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from bf21ee76f585 to 82c1dfcf588c (1 revision) (flutter/flutter#156406) 2024-10-08 jmccandless@google.com NavigatorPopHandler.onPopWithResult (flutter/flutter#155618) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8ec95fe63f2d to bf21ee76f585 (1 revision) (flutter/flutter#156402) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9306456e2532 to 8ec95fe63f2d (1 revision) (flutter/flutter#156401) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7e8011f3cc8e to 9306456e2532 (1 revision) (flutter/flutter#156398) 2024-10-08 dacoharkes@google.com Migrator for android 35/16kb page size cmake flags for plugin_ffi (flutter/flutter#156221) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 33c1a6a16e81 to 7e8011f3cc8e (5 revisions) (flutter/flutter#156392) 2024-10-08 tessertaha@gmail.com Update `flexible_space_bar_test.dart` tests for Material 3 (flutter/flutter#156226) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 012029ee19f3 to 33c1a6a16e81 (1 revision) (flutter/flutter#156390) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5923a8b3e632 to 012029ee19f3 (1 revision) (flutter/flutter#156388) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from fd1ccdb95e03 to 5923a8b3e632 (1 revision) (flutter/flutter#156386) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 07c702f2d79b to fd1ccdb95e03 (1 revision) (flutter/flutter#156384) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from e096ddb3091e to 07c702f2d79b (2 revisions) (flutter/flutter#156379) 2024-10-08 ditman@gmail.com [tool] Emit a deprecation warning for some values of --web-renderer. (flutter/flutter#156376) 2024-10-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 427302eafdda to e096ddb3091e (2 revisions) (flutter/flutter#156372) 2024-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from e84e30357ccc to 427302eafdda (3 revisions) (flutter/flutter#156364) 2024-10-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.2.0 to 4.2.1 (flutter/flutter#156366) 2024-10-07 737941+loic-sharma@users.noreply.github.com Clarify when `override: no versioning needed` label should be applied (flutter/flutter#156342) 2024-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c9d3f11f098 to e84e30357ccc (3 revisions) (flutter/flutter#156356) 2024-10-07 50643541+Mairramer@users.noreply.github.com Fixes an issue where onTapOutside was incorrectly triggered across routes in TapRegion (flutter/flutter#155297) 2024-10-07 biggs0125@gmail.com Update 'dump-info' usage for dart2js builds (flutter/flutter#156187) 2024-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from ffacad996f1f to 0c9d3f11f098 (2 revisions) (flutter/flutter#156347) 2024-10-07 andrewrkolos@gmail.com handle any `RPCError` due to vm service disconnection in `flutter run` (flutter/flutter#156346) 2024-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 683a14c1f1be to ffacad996f1f (1 revision) (flutter/flutter#156339) 2024-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8e46a7670b94 to 683a14c1f1be (1 revision) (flutter/flutter#156323) 2024-10-07 engine-flutter-autoroll@skia.org Roll Packages from 05bf1d4 to bb00d34 (8 revisions) (flutter/flutter#156322) 2024-10-07 tessertaha@gmail.com Fix `DropdownMenu` with `expandedInsets` always aligned on top (flutter/flutter#156214) 2024-10-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from a190ab54ce07 to 8e46a7670b94 (2 revisions) (flutter/flutter#156311) ...
9 tasks
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
…eData` (#157292) Following #156253, this PR changes the parameter type for `cardTheme`, `dialogTheme` and `tabBarTheme` from `Object?` to `xxxThemeData?`. The last potential failures in g3 have been removed: cl/692314033 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #155476, this PR is to normalize
ThemeData.tabBarTheme; change theTabBarTheme tabBarThemeproperty toTabBarThemeData tabBarThemeinThemeData. InThemeData()andThemeData.copyWith(), thetabBarThemeparameter type is changed toObject?to accept bothTabBarThemeandTabBarThemeDataso that we won't cause immediate breaking change and make sure rolling is smooth. Once all component themes are normalized, theseObject?types should be changed toxxxThemeData.There's no way to create a dart fix because we can't add a "@deprecated" label for TabBarTheme; TabBarTheme is a new InheritedWidget subclass now.
Addresses the "theme normalization" sub project within #91772
Pre-launch Checklist
///).