Move some tools test ownership to Ben #156123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkolos
commented
Oct 3, 2024
| /dev/devicelab/bin/tasks/hello_world_impeller.dart @gaaclarke @flutter/engine | ||
| /dev/devicelab/bin/tasks/home_scroll_perf__timeline_summary.dart @jtmcdole @flutter/engine | ||
| /dev/devicelab/bin/tasks/hot_mode_dev_cycle__benchmark.dart @eliasyishak @flutter/tool | ||
| /dev/devicelab/bin/tasks/hot_mode_dev_cycle__benchmark.dart @bkonyi @flutter/tool |
Contributor
Author
There was a problem hiding this comment.
The PR description isn't relevant to this particular change. I just noticed this line when going through this file.
eliasyishak no longer contributes to the flutter tool, so I'm choosing the tools TL as a default to take over here.
bkonyi
approved these changes
Oct 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 8, 2024
Manual roll requested by stuartmorgan@google.com flutter/flutter@ec2e12b...0917e9d 2024-10-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2068577e510b to 01de9dcf6bbf (1 revision) (flutter/flutter#156274) 2024-10-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d6bc39fe8b1 to 2068577e510b (1 revision) (flutter/flutter#156267) 2024-10-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92b5b318190b to 6d6bc39fe8b1 (4 revisions) (flutter/flutter#156266) 2024-10-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from fd6082ab6693 to 92b5b318190b (1 revision) (flutter/flutter#156261) 2024-10-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc5f9fc80b06 to fd6082ab6693 (4 revisions) (flutter/flutter#156258) 2024-10-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from eece6c3ec63a to bc5f9fc80b06 (2 revisions) (flutter/flutter#156252) 2024-10-04 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#156254) 2024-10-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9fa363bdde20 to eece6c3ec63a (1 revision) (flutter/flutter#156250) 2024-10-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from d38f5e560a98 to 9fa363bdde20 (1 revision) (flutter/flutter#156249) 2024-10-04 andrewrkolos@gmail.com remove bringup from Windows tool_integration_tests_* (flutter/flutter#156179) 2024-10-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 205484009711 to d38f5e560a98 (4 revisions) (flutter/flutter#156239) 2024-10-04 36861262+QuncCccccc@users.noreply.github.com Normalize `ThemeData.cardTheme` (flutter/flutter#153254) 2024-10-04 engine-flutter-autoroll@skia.org Roll Packages from 429650f to 05bf1d4 (5 revisions) (flutter/flutter#156225) 2024-10-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from e0109f0fd5b2 to 205484009711 (1 revision) (flutter/flutter#156216) 2024-10-04 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#156215) 2024-10-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from c2a9fb051bd0 to e0109f0fd5b2 (1 revision) (flutter/flutter#156213) 2024-10-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 66d397dff87a to c2a9fb051bd0 (5 revisions) (flutter/flutter#156206) 2024-10-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20369c5d2b93 to 66d397dff87a (5 revisions) (flutter/flutter#156188) 2024-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from de1762dbc5cc to 20369c5d2b93 (7 revisions) (flutter/flutter#156174) 2024-10-03 nate.w5687@gmail.com Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609) 2024-10-03 dkwingsmt@users.noreply.github.com Allow arrow keys to navigate `MenuAnchor` independently of global shortcut definition (flutter/flutter#155728) 2024-10-03 nate.w5687@gmail.com Inherited Theme: zero rebuilds (flutter/flutter#155699) 2024-10-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 247bc68c578e to de1762dbc5cc (4 revisions) (flutter/flutter#156160) 2024-10-03 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#156159) 2024-10-03 nate.w5687@gmail.com pattern-matching refactor (flutter/flutter#154753) 2024-10-03 thomas.hareau@protonmail.com Add autocorrect and enableSuggestions to SearchDelegate (flutter/flutter#154932) 2024-10-03 engine-flutter-autoroll@skia.org Roll Packages from 7c97c88 to 429650f (6 revisions) (flutter/flutter#156155) 2024-10-03 andrewrkolos@gmail.com Move some tools test ownership to Ben (flutter/flutter#156123) 2024-10-03 andrewrkolos@gmail.com further shard the Windows tool_integration_tests* targets (flutter/flutter#156121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
@andrewkolos I'd prefer if you don't mention me in PR descriptions (PR comments are fine), since these get squashed into commit messages, and GitHub will then count every time someone pushes the commit to their fork a "mention" and notify me... |
Contributor
Author
Mm, okay. I didn't consider that the PR descriptions get included into commit messages (and also that GitHub notifies you merely because some commit message referenced you??). I'm interested in whether I will see notifications myself because of this PR (since I tagged myself in the description), because I have never had this happen to me before (perhaps I simply haven't been tagged in a PR description before). |
Contributor
Yeah, this is a bug in GitHub, as far as I'm concerned... |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5eca44a moved some ownership of tests from @christopherfujino to @andrewkolos since Chris was no longer leading engineering efforts for the
fluttertool. Now that @bkonyi is leading, this PR moves ownership of these test suites to him.@bkonyi, note that this doesn't imply that you will be responsible for fixing any issues in these tests. This just means that the bot will assign flake issues to you for further triage.