Add code sample to the CupertinoMagnifier/CupertinoTextMagnifier #156028
Conversation
|
Code samples must have accompanying tests. |
TahaTesser
left a comment
There was a problem hiding this comment.
Thanks for contributing. Great start!
examples/api/lib/widgets/magnifier/cupertino_text_magnifier.0.dart
Outdated
Show resolved
Hide resolved
examples/api/lib/widgets/magnifier/cupertino_text_magnifier.0.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
…dart Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
…dart Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
|
I have added a few tests, not sure if I can go deeper than that. |
bleroux
left a comment
There was a problem hiding this comment.
Thanks for this great addition!
I spotted some formatting issues and small typos.
examples/api/test/widgets/magnifier/cupertino_magnifier.0_test.dart
Outdated
Show resolved
Hide resolved
| ), | ||
| child: Center( | ||
| child: Column( | ||
| mainAxisAlignment: MainAxisAlignment.center, |
There was a problem hiding this comment.
From line 42 to 75 there is too much indentation.
There was a problem hiding this comment.
Hi, Bleroux.
I'm having too many formatting issues. How can I improve on it?
Can I fix those issues simply by using the IDE's 'Format Document' feature?
There was a problem hiding this comment.
Hey @RamonFarizel ,
unfortunately auto format is not an option on the Flutter repo for the moment (it might be in 2025), but for the moment, according to the contribution guide, readability is key and can't be achieved with current autoformat tool (it will be soon 🤞).
In that particular case, from your IDE, you can just select lines 42 to 75 and hit shift+tab to remove one level of indentation.
I'm having too many formatting issues. How can I improve on it?
Do you mean for this PR or for other flutter/flutter contributions?
For this PR, as far as I can tell this indentation issue is the only remaining formatting issue.
(On the test side, it looks like you used autoformat, I will suggest some small changes later to make things a little more readable).
There was a problem hiding this comment.
Good to know! Thanks for your answer!
Yeah, I was using auto format.
My question was focused on future contributions. I want to ensure that I don't repeat these mistakes in the future.
examples/api/test/widgets/magnifier/cupertino_magnifier.0_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
|
|
….dart Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
….dart Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
….dart Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
…dart Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
…dart Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
…dart Co-authored-by: Taha Tesser <tessertaha@gmail.com>
This PR adds code samples regarding the CupertinoMagnifier and CupertinoTextMagnifier
Fixes #154439
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.