Preserve transform when using *Gradient:withOpacity #154908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i think it wasn't intentional to lose it?
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Member
|
It does look like an oversight. Thanks for fixing it. Looks like it is failing some checks, though. Can you please take a look? Thank you. |
Contributor
Author
|
I think the failed tests are unrelated to this CL, lemme wait a bit for head being green again. |
Contributor
Author
|
@goderbauer just fixed some typos i made which made the tests failing, checks are passing now :) PTAL. thanks! |
Contributor
nate-thegrate
left a comment
There was a problem hiding this comment.
It feels a bit weird to fix LinearGradient whilst ignoring the same bug in RadialGradient & SweepGradient.
Do you think you could expand this fix to include the other Gradient subtypes?
nate-thegrate
approved these changes
Sep 16, 2024
Contributor
nate-thegrate
left a comment
There was a problem hiding this comment.
I wanted to make a tiny wording suggestion, but otherwise this LGTM 👍
Thanks for catching & fixing this bug!
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
Contributor
Author
|
feel free to merge the PR, just realised i don't have access to submit the cl :) |
Contributor
Sounds good! Per the Tree Hygiene page, we'll be able to merge once we have 2 approvals. I'll send out a message today to see if we can get a second stamp here :) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 25, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 25, 2024
Roll Flutter from 4ca51a1 to 538e742 (40 revisions) flutter/flutter@4ca51a1...538e742 2024-09-25 fluttergithubbot@gmail.com Marks Linux build_aar_module_test to be unflaky (flutter/flutter#155349) 2024-09-25 engine-flutter-autoroll@skia.org Roll Packages from 4926c0f to 7da2374 (3 revisions) (flutter/flutter#155701) 2024-09-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Normalize TabBarTheme (#155476)" (flutter/flutter#155698) 2024-09-25 36861262+QuncCccccc@users.noreply.github.com Normalize TabBarTheme (flutter/flutter#155476) 2024-09-25 christopherfujino@gmail.com increase both linux & windows tool integration test shards (flutter/flutter#155631) 2024-09-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from c7cd559e483b to d6d5fdba6ae1 (1 revision) (flutter/flutter#155693) 2024-09-25 sokolovskyi.konstantin@gmail.com Add WidgetStateBorderSide example and tests for it. (flutter/flutter#155559) 2024-09-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from b9dd7a39dd58 to c7cd559e483b (1 revision) (flutter/flutter#155686) 2024-09-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 87c1667dfd1e to b9dd7a39dd58 (1 revision) (flutter/flutter#155684) 2024-09-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 05211f9d2267 to 87c1667dfd1e (1 revision) (flutter/flutter#155681) 2024-09-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8d1eb7410b49 to 05211f9d2267 (1 revision) (flutter/flutter#155672) 2024-09-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from ad3dd0df0fe7 to 8d1eb7410b49 (2 revisions) (flutter/flutter#155662) 2024-09-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 746ce6124844 to ad3dd0df0fe7 (2 revisions) (flutter/flutter#155653) 2024-09-25 magder@google.com Add PrivacyInfo.xcprivacy to macOS plugin template (flutter/flutter#155570) 2024-09-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 559f2ff31c74 to 746ce6124844 (14 revisions) (flutter/flutter#155648) 2024-09-25 120297255+PurplePolyhedron@users.noreply.github.com fix `SearchAnchor` disposing `SearchController` while it is still used (flutter/flutter#155219) 2024-09-25 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#155640) 2024-09-24 hhugh@google.com Preserve transform when using *Gradient:withOpacity (flutter/flutter#154908) 2024-09-24 nick9822@gmail.com fixed keyboardDismissBehavior on scroll without a drag (flutter/flutter#154675) 2024-09-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7cd3d0b1bb2e to 559f2ff31c74 (3 revisions) (flutter/flutter#155629) 2024-09-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2a13c3a27e1f to 7cd3d0b1bb2e (4 revisions) (flutter/flutter#155625) 2024-09-24 parlough@gmail.com Misc docs cleanup and fixes (flutter/flutter#155501) 2024-09-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from dc44f95b7027 to 2a13c3a27e1f (1 revision) (flutter/flutter#155619) 2024-09-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2745b8797025 to dc44f95b7027 (1 revision) (flutter/flutter#155616) 2024-09-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8a54cc56d4b9 to 2745b8797025 (2 revisions) (flutter/flutter#155610) 2024-09-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from c07812775255 to 8a54cc56d4b9 (2 revisions) (flutter/flutter#155607) 2024-09-24 engine-flutter-autoroll@skia.org Roll Packages from 9de72be to 4926c0f (4 revisions) (flutter/flutter#155605) 2024-09-24 danny@tuppeny.com Fix some broken links in DAP readme (flutter/flutter#155600) 2024-09-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22e4f015cc99 to c07812775255 (2 revisions) (flutter/flutter#155599) 2024-09-24 danny@tuppeny.com [flutter_tools] Fix encoded stderr in "dart.log" from debug adapter to client (flutter/flutter#155249) 2024-09-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 309468cfd1bb to 22e4f015cc99 (2 revisions) (flutter/flutter#155591) 2024-09-24 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#155432) 2024-09-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4013dc28a48b to 309468cfd1bb (2 revisions) (flutter/flutter#155588) 2024-09-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8a5af19a43f3 to 4013dc28a48b (1 revision) (flutter/flutter#155585) 2024-09-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 95c5a0940ad9 to 8a5af19a43f3 (10 revisions) (flutter/flutter#155583) 2024-09-24 sokolovskyi.konstantin@gmail.com Add `WidgetStateProperty` example and tests for it. (flutter/flutter#155315) 2024-09-24 30870216+gaaclarke@users.noreply.github.com Redo flutter engine flutter autoroll bd3d1990 485b 419c 8c55 b27e3eeb15ed 1727117767 (flutter/flutter#155579) 2024-09-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 61f0a3fbabbe to 9bb0ece79ae2 (2 revisions) (flutter/flutter#155549) 2024-09-23 magder@google.com Assert macOS framework artifact contains xcprivacy manifest (flutter/flutter#155189) 2024-09-23 engine-flutter-autoroll@skia.org Roll Packages from f54fe93 to 9de72be (1 revision) (flutter/flutter#155540) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. ...
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
i don't think it was intentional to lose it? - [] All existing and new tests are passing.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i don't think it was intentional to lose it?
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.