-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Roll Flutter Engine from c50eb8a65097 to 419fb8c0ab3e #154734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
I'm working on fixing this PR |
| 'leak_tracker': '10.0.7', // https://github.com/flutter/devtools/issues/3951 | ||
| 'leak_tracker_testing': '3.0.1', // https://github.com/flutter/devtools/issues/3951 | ||
| 'leak_tracker_flutter_testing': '3.0.8', // https://github.com/flutter/devtools/issues/3951 | ||
| 'path_provider_android': '2.2.1', // https://github.com/flutter/flutter/issues/140796 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @goderbauer & @gmackall I re-pinned path_provider_android to unblock this roll :'(
|
A little bit of context, package:_macros recently bumped its version and package:analyzer was forced to raise its lower constraint on it: dart-lang/sdk@5285faa#diff-a8403f1fc69a35a5ee70b920d57c1d402b06e5d10929ec8daedfebbf8c34c42fR16 When this Dart SDK change was attempted in an engine -> framework autoroll, it failed pub solving in the flutter_tools: #154731 because flutter_tools did not yet have the newer version of analyzer. I resolved the issue by manually running |
|
https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20framework_tests_libraries/68219/infra |
@gaaclarke Wondering if this could be due to flutter/engine#54714 ? |
this could be the golden file issue that @gaaclarke was talking about |
It's not quite what I was expecting. I had to fix one of these types of failures to get the PR through presubmit checks. Here's how I addressed it: https://github.com/flutter/flutter/pull/154680/files I'm not sure why the test runs here, but not in presubmit. I would be fine just updating that assertion or making it fuzzy like I did above as part of this roll. |
@gaaclarke can you make your suggested change in this PR so we can rerun the tests and see if that works out. |
|
Oops. I pushed a change that just naively updates the test expectation, but looking at the previous addition of a new matcher, I suspect that's not quite right. |
|
I don't have permissions to push to this branch. Here's the patch: |
|
@zanderso how come you can push? This is what I got: |
|
I will apply your patch and push it, not sure why you are getting the authentication error. |
flutter/engine@c50eb8a...419fb8c
2024-09-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] always force platform channel responses to schedule a task. (#54975)" (flutter/engine#55000)
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from b6bab0fde426 to 6ad117bd2efe (2 revisions) (flutter/engine#54999)
2024-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from D9INMR2u4wcyiZ750... to 5dqcFlKzRjJb6V95W... (flutter/engine#54998)
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from a09312b70d37 to b6bab0fde426 (3 revisions) (flutter/engine#54997)
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 368f209ccca5 to a09312b70d37 (1 revision) (flutter/engine#54995)
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from aec11ae18bb6 to 368f209ccca5 (3 revisions) (flutter/engine#54992)
2024-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xNv47d1TZmK9XgTxu... to PBeI0gGvgFdXV6hCg... (flutter/engine#54990)
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 809f868ded1c to aec11ae18bb6 (22 revisions) (flutter/engine#54988)
2024-09-06 30870216+gaaclarke@users.noreply.github.com Removes the int storage from Color (flutter/engine#54714)
2024-09-06 chris@bracken.jp iOS,macOS: Add logging of duplicate codesign binaries (flutter/engine#54987)
2024-09-06 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from k4lKsecg0pdIp-U7c... to D9INMR2u4wcyiZ750... (flutter/engine#54984)
2024-09-05 a-siva@users.noreply.github.com Manual roll of Dart. (flutter/engine#54983)
2024-09-05 chris@bracken.jp iOS,macOS: add unsigned_binaries.txt (flutter/engine#54977)
2024-09-05 jason-simmons@users.noreply.github.com Manual Skia roll to 809f868ded1c (flutter/engine#54972)
2024-09-05 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix incorrect calculation of ImageFilter paint bounds (flutter/engine#54980)
2024-09-05 jonahwilliams@google.com [engine] always force platform channel responses to schedule a task. (flutter/engine#54975)
2024-09-05 tugorez@users.noreply.github.com Fix unexpected ViewFocus events when Text Editing utilities change focus in the middle of a blur call. (flutter/engine#54965)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from xNv47d1TZmK9 to PBeI0gGvgFdX