Updated iPhone enable developer mode instructions #154511
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Converting to draft since some tests need to be updated (see the ones in failing |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
c523627 to
a3f4aad
Compare
a3f4aad to
d055922
Compare
@jmagman Have you ever heard of this before? That is, having to open Xcode and disconnect/reconnect your device before being able to enable Developer Mode on the device? I'm questioning whether or not there is actually a tool bug here. |
That is what worked for me, so I added the PR. Also see |
| String flutterSpecifiedDeviceDevModeDisabled(String deviceName) => 'To use ' | ||
| "'$deviceName' for development, enable Developer Mode in Settings → Privacy & Security."; | ||
| "'$deviceName' for development, open Xcode, reconnect the '$deviceName' and enable Developer Mode in Settings → Privacy & Security."; |
There was a problem hiding this comment.
Also see
https://stackoverflow.com/questions/77648341/flutter-not-reading-device-developer-mode-setting
Thanks for the link! I can see now that this is a legitimate UX problem.
I think the text change proposed here is a little confusing (though it's possible this is due to me not testing on physical iOS devices very often). When I first read it, I thought it was telling me to change settings in Xcode, not on the device.
Referencing the StackOverflow thread linked, I propose this as a starting point:
To use <device> for development, enable Developer Mode in Settings → Privacy & Security on your device.
If this does not work, open Xcode, reconnect the device, and look for a popup on the device asking you to trust this computer.
|
Unlisting myself as a reviewer since I have directly pushed changes (context: #154511 (comment)) |
@andrewkolos I hereby bless you to give you the second LGTM 🙏 @virajkanwade Thank you for the contribution! |
The instructions specify to enable Developer Mode in Privacy and Security. But Developer Mode option is not available, unless you open Xcode and reconnect the device.
9/23 edit from @andrewkolos: See https://stackoverflow.com/questions/77648341/flutter-not-reading-device-developer-mode-setting
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.