Skip to content

Fix DropdownMenu focus traversal #153931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Aug 23, 2024
Merged

Fix DropdownMenu focus traversal #153931

auto-submit merged 2 commits into from
Aug 23, 2024

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented Aug 22, 2024 •
edited
Loading

Description

This PR fixes DropdownMenu focus traversal.

Before this PR, if a DropdownMenu contains several items, the 'tab' key had to be pressed many times before the focus move to the inner text field.

This fix is based on #131120 (comment).

Related Issue

Fixes #131120.

Tests

Adds 1 test.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 22, 2024
@bleroux bleroux requested a review from gspencergoog August 22, 2024 16:15
gspencergoog
gspencergoog approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

bleroux and others added 2 commits August 23, 2024 08:53
@bleroux
Fix DropdownMenu focus traversal
7118dc8
@bleroux @gspencergoog
Use ExcludeFocus.excluding
b333992 
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
@bleroux bleroux force-pushed the fix_dropdown_menu_focus_traversal branch from 5e56b08 to b333992 Compare August 23, 2024 06:53
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2024
@auto-submit auto-submit bot merged commit 402ed6c into flutter:master Aug 23, 2024
@bleroux bleroux deleted the fix_dropdown_menu_focus_traversal branch August 23, 2024 08:42
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
a423129
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
806125a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
d698faa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
c241a97
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
373336b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
309683b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
1fa4020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
6eca389
@Piinks Piinks mentioned this pull request Aug 23, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
fffbb7e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
57ded05
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
2db2696
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
aad5b0e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
d0bec3c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
14c2d04
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
1fae46e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
73ab5e1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
8a95823
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
a3fba53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
98e1611
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@bleroux @Buchimi
Fix DropdownMenu focus traversal (flutter#153931)
a85bb06 
## Description

This PR fixes `DropdownMenu` focus traversal.

Before this PR, if a `DropdownMenu` contains several items, the 'tab' key had to be pressed many times before the focus move to the inner text field.

This fix is based on flutter#131120 (comment).

## Related Issue

Fixes flutter#131120.

## Tests

Adds 1 test.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
5476a28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
d9fff97
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
5020999
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
dd445e7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
b326325
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
a330b6b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
aef6e80
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
feaf1c5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
dd6e679
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
e6091ed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
e4dc26f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
322c779
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
4f25cc3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
84c1699
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
75a95bf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
2feb2e1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
c57a02e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
6659ff2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
402ed6c Fix DropdownMenu focus traversal (flutter/flutter#153931)
7c9b34f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DropdownMenu] Focus Traversal does not work between multiple fields

2 participants

@bleroux @gspencergoog