[Swift Package Manager] Test removing the last Flutter plugin #153519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e62421e to
0743da7
Compare
jmagman
reviewed
Aug 15, 2024
packages/flutter_tools/test/integration.shard/swift_package_manager_test.dart
Show resolved
Hide resolved
loic-sharma
commented
Aug 15, 2024
| expect(generatedManifestFile.existsSync(), isTrue); | ||
|
|
||
| generatedManifest = generatedManifestFile.readAsStringSync(); | ||
| const String emptyDependencies = 'dependencies: [\n \n ],\n'; |
Member
Author
There was a problem hiding this comment.
This doesn't use the multi-line string syntax as code editors often aggressively trim trailing whitespace on save, which breaks the test.
jmagman
approved these changes
Aug 15, 2024
Member
jmagman
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding this test!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 16, 2024
flutter/flutter@bced008...a0c0453 2024-08-16 nate.w5687@gmail.com Style Guide updates (flutter/flutter#152525) 2024-08-16 engine-flutter-autoroll@skia.org Roll Packages from 86d15a6 to 2c37fb0 (5 revisions) (flutter/flutter#153571) 2024-08-16 zanderso@users.noreply.github.com Move Android API level 35 emulator tests to staging (flutter/flutter#153568) 2024-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from a8fefc81188e to d5bf3afc601f (2 revisions) (flutter/flutter#153565) 2024-08-16 737941+loic-sharma@users.noreply.github.com [Swift Package Manager] Test removing the last Flutter plugin (flutter/flutter#153519) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…r#153519) The Flutter tool has a bug where removing the last Flutter plugin does not correctly update the CocoaPods integration. This adds a test to ensure that the generated Swift package is properly updated when the last Flutter plugin is removed. See: flutter#11819 (comment)
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…r#153519) The Flutter tool has a bug where removing the last Flutter plugin does not correctly update the CocoaPods integration. This adds a test to ensure that the generated Swift package is properly updated when the last Flutter plugin is removed. See: flutter#11819 (comment)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flutter tool has a bug where removing the last Flutter plugin does not correctly update the CocoaPods integration.
This adds a test to ensure that the generated Swift package is properly updated when the last Flutter plugin is removed.
See: #11819 (comment)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.