Skip to content

Conversation

@piedcipher
Copy link
Member

@piedcipher piedcipher commented Aug 5, 2024

Fixed #151371

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 5, 2024
@piedcipher piedcipher requested a review from goderbauer August 5, 2024 16:19
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piedcipher piedcipher self-assigned this Aug 5, 2024
@piedcipher piedcipher added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2024
@auto-submit auto-submit bot merged commit 68983f7 into flutter:master Aug 5, 2024
@piedcipher piedcipher deleted the fix/151371 branch August 5, 2024 18:29
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 6, 2024
Manual roll requested by tarrinneal@google.com

flutter/flutter@3832823...1dd7141

2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 376a853846ce to f5f6e966e7e7 (1 revision) (flutter/flutter#152911)
2024-08-06 zanderso@users.noreply.github.com Pass --no-dds to some integration tests driven by flutter drive (flutter/flutter#152898)
2024-08-06 kevmoo@users.noreply.github.com Manual dependency bump (flutter/flutter#152881)
2024-08-06 32538273+ValentinVignal@users.noreply.github.com Add tests for ordered_traversal_group.0.dart (flutter/flutter#152849)
2024-08-06 nate.w5687@gmail.com Implement `on` clauses (flutter/flutter#152706)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc140a0124b7 to 376a853846ce (2 revisions) (flutter/flutter#152905)
2024-08-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from e073ad2e3ad4 to bc140a0124b7 (1 revision) (flutter/flutter#152895)
2024-08-05 42016383+DBowen33@users.noreply.github.com added functionality to where SR will communicate button clicked (flutter/flutter#152185)
2024-08-05 goderbauer@google.com more docImports (flutter/flutter#151951)
2024-08-05 goderbauer@google.com Bump dartdoc to 8.0.13 (flutter/flutter#152896)
2024-08-05 tessertaha@gmail.com [Reland] Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (flutter/flutter#152890)
2024-08-05 36861262+QuncCccccc@users.noreply.github.com Fix CarouselView rebuild (flutter/flutter#152791)
2024-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1bfd06cda313 to e073ad2e3ad4 (4 revisions) (flutter/flutter#152889)
2024-08-05 737941+loic-sharma@users.noreply.github.com Add migration to git ignore SwiftPM build directories (flutter/flutter#152766)
2024-08-05 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#152127)
2024-08-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0aac60342005 to 1bfd06cda313 (2 revisions) (flutter/flutter#152868)
2024-08-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (#152472)" (flutter/flutter#152885)
2024-08-05 pateltirth454@gmail.com [Docs] DeviceOrientation Enum Correction (flutter/flutter#152876)
2024-08-05 zanderso@users.noreply.github.com Move Linux_build_test tests from staging to prod (flutter/flutter#152877)
2024-08-05 tessertaha@gmail.com Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (flutter/flutter#152472)
2024-08-05 zanderso@users.noreply.github.com Mark Linux_android_emu tests bringup: true (flutter/flutter#152867)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The descriptions of some values in DeviceOrientation enum is wrong.

2 participants