Fix `flutter create` warning regarding Java compatibility #152836

shashwatpathak98 · 2024-08-04T13:59:11Z

This PR modifies the warning message regarding Java compatibility to make it consistent with the Flutter style guide.

Current message looks like this

[RECOMMENDED] If so, to keep the default AGP version 8.1.0, make
sure to download a compatible Java version
(Java 17 <= compatible Java version < Java 21).
You may configure this compatible Java version by running:
`flutter config --jdk-dir=<JDK_DIRECTORY>`
Note that this is a global configuration for Flutter.

Alternatively, to continue using your configured Java version, update the AGP
version specified in the following files to a compatible AGP
version (minimum compatible AGP version: 7.0) as necessary:
    -   /home/user/project/testproj/android/build.gradle

See
https://developer.android.com/build/releases/gradle-plugin for details on
compatible Java/AGP versions.

After Modification

To keep the default AGP version 8.1.0, download a compatible Java version 
(Java 17 <= compatible Java version < Java 21). Configure this Java version 
globally for Flutter by running:

  flutter config --jdk-dir=<JDK_DIRECTORY>

Alternatively, to continue using your current Java version, update the AGP 
version in the following file(s) to a compatible version (minimum AGP version: 7.0):

  /home/user/project/testproj/android/build.gradle

For details on compatible Java and AGP versions, see
https://developer.android.com/build/releases/gradle-plugin

Fixes #152460

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-08-04T13:59:15Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Hixie · 2024-08-04T18:36:24Z

packages/flutter_tools/lib/src/commands/create.dart

  final gradle.JavaAgpCompat? minimumCompatibleAgpVersion = gradle.getMinimumAgpVersionForJavaVersion(globals.logger, javaV: javaVersion);
  final String compatibleAgpVersionMessage = minimumCompatibleAgpVersion == null ? '' : ' (minimum compatible AGP version: ${minimumCompatibleAgpVersion.agpMin})';
-  final String gradleBuildFilePaths = '    -  ${_getBuildGradleConfigurationFilePaths(projectType, projectDirPath)!.join('\n    - ')}';
+  final String gradleBuildFilePaths = '    - ${_getBuildGradleConfigurationFilePaths(projectType, projectDirPath)!.join('\n    - ')}';


let's remove the - here too since we don't have it where we give the url later

Sure, I removed it.

Hixie · 2024-08-07T01:07:01Z

change looks good to me, but as the bot says, it will need tests to make sure we don't break it again :-)

the test could just be something like, check that each line is less than the max line length, and check that each line is more than half the line length unless the next line is empty. or something like that.

shashwatpathak98 · 2024-08-08T09:06:49Z

Thanks @Hixie Sure , working on the test.

…ava-compatibility-warning

ishon19 · 2024-08-15T12:58:18Z

Hi @Hixie! Thanks for the review, I added a test, which seems to be functional.

packages/flutter_tools/lib/src/commands/create.dart

Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>

andrewkolos

LGTM! This will need another approval from a flutter contributor to land. I will wait to see if @Hixie has any more thoughts. Otherwise, I'll look for another reviewer in a week or so.

ishon19 · 2024-08-30T20:39:35Z

LGTM! This will need another approval from a flutter contributor to land. I will wait to see if @Hixie has any more thoughts. Otherwise, I'll look for another reviewer in a week or so.

Awesome, thanks a lot for the review @andrewkolos!

christopherfujino

LGTM

…utter/flutter#152836)

shashwatpathak98 · 2024-09-11T17:15:03Z

LGTM

Thanks @christopherfujino

…utter/flutter#152836)

Roll Flutter from 2e221e7 to 303f222 (77 revisions) flutter/flutter@2e221e7...303f222 2024-09-12 34871572+gmackall@users.noreply.github.com Manual roll to 48ddaf578fb0c8326d5b4b680b0f49ea72e33216 (flutter/flutter#155070) 2024-09-12 reidbaker@google.com Externalize and update onboarding instructions (flutter/flutter#154730) 2024-09-12 andrewrkolos@gmail.com when setting up the log reader for a device during `flutter run`, discard any `RPCError` thrown due to the device being disconnected (flutter/flutter#155049) 2024-09-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "iOS: update provisioning profile for 2024-2025 cert (#155052)" (flutter/flutter#155059) 2024-09-12 chris@bracken.jp iOS: update provisioning profile for 2024-2025 cert (flutter/flutter#155052) 2024-09-11 nate.w5687@gmail.com Factor out `Container` objects (flutter/flutter#153619) 2024-09-11 matanlurey@users.noreply.github.com Move (`dev/tools`), complete v0 of `native_driver` (Android) (flutter/flutter#154843) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from ade8ef293bc6 to ee5adf6d2ee1 (2 revisions) (flutter/flutter#155046) 2024-09-11 737941+loic-sharma@users.noreply.github.com Fix `flutter run` on Mac x64 hosts if Swift Package Manager is enabled (flutter/flutter#154645) 2024-09-11 engine-flutter-autoroll@skia.org Roll Packages from bb53e5d to 4c18648 (1 revision) (flutter/flutter#155033) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4eb729b7a5c4 to ade8ef293bc6 (3 revisions) (flutter/flutter#155031) 2024-09-11 34465683+rkishan516@users.noreply.github.com fix: Dropdown menu trying to access highlight element which doesn't exist when search and filters both are enabled (flutter/flutter#151969) 2024-09-11 fluttergithubbot@gmail.com Marks Linux build_tests_3_5 to be unflaky (flutter/flutter#154993) 2024-09-11 abnhamoda@gmail.com Add 'direction' allow to 'SegmentedButton' oriented vertically (flutter/flutter#150903) 2024-09-11 fluttergithubbot@gmail.com Marks Linux build_tests_5_5 to be unflaky (flutter/flutter#154995) 2024-09-11 chingjun@google.com Update the signature of DDS launcher callback. (flutter/flutter#154949) 2024-09-11 30870216+gaaclarke@users.noreply.github.com Migrate Color.toString() test, improves `equalsIgnoringHashCodes` (flutter/flutter#154934) 2024-09-11 36861262+QuncCccccc@users.noreply.github.com Update material and cupertino localizations (flutter/flutter#154959) 2024-09-11 fluttergithubbot@gmail.com Marks Linux build_tests_1_5 to be unflaky (flutter/flutter#154991) 2024-09-11 fluttergithubbot@gmail.com Marks Linux build_tests_2_5 to be unflaky (flutter/flutter#154992) 2024-09-11 111122076+shashwatpathak98@users.noreply.github.com Fix `flutter create` warning regarding Java compatibility (flutter/flutter#152836) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 54757dab9462 to 4eb729b7a5c4 (1 revision) (flutter/flutter#155022) 2024-09-11 34871572+gmackall@users.noreply.github.com Fix java version used by `build_aar_module_test` (flutter/flutter#154967) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0a14c519ea4f to 54757dab9462 (1 revision) (flutter/flutter#155015) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 35a3171b72c5 to 0a14c519ea4f (1 revision) (flutter/flutter#154984) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from b9c0b96c3316 to 35a3171b72c5 (1 revision) (flutter/flutter#154980) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 52eeea075767 to b9c0b96c3316 (1 revision) (flutter/flutter#154976) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from a26075f9b1e6 to 52eeea075767 (1 revision) (flutter/flutter#154973) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 60c15bc0f40e to a26075f9b1e6 (6 revisions) (flutter/flutter#154969) 2024-09-11 matanlurey@users.noreply.github.com Migrate `apple-mobile-web-*` to `mobile-web-*`. (flutter/flutter#154964) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8a038a6f7099 to 60c15bc0f40e (15 revisions) (flutter/flutter#154960) 2024-09-10 30870216+gaaclarke@users.noreply.github.com Adds dart fixes for Color opacity functions (flutter/flutter#154953) 2024-09-10 codefu@google.com Missing benchmarks for `foundation/all_elements_bench.dart` (flutter/flutter#154954) 2024-09-10 30870216+gaaclarke@users.noreply.github.com Update color assertions (flutter/flutter#154752) 2024-09-10 andrewrkolos@gmail.com handle EAGAIN (macOS) in ErrorHandlingProcessManager (flutter/flutter#154306) 2024-09-10 50643541+Mairramer@users.noreply.github.com fix unpack freezing app with animation duration zero (flutter/flutter#153890) 2024-09-10 matanlurey@users.noreply.github.com Remove last `--disable-dart-dev` in `flutter/flutter`. (flutter/flutter#154948) 2024-09-10 34871572+gmackall@users.noreply.github.com Remove scheduler: luci from new `build_aar_module_test` (flutter/flutter#154945) 2024-09-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#154939) 2024-09-10 36861262+QuncCccccc@users.noreply.github.com `CupertinoSlidingSegmentedControl` update (flutter/flutter#152976) 2024-09-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#154933) 2024-09-10 andrewrkolos@gmail.com fix test `chrome.close can recover if getTab throws a StateError` (flutter/flutter#154889) 2024-09-10 jmccandless@google.com SearchBar context menu (flutter/flutter#154833) 2024-09-10 34871572+gmackall@users.noreply.github.com Fix `flutter build aar` for modules that use a plugin (flutter/flutter#154757) 2024-09-10 engine-flutter-autoroll@skia.org Roll Packages from b4e0fc1 to bb53e5d (4 revisions) (flutter/flutter#154926) 2024-09-10 tessertaha@gmail.com Clean up `SnackBar` inherit theme data test (flutter/flutter#154921) ...

…utter/flutter#152836)

fix: warning message cleanup

cc4e296

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 4, 2024

Hixie reviewed Aug 4, 2024

View reviewed changes

fix: remove - from gradleBuildFilePaths

7ff550e

shashwatpathak98 requested a review from Hixie August 6, 2024 10:05

test: add test for warning message

1b7ec8e

ishon19 force-pushed the fix/152460-java-compatibility-warning branch from d929803 to 1b7ec8e Compare August 14, 2024 13:02

ishon19 and others added 2 commits August 14, 2024 09:06

Merge branch 'master' of github.com:flutter/flutter into fix/152460-j…

0a0b0cb

…ava-compatibility-warning

Merge branch 'master' into fix/152460-java-compatibility-warning

96a98cf

ishon19 added 2 commits August 16, 2024 08:00

Merge branch 'master' into fix/152460-java-compatibility-warning

3c16fcf

Merge branch 'master' into fix/152460-java-compatibility-warning

87eecdf

andrewkolos self-requested a review August 22, 2024 19:53

andrewkolos reviewed Aug 29, 2024

View reviewed changes

packages/flutter_tools/lib/src/commands/create.dart Outdated Show resolved Hide resolved

andrewkolos reviewed Aug 29, 2024

View reviewed changes

packages/flutter_tools/lib/src/commands/create.dart Outdated Show resolved Hide resolved

ishon19 and others added 3 commits August 30, 2024 04:28

fix: use pluralizing suffix for file

47e4213

Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>

fix: remove semicolon

4469a6e

Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>

Merge branch 'master' into fix/152460-java-compatibility-warning

41ff01f

andrewkolos approved these changes Aug 30, 2024

View reviewed changes

andrewkolos requested a review from christopherfujino September 10, 2024 19:28

christopherfujino approved these changes Sep 11, 2024

View reviewed changes

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 11, 2024

auto-submit bot merged commit 0a91488 into flutter:master Sep 11, 2024

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to 0a9148870ad9 (57 revisions) flutter/packages#7625

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

0a91488 Fix flutter create warning regarding Java compatibility (fl…

c43ef13

…utter/flutter#152836)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to d8de38f10d56 (59 revisions) flutter/packages#7627

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

0a91488 Fix flutter create warning regarding Java compatibility (fl…

49b38c7

…utter/flutter#152836)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to bcf1c5a24358 (60 revisions) flutter/packages#7628

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

0a91488 Fix flutter create warning regarding Java compatibility (fl…

e5a5bdd

…utter/flutter#152836)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to 6e46ee8d6d6f (63 revisions) flutter/packages#7629

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

0a91488 Fix flutter create warning regarding Java compatibility (fl…

05469c8

…utter/flutter#152836)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to 04e1b174ea6d (66 revisions) flutter/packages#7630

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

0a91488 Fix flutter create warning regarding Java compatibility (fl…

e6611bf

…utter/flutter#152836)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to 50a190caec0c (74 revisions) flutter/packages#7634

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

0a91488 Fix flutter create warning regarding Java compatibility (fl…

ddba2c6

…utter/flutter#152836)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to d8f8613a5b94 (75 revisions) flutter/packages#7635

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

0a91488 Fix flutter create warning regarding Java compatibility (fl…

6609d6f

…utter/flutter#152836)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to 90aa59f6c32f (76 revisions) flutter/packages#7637

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

0a91488 Fix flutter create warning regarding Java compatibility (fl…

9d5a71a

…utter/flutter#152836)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to 303f222e17e3 (77 revisions) flutter/packages#7638

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

0a91488 Fix flutter create warning regarding Java compatibility (fl…

3ca37d5

…utter/flutter#152836)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

0a91488 Fix flutter create warning regarding Java compatibility (fl…

99f4d83

…utter/flutter#152836)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

0a91488 Fix flutter create warning regarding Java compatibility (fl…

90eb67c

…utter/flutter#152836)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix `flutter create` warning regarding Java compatibility #152836

Fix `flutter create` warning regarding Java compatibility #152836

Uh oh!

shashwatpathak98 commented Aug 4, 2024 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Aug 4, 2024

Uh oh!

Hixie Aug 4, 2024

Uh oh!

shashwatpathak98 Aug 6, 2024

Uh oh!

Hixie commented Aug 7, 2024

Uh oh!

shashwatpathak98 commented Aug 8, 2024

Uh oh!

ishon19 commented Aug 15, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

andrewkolos left a comment •

edited

Loading

Uh oh!

ishon19 commented Aug 30, 2024

Uh oh!

christopherfujino left a comment

Uh oh!

shashwatpathak98 commented Sep 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Fix flutter create warning regarding Java compatibility #152836

Fix flutter create warning regarding Java compatibility #152836

Uh oh!

Conversation

shashwatpathak98 commented Aug 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Aug 4, 2024

Uh oh!

Hixie Aug 4, 2024

Choose a reason for hiding this comment

Uh oh!

shashwatpathak98 Aug 6, 2024

Choose a reason for hiding this comment

Uh oh!

Hixie commented Aug 7, 2024

Uh oh!

shashwatpathak98 commented Aug 8, 2024

Uh oh!

ishon19 commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andrewkolos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishon19 commented Aug 30, 2024

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

shashwatpathak98 commented Sep 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Fix `flutter create` warning regarding Java compatibility #152836

Fix `flutter create` warning regarding Java compatibility #152836

shashwatpathak98 commented Aug 4, 2024 •

edited

Loading

ishon19 commented Aug 15, 2024 •

edited

Loading

andrewkolos left a comment •

edited

Loading