Skip to content

Conversation

@matanlurey
Copy link
Contributor

Work around #152684, and probably indefinitely if we don't need it.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 1, 2024

auto label is removed for flutter/flutter/152696, due to - The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2024
@auto-submit auto-submit bot merged commit e11abea into flutter:master Aug 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 3, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 3, 2024
Manual roll requested by stuartmorgan@google.com

flutter/flutter@4ff9462...f10a497

2024-08-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Shift Linux_build_test tests from MotoG4 to mokey (#152750)" (flutter/flutter#152755)
2024-08-02 zanderso@users.noreply.github.com Shift Linux_build_test tests from MotoG4 to mokey (flutter/flutter#152750)
2024-08-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from b408111b976c to 077b6f057b69 (1 revision) (flutter/flutter#152745)
2024-08-02 32538273+ValentinVignal@users.noreply.github.com Add test for scaffold_state.show_bottom_sheet.0.dart (flutter/flutter#152731)
2024-08-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from fe39ed980e74 to b408111b976c (6 revisions) (flutter/flutter#152739)
2024-08-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from ab3f177fb61d to fe39ed980e74 (1 revision) (flutter/flutter#152721)
2024-08-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1cbe88e8115e to ab3f177fb61d (4 revisions) (flutter/flutter#152718)
2024-08-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 17e3c7d520e7 to 1cbe88e8115e (5 revisions) (flutter/flutter#152707)
2024-08-01 nate.w5687@gmail.com Use `.fromMap()` constructors in example code (flutter/flutter#152535)
2024-08-01 jhy03261997@gmail.com Add more widgets to a11y assessment app (flutter/flutter#152662)
2024-08-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 230879c7936e to 17e3c7d520e7 (1 revision) (flutter/flutter#152703)
2024-08-01 jmccandless@google.com Explain that predictive back doesn't work with WillPopScope (flutter/flutter#152116)
2024-08-01 jmccandless@google.com SearchBar.scrollPadding (flutter/flutter#152635)
2024-08-01 jmccandless@google.com Quick docs grammar fixes (flutter/flutter#152700)
2024-08-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from bbb2fcad4808 to 230879c7936e (1 revision) (flutter/flutter#152701)
2024-08-01 matanlurey@users.noreply.github.com Disable DDS and Dart profiling for Android driver tests. (flutter/flutter#152696)
2024-08-01 srawlins@google.com Remove one set of parens that wrap a single String literal (flutter/flutter#152031)
2024-08-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c4a44611abe to bbb2fcad4808 (3 revisions) (flutter/flutter#152694)
2024-08-01 bkonyi@google.com Fix bad pattern matching in DDS exception parsing (flutter/flutter#152685)
2024-08-01 engine-flutter-autoroll@skia.org Roll Packages from 46a712f to 27896d1 (7 revisions) (flutter/flutter#152693)
2024-08-01 dkwingsmt@users.noreply.github.com [CupertinoActionSheet & AlertDialog] Improve documentation and type for `scrollController` parameters (flutter/flutter#152647)
2024-08-01 38427679+xVemu@users.noreply.github.com Fix typo in CHANGELOG.md (flutter/flutter#152543)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
matanlurey referenced this pull request Aug 5, 2024
Due to #152684

This PR is just eagerly doing what the flake bot would do on Wednesday.

FYI @matanlurey @reidbaker
zanderso added a commit that referenced this pull request Aug 6, 2024
)

As in #152696, It's not clear
that DDS initialization is necessary for any of these tests.

In particular, from the comments on the tool flag:
```
            'It may be necessary to disable this when attaching to an application with '
            'an existing DDS instance (e.g., attaching to an application currently '
            'connected to by "flutter run"), or when running certain tests.\n'
            'Disabling this feature may degrade IDE functionality if a DDS instance is '
            'not already connected to the target application.'
```

These tests are unlikely to need IDE functionality. I have initially
modified the Linux_android_emu tests in the ci.yaml so that they run in
presubmit to verify that this change is safe. Many other postsubmit-only
tests that will now be passed `--no-dds` require physical devices, and
if there is an issue in post-submit, this change will need to be
reverted.
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
)

Work around flutter#152684, and probably indefinitely if we don't need it.
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…ter#152898)

As in flutter#152696, It's not clear
that DDS initialization is necessary for any of these tests.

In particular, from the comments on the tool flag:
```
            'It may be necessary to disable this when attaching to an application with '
            'an existing DDS instance (e.g., attaching to an application currently '
            'connected to by "flutter run"), or when running certain tests.\n'
            'Disabling this feature may degrade IDE functionality if a DDS instance is '
            'not already connected to the target application.'
```

These tests are unlikely to need IDE functionality. I have initially
modified the Linux_android_emu tests in the ci.yaml so that they run in
presubmit to verify that this change is safe. Many other postsubmit-only
tests that will now be passed `--no-dds` require physical devices, and
if there is an issue in post-submit, this change will need to be
reverted.
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
)

Work around flutter#152684, and probably indefinitely if we don't need it.
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…ter#152898)

As in flutter#152696, It's not clear
that DDS initialization is necessary for any of these tests.

In particular, from the comments on the tool flag:
```
            'It may be necessary to disable this when attaching to an application with '
            'an existing DDS instance (e.g., attaching to an application currently '
            'connected to by "flutter run"), or when running certain tests.\n'
            'Disabling this feature may degrade IDE functionality if a DDS instance is '
            'not already connected to the target application.'
```

These tests are unlikely to need IDE functionality. I have initially
modified the Linux_android_emu tests in the ci.yaml so that they run in
presubmit to verify that this change is safe. Many other postsubmit-only
tests that will now be passed `--no-dds` require physical devices, and
if there is an issue in post-submit, this change will need to be
reverted.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants