Cleanup InputDecoration.collapsed constructor #152165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@justinmc We can also consider exposing some parameters such as prefix, prefixText, suffix, suffixText and maybe prefixIcon and suffixIcon. It depends on how we define a collasped decoration. There are no specification for this and it can be seen in two different ways:
Choice 1 would implies that prefixes and suffixes are acceptable. |
justinmc
approved these changes
Jul 25, 2024
Contributor
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
I'm on board with you deprecating floatingLabelBehavior and floatingLabelAlignment in another PR too.
Comment on lines
+2617
to
+2618
| /// A collapsed decoration cannot have [labelText], [errorText], [counter], | ||
| /// [icon], prefixes, and suffixes. |
Contributor
There was a problem hiding this comment.
Thanks for making this clear 👍
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 28, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 29, 2024
Roll Flutter from 7d5c1c0 to 031dc3d (97 revisions) flutter/flutter@7d5c1c0...031dc3d 2024-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 342a42547822 to 354abf2800a0 (7 revisions) (flutter/flutter#152385) 2024-07-26 ryjohn@google.com Use more CORS headers for flutter run server (flutter/flutter#152249) 2024-07-26 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 8714b54a87c0 to 342a42547822 (6 revisions) (flutter/flutter#152379) 2024-07-26 34465683+rkishan516@users.noreply.github.com feat: Add drag handle size to be configurable based on given size (flutter/flutter#152085) 2024-07-26 matanlurey@users.noreply.github.com Add and use an integration test with native(ADB) screenshots (flutter/flutter#152326) 2024-07-26 engine-flutter-autoroll@skia.org Roll Packages from 19daf6f to 3d358d9 (4 revisions) (flutter/flutter#152372) 2024-07-26 32538273+ValentinVignal@users.noreply.github.com Add test for range_slider.0.dart (flutter/flutter#152152) 2024-07-26 tessertaha@gmail.com Introduce `TabBar.indicatorAnimation` to customize tab indicator animation (flutter/flutter#151746) 2024-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 21629ece8b72 to 8714b54a87c0 (3 revisions) (flutter/flutter#152351) 2024-07-26 kevmoo@users.noreply.github.com Cleanup examples/api web load logic to latest (flutter/flutter#152349) 2024-07-26 gspencergoog@users.noreply.github.com Adds a call to the `PlatformDispatcher` whenever the focus changes (flutter/flutter#151268) 2024-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from d665bf82dc32 to 21629ece8b72 (4 revisions) (flutter/flutter#152344) 2024-07-25 31859944+LongCatIsLooong@users.noreply.github.com `docImport`s for the widgets library (flutter/flutter#152339) 2024-07-25 jacksongardner@google.com Set dart defines properly while in debug mode. (flutter/flutter#152262) 2024-07-25 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.13 to 3.25.14 (flutter/flutter#152342) 2024-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 74785a771ae6 to d665bf82dc32 (2 revisions) (flutter/flutter#152340) 2024-07-25 leroux_bruno@yahoo.fr Cleanup InputDecoration.collapsed constructor (flutter/flutter#152165) 2024-07-25 32538273+ValentinVignal@users.noreply.github.com Add test for expansion_panel_list.expansion_panel_list_radio.0_test.dart (flutter/flutter#151730) 2024-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from f862a620cee4 to 74785a771ae6 (2 revisions) (flutter/flutter#152333) 2024-07-25 engine-flutter-autoroll@skia.org Roll Packages from 1c319ac to 19daf6f (3 revisions) (flutter/flutter#152327) 2024-07-25 31859944+LongCatIsLooong@users.noreply.github.com Add a more typical / concrete example to IntrinsicHeight / IntrinsicWidth (flutter/flutter#152246) 2024-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from f47b4d8e145a to f862a620cee4 (1 revision) (flutter/flutter#152320) 2024-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 74737820a8ee to f47b4d8e145a (7 revisions) (flutter/flutter#152314) 2024-07-25 42016383+DBowen33@users.noreply.github.com Flutter Web App: adds a11y semantic attributes to slider (flutter/flutter#151985) 2024-07-25 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from eb8fac2b1703 to 74737820a8ee (8 revisions) (flutter/flutter#152305) 2024-07-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from eb8fac2b1703 to a57655cccb55 (6 revisions) (#152293)" (flutter/flutter#152304) 2024-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb8fac2b1703 to a57655cccb55 (6 revisions) (flutter/flutter#152293) 2024-07-25 biggs0125@gmail.com Modify stepping integration test to accommodate new DDC async semantics. (flutter/flutter#152204) 2024-07-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from eb8fac2b1703 to e1259b86ba02 (2 revisions) (#152285)" (flutter/flutter#152289) 2024-07-25 biggs0125@gmail.com Update fake_codec.dart to use Future.value instead of SynchronousFuture (flutter/flutter#152182) 2024-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb8fac2b1703 to e1259b86ba02 (2 revisions) (flutter/flutter#152285) 2024-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4b952093cb99 to eb8fac2b1703 (3 revisions) (flutter/flutter#152278) 2024-07-24 dkwingsmt@users.noreply.github.com [CupertinoAlertDialog] Rewrite (flutter/flutter#150410) 2024-07-24 victorsanniay@gmail.com Revert "Make `CupertinoRadio`'s `mouseCursor` a `WidgetStateProperty`" (flutter/flutter#152254) 2024-07-24 rmolivares@renzo-olivares.dev Fix: A selectable's selection under the active selection should not be cleared on right-click (flutter/flutter#151851) 2024-07-24 fluttergithubbot@gmail.com Marks Mac channels_integration_test to be flaky (flutter/flutter#151882) 2024-07-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from c2f489d783d6 to 4b952093cb99 (3 revisions) (flutter/flutter#152264) 2024-07-24 42016383+DBowen33@users.noreply.github.com added Semantics label to TextField with InputDecoration to let user k� (flutter/flutter#151996) 2024-07-24 jasonkang14@gmail.com feat: Add alignmentOffset to DropdownMenu (flutter/flutter#151731) 2024-07-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 490576daf810 to c2f489d783d6 (6 revisions) (flutter/flutter#152260) 2024-07-24 matanlurey@users.noreply.github.com Scaffolding for `NativeDriver` and `AndroidNativeDriver` for taking screenshots using `adb`. (flutter/flutter#152194) 2024-07-24 31859944+LongCatIsLooong@users.noreply.github.com `widgets` docImport (flutter/flutter#152146) 2024-07-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3078f6a90e71 to 490576daf810 (1 revision) (flutter/flutter#152239) 2024-07-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use more CORS headers for `flutter run` server (#152048)" (flutter/flutter#152248) 2024-07-24 ryjohn@google.com Use more CORS headers for `flutter run` server (flutter/flutter#152048) 2024-07-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enable Swift Package Manager by default on master channel (#152049)" (flutter/flutter#152243) ...
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
## Description This PR is a follow up to #152165 (review). It deprecates two parameters that should not have been added (`floatingLabelBehavior` and `floatingLabelAlignment`) to `InputDecoration.collapsed`. Those parameters are related to the floating label but a collapsed input decoration is not supposed to have labels. For the dart_fix, I created a new fix file and moved some previous fixes to it. ## Tests Adds 1 test, updates 1.
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
## Description This PR attemps to clarify the `InputDecoration.collapsed` documentation by explaining that it is not meant to be use with helper, label, counter, icons, prefixes and suffixes. It also adds some parameters that make sense for a collapsed decoration (`hintMaxLines`, `hintFadeDuration`, `constraints`). Removing parameters that should not have been added (`floatingLabelBehavior` and `floatingLabelAlignment`) will be part of another PR as it will require deprecations. ## Related Issue Fixes flutter#61331 ## Tests Adds 3 tests.
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
## Description This PR is a follow up to flutter#152165 (review). It deprecates two parameters that should not have been added (`floatingLabelBehavior` and `floatingLabelAlignment`) to `InputDecoration.collapsed`. Those parameters are related to the floating label but a collapsed input decoration is not supposed to have labels. For the dart_fix, I created a new fix file and moved some previous fixes to it. ## Tests Adds 1 test, updates 1.
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
## Description This PR attemps to clarify the `InputDecoration.collapsed` documentation by explaining that it is not meant to be use with helper, label, counter, icons, prefixes and suffixes. It also adds some parameters that make sense for a collapsed decoration (`hintMaxLines`, `hintFadeDuration`, `constraints`). Removing parameters that should not have been added (`floatingLabelBehavior` and `floatingLabelAlignment`) will be part of another PR as it will require deprecations. ## Related Issue Fixes flutter#61331 ## Tests Adds 3 tests.
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
## Description This PR is a follow up to flutter#152165 (review). It deprecates two parameters that should not have been added (`floatingLabelBehavior` and `floatingLabelAlignment`) to `InputDecoration.collapsed`. Those parameters are related to the floating label but a collapsed input decoration is not supposed to have labels. For the dart_fix, I created a new fix file and moved some previous fixes to it. ## Tests Adds 1 test, updates 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attemps to clarify the
InputDecoration.collapseddocumentation by explaining that it is not meant to be use with helper, label, counter, icons, prefixes and suffixes.It also adds some parameters that make sense for a collapsed decoration (
hintMaxLines,hintFadeDuration,constraints).Removing parameters that should not have been added (
floatingLabelBehaviorandfloatingLabelAlignment) will be part of another PR as it will require deprecations.Related Issue
Fixes #61331
Tests
Adds 3 tests.