Make the App's title optional on web #152003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
reviewed
Jul 19, 2024
reidbaker
approved these changes
Jul 24, 2024
Contributor
Author
|
@yjbanov @Piinks do you happen to know why not instantiating the |
Contributor
I do not, maybe @chunhtai has some context? |
chunhtai
reviewed
Jul 31, 2024
Contributor
|
auto label is removed for flutter/flutter/152003, due to - The status or check suite Linux_android_emu android_defines_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
auto label is removed for flutter/flutter/152003, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
auto label is removed for flutter/flutter/152003, due to - The status or check suite Linux web_skwasm_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 4, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 4, 2024
Manual roll requested by stuartmorgan@google.com flutter/flutter@f10a497...cbfb222 2024-08-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 980577996f38 to 16012e2f8ccd (1 revision) (flutter/flutter#152824) 2024-08-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2a51c687fd40 to 980577996f38 (1 revision) (flutter/flutter#152821) 2024-08-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4c868ee85616 to 2a51c687fd40 (2 revisions) (flutter/flutter#152818) 2024-08-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from afb7007298cc to 4c868ee85616 (2 revisions) (flutter/flutter#152814) 2024-08-03 zanderso@users.noreply.github.com Fix device_os requested in linux_build_test tests (flutter/flutter#152808) 2024-08-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 516235e4456b to afb7007298cc (3 revisions) (flutter/flutter#152804) 2024-08-03 zanderso@users.noreply.github.com Fix misunderstanding of properties vs. drone_dimensions in Linux_build_tests (flutter/flutter#152796) 2024-08-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3c9d7e3f7c02 to 516235e4456b (3 revisions) (flutter/flutter#152790) 2024-08-03 victorsanniay@gmail.com Improve `CupertinoRadio` fidelity (flutter/flutter#149703) 2024-08-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 353c6b237b78 to 3c9d7e3f7c02 (3 revisions) (flutter/flutter#152777) 2024-08-02 gspencergoog@users.noreply.github.com Fix handling of `iconSize` and `iconColor` defaults for `ButtonStyleButton` subclasses. (flutter/flutter#143501) 2024-08-02 matanlurey@users.noreply.github.com Use print logging on LUCI. (flutter/flutter#152776) 2024-08-02 zanderso@users.noreply.github.com Reland: Shift Linux_build_test tests from MotoG4 to mokey (flutter/flutter#152756) 2024-08-02 greg@zulip.com Write more on Animation and related docs (flutter/flutter#150727) 2024-08-02 pateltirth454@gmail.com Quick Grammar Fixes (flutter/flutter#152744) 2024-08-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 077b6f057b69 to 353c6b237b78 (3 revisions) (flutter/flutter#152762) 2024-08-02 anuragr9847@gmail.com [SliderTheme] Fix markdown links for api doc images (flutter/flutter#152748) 2024-08-02 tugorez@users.noreply.github.com Make the App's title optional on web (flutter/flutter#152003) 2024-08-02 32538273+ValentinVignal@users.noreply.github.com Add tests for scaffold messenger state (flutter/flutter#152735) 2024-08-02 srawlins@google.com Ignore both unused_element and unused_element_parameter (flutter/flutter#152689) 2024-08-02 parlough@gmail.com Update dartdoc to 8.0.12 to fix focusing search field (flutter/flutter#151576) 2024-08-02 rexios@rexios.dev [wiki] Remove outdated warning about stale coverage data (flutter/flutter#152560) 2024-08-02 engine-flutter-autoroll@skia.org Roll Packages from 27896d1 to cc9ff47 (8 revisions) (flutter/flutter#152754) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
Title (in web) results in updating the [title element][1] which is a global property. This is problematic in embedded and multiview modes as title should be managed by host apps. This PR makes the title optional, hence if not provided it won't result in the website title being updated.
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
Title (in web) results in updating the [title element][1] which is a global property. This is problematic in embedded and multiview modes as title should be managed by host apps. This PR makes the title optional, hence if not provided it won't result in the website title being updated.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title (in web) results in updating the title element which is a global property. This is problematic in embedded and multiview modes as title should be managed by host apps. This PR makes the title optional, hence if not provided it won't result in the website title being updated.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.