Fix: BaseTapAndDragGestureRecognizer should reset drag state after losing gesture arena #151989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 19, 2024
…after losing gesture arena (flutter/flutter#151989)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 19, 2024
…after losing gesture arena (flutter/flutter#151989)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 19, 2024
…after losing gesture arena (flutter/flutter#151989)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 19, 2024
…after losing gesture arena (flutter/flutter#151989)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 19, 2024
…after losing gesture arena (flutter/flutter#151989)
LouiseHsu
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 20, 2024
Roll Flutter from 58068d8 to 7d5c1c0 (104 revisions) flutter/flutter@58068d8...7d5c1c0 2024-07-19 104349824+huycozy@users.noreply.github.com Enhances intuitiveness of RawMagnifier's example (flutter/flutter#150308) 2024-07-19 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#151992) 2024-07-19 32538273+ValentinVignal@users.noreply.github.com Add test for scrollbar.1.dart (flutter/flutter#151463) 2024-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from ea1e53a4e810 to 969fb7abc449 (3 revisions) (flutter/flutter#152018) 2024-07-19 goderbauer@google.com docimports for rendering library (flutter/flutter#151958) 2024-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from b65c93ea948e to ea1e53a4e810 (2 revisions) (flutter/flutter#152012) 2024-07-19 kevmoo@users.noreply.github.com painting: drop deprecated (exported) hashList and hashValues functions (flutter/flutter#151677) 2024-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 766f7bed7185 to b65c93ea948e (2 revisions) (flutter/flutter#152004) 2024-07-18 magder@google.com Update TESTOWNERS (flutter/flutter#151907) 2024-07-18 n7484443@naver.com chore: fix test name & add description of tests (flutter/flutter#151959) 2024-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 564ded4c4742 to 766f7bed7185 (2 revisions) (flutter/flutter#151998) 2024-07-18 rmolivares@renzo-olivares.dev Fix SelectionArea scrolling conflicts (flutter/flutter#151138) 2024-07-18 rmolivares@renzo-olivares.dev Fix: BaseTapAndDragGestureRecognizer should reset drag state after losing gesture arena (flutter/flutter#151989) 2024-07-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#151975) 2024-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8bcf638eb893 to 564ded4c4742 (2 revisions) (flutter/flutter#151986) 2024-07-18 88094492+croro613@users.noreply.github.com Fix WidgetStateTextStyle's doc (flutter/flutter#151935) 2024-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d58ba74250ce to 8bcf638eb893 (2 revisions) (flutter/flutter#151977) 2024-07-18 kevinjchisholm@google.com Adds 3.22.3 changelog (flutter/flutter#151974) 2024-07-18 engine-flutter-autoroll@skia.org Roll Packages from d03b1b4 to c7f0526 (8 revisions) (flutter/flutter#151971) 2024-07-18 nate.w5687@gmail.com `WidgetState` mapping (flutter/flutter#146043) 2024-07-18 greg@zulip.com Fix AppBar doc to keep diagram next to its description (flutter/flutter#151937) 2024-07-18 greg@zulip.com Small fixes to Image docs: NNBD, and add a cross-reference (flutter/flutter#151938) 2024-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b043fe447bb3 to d58ba74250ce (1 revision) (flutter/flutter#151964) 2024-07-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#151946) 2024-07-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#151904) 2024-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from e3abca2d8105 to b043fe447bb3 (1 revision) (flutter/flutter#151942) 2024-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8073523b4623 to e3abca2d8105 (1 revision) (flutter/flutter#151936) 2024-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from dfe22e3acc19 to 8073523b4623 (1 revision) (flutter/flutter#151934) 2024-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 184c3f0de6b3 to dfe22e3acc19 (1 revision) (flutter/flutter#151930) 2024-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00f0f6b74da7 to 184c3f0de6b3 (1 revision) (flutter/flutter#151928) 2024-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d194a2f0e5da to 00f0f6b74da7 (1 revision) (flutter/flutter#151927) 2024-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from a5a93bb80bd1 to d194a2f0e5da (3 revisions) (flutter/flutter#151925) 2024-07-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from e9dc62074c2b to a5a93bb80bd1 (1 revision) (flutter/flutter#151918) 2024-07-17 yjbanov@google.com [web] use the new backlog Github project in triage links (flutter/flutter#151920) 2024-07-17 yjbanov@google.com Update Flutter-Web-Triage.md (flutter/flutter#151607) 2024-07-17 leroux_bruno@yahoo.fr Reland fix InputDecorator hint default text style on M3 (flutter/flutter#150835) 2024-07-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39ee1a549581 to e9dc62074c2b (3 revisions) (flutter/flutter#151915) 2024-07-17 victorsanniay@gmail.com Constrain `CupertinoContextMenu` animation to safe area (flutter/flutter#151860) 2024-07-17 36861262+QuncCccccc@users.noreply.github.com Create `CarouselView` widget - Part 2 (flutter/flutter#149775) 2024-07-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 45b722b661f0 to 39ee1a549581 (3 revisions) (flutter/flutter#151905) 2024-07-17 34465683+rkishan516@users.noreply.github.com docs: Fix typo in data driven fixes test folder section (flutter/flutter#151836) 2024-07-17 zanderso@users.noreply.github.com Stop running flaky mac tests in presubmit (flutter/flutter#151870) 2024-07-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7e2579634027 to 45b722b661f0 (1 revision) (flutter/flutter#151895) 2024-07-17 44146839+essjay05@users.noreply.github.com fix(Flutter Web App): fixes html lang typo (flutter/flutter#151866) 2024-07-17 matanlurey@users.noreply.github.com Delete `docs/engine` directory (flutter/flutter#151616) 2024-07-17 31859944+LongCatIsLooong@users.noreply.github.com Make `CupertinoSlidingSegmentedControl` type parameter non-null (flutter/flutter#151803) ...
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…sing gesture arena (flutter#151989) This PR properly resets the drag state when losing the gesture arena or when the recognizer stops tracking the current pointer. The _dragState enum was reset properly, but I had forgotten to also reset the `_start`, this caused an issue when the recognizer won the gesture arena the next time, as it tries to detect a drag given the old `_start` in `acceptGesture`, but the `_dragState` has been reset causing an assertion to trigger.
Renzo-Olivares
added a commit
to Renzo-Olivares/flutter
that referenced
this pull request
Aug 22, 2024
…sing gesture arena (flutter#151989) This PR properly resets the drag state when losing the gesture arena or when the recognizer stops tracking the current pointer. The _dragState enum was reset properly, but I had forgotten to also reset the `_start`, this caused an issue when the recognizer won the gesture arena the next time, as it tries to detect a drag given the old `_start` in `acceptGesture`, but the `_dragState` has been reset causing an assertion to trigger.
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
…te after losing gesture arena (#151989) (#153935) Fixes an issue where Flutter TextField may crash on iOS after a horizontal drag that does not meet the drag threshold to win the gesture arena, leaving the TextField in a weird state that does not accept tap gestures. Fixes #153939 Cherry-pick of: #151989 Related issue: #153458
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…sing gesture arena (flutter#151989) This PR properly resets the drag state when losing the gesture arena or when the recognizer stops tracking the current pointer. The _dragState enum was reset properly, but I had forgotten to also reset the `_start`, this caused an issue when the recognizer won the gesture arena the next time, as it tries to detect a drag given the old `_start` in `acceptGesture`, but the `_dragState` has been reset causing an assertion to trigger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR properly resets the drag state when losing the gesture arena or when the recognizer stops tracking the current pointer. The _dragState enum was reset properly, but I had forgotten to also reset the
_start, this caused an issue when the recognizer won the gesture arena the next time, as it tries to detect a drag given the old_startinacceptGesture, but the_dragStatehas been reset causing an assertion to trigger.Pre-launch Checklist
///).