Skip to content

Conversation

@nate-thegrate
Copy link
Contributor

@nate-thegrate nate-thegrate commented Jul 5, 2024

This PR resolves some problems I was having with DataTable, based on advice from the style guide:

Answer your own questions straight away

If you find yourself asking a question about our systems, please place whatever answer you subsequently discover into the documentation in the same place where you first looked for the answer. That way, the documentation will consist of answers to real questions, where people would look to find them.

The DataTable documentation now specifies that the widget is based on the Material 2 spec, and it offers a list of useful alternatives.


Additionally, an item in the "See also" section was updated to use a reliable Go link:

- ///  * <https://material.io/design/components/data-tables.html>
+ ///  * <https://material.io/go/design-data-tables>

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 5, 2024
@nate-thegrate nate-thegrate marked this pull request as ready for review July 5, 2024 22:06
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nate-thegrate nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 8, 2024
@auto-submit auto-submit bot merged commit a3c7094 into flutter:master Jul 8, 2024
@nate-thegrate nate-thegrate deleted the datatable-docs branch July 8, 2024 22:09
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jul 8, 2024
This PR resolves [some problems I was having with `DataTable`](flutter#151005), based on advice from the style guide:

> ### Answer your own questions straight away
> If you find yourself asking a question about our systems, please place whatever answer you subsequently discover into the documentation in the same place where you first looked for the answer. That way, the documentation will consist of answers to real questions, where people would look to find them.

The `DataTable` documentation now specifies that the widget is based on the Material 2 spec, and it offers a list of useful alternatives.

<br>

Additionally, an item in the "See also" section was updated to use a reliable Go link:

```diff
- ///  * <https://material.io/design/components/data-tables.html>
+ ///  * <https://material.io/go/design-data-tables>
```
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 9, 2024
flutter/flutter@fafd67d...5103d75

2024-07-09 andrewrkolos@gmail.com [tool] Remove some usages of deprecated usage package (flutter/flutter#151359)
2024-07-09 43759233+kenzieschmoll@users.noreply.github.com Write the package config location to the test bootstrap. (flutter/flutter#150440)
2024-07-09 dacoharkes@google.com [deps] Roll dart-lang/native packages (flutter/flutter#151403)
2024-07-08 andrewrkolos@gmail.com [tool] make `testUsingContext` provide a `Stdio` (with `hasTerminal` unset) override by default (flutter/flutter#151357)
2024-07-08 120297255+PurplePolyhedron@users.noreply.github.com Make `FittedBox` not throw when child has zero size. (flutter/flutter#150430)
2024-07-08 nate.w5687@gmail.com Update `DataTable` documentation (flutter/flutter#151356)
2024-07-08 nate.w5687@gmail.com `MaterialState` � `WidgetState` in documentation (flutter/flutter#151376)
2024-07-08 41930132+hellohuanlin@users.noreply.github.com [ios]A typical news app benchmark with bottom ad banner (flutter/flutter#150991)
2024-07-08 gspencergoog@users.noreply.github.com Re-enable `SemanticsAction.focus` matchers (flutter/flutter#150990)
2024-07-08 hans.muller@gmail.com Added SliverFloatingHeader.snapMode (flutter/flutter#151289)
2024-07-08 nate.w5687@gmail.com Factor out deprecated names in example code (flutter/flutter#151374)
2024-07-08 cedvandenbosch@gmail.com Add cedric vanden bosch to authors (flutter/flutter#151313)
2024-07-08 engine-flutter-autoroll@skia.org Roll Packages from 97bad7e to 14341d1 (5 revisions) (flutter/flutter#151417)
2024-07-08 srawlins@google.com Update doc-import to primary configured import, _goldens_io.dart (flutter/flutter#151390)
2024-07-08 tessertaha@gmail.com [Reland] - Enable `explicitChildNodes` for the `AlertDialog` content (flutter/flutter#149597)
2024-07-08 32538273+ValentinVignal@users.noreply.github.com Add tests for material_state_border_side.0_test.dart (flutter/flutter#151089)
2024-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from ca79a56a66d7 to 69075e7e87d4 (1 revision) (flutter/flutter#151393)
2024-07-08 32538273+ValentinVignal@users.noreply.github.com Add tests for action_listener.0.dart (flutter/flutter#150606)
2024-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5ca3b856ee5a to ca79a56a66d7 (1 revision) (flutter/flutter#151387)
2024-07-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3600ec613a00 to 5ca3b856ee5a (1 revision) (flutter/flutter#151378)
2024-07-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from d1ebc5fde630 to 3600ec613a00 (1 revision) (flutter/flutter#151377)
2024-07-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from e6b09697df1a to d1ebc5fde630 (1 revision) (flutter/flutter#151362)
2024-07-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.3 to 4.3.4 (flutter/flutter#151354)
2024-07-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ee09d3b7f3b to e6b09697df1a (2 revisions) (flutter/flutter#151352)
2024-07-05 sokolovskyi.konstantin@gmail.com Add tests for color_filtered.0.dart example. (flutter/flutter#151064)
2024-07-05 christopherfujino@gmail.com de-duplicate code in analyze.dart (flutter/flutter#151279)
2024-07-05 engine-flutter-autoroll@skia.org Roll Packages from 754de19 to 97bad7e (1 revision) (flutter/flutter#151350)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frustrations with DataTable

2 participants