-
Notifications
You must be signed in to change notification settings - Fork 29.8k
[native_assets] Fix macOS host build failure when there are no frameworks to sign. #150742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 2 commits into
flutter:master
from
bdero:bdero/fix-native-assets-empty
Jul 23, 2024
Merged
[native_assets] Fix macOS host build failure when there are no frameworks to sign. #150742
auto-submit
merged 2 commits into
flutter:master
from
bdero:bdero/fix-native-assets-empty
Jul 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0d226c to
c4233e7
Compare
c4233e7 to
a6d755f
Compare
dcharkes
approved these changes
Jul 23, 2024
Contributor
dcharkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @bdero! 🙏
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 23, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 23, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 23, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 24, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 24, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 24, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 24, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 24, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 25, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 25, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 25, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 25, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 25, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 26, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 26, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 26, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 26, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 28, 2024
…o frameworks to sign. (flutter/flutter#150742)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 28, 2024
…o frameworks to sign. (flutter/flutter#150742)
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…orks to sign. (flutter#150742) When the `"${native_assets_path}"*.framework` glob doesn't resolve anything, the bash will run the loop once with the original unglobbed value: `/path/to/native/assets/*.framework`. Skip this case to prevent the build from failing when there are no frameworks to sign. To reproduce this build failure: 1. Enable native assets in the Flutter tool: `flutter config --enable-native-assets` 2. Create a Flutter project with the default template: `flutter create test_native_assets` 3. Add a build hook that does nothing (`hook/build.dart`). 4. Try to build/run the app: `flutter run --debug -d macos`
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Aug 22, 2024
…orks to sign. (flutter#150742) When the `"${native_assets_path}"*.framework` glob doesn't resolve anything, the bash will run the loop once with the original unglobbed value: `/path/to/native/assets/*.framework`. Skip this case to prevent the build from failing when there are no frameworks to sign. To reproduce this build failure: 1. Enable native assets in the Flutter tool: `flutter config --enable-native-assets` 2. Create a Flutter project with the default template: `flutter create test_native_assets` 3. Add a build hook that does nothing (`hook/build.dart`). 4. Try to build/run the app: `flutter run --debug -d macos`
Member
|
Heads up, @bdero I think you wanted the I added it, PR is here: #153967 |
5 tasks
Member
Author
|
Whoopsies, thanks. |
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
…e no frameworks to sign. (#153967) ### Issue Link: #153842 (also duplicate #153268) ### Changelog Description: Fixes macOS host build failure when there are no native asset frameworks to codesign ### Impact Description: macOS apps may fail to build with the error: `*.framework: No such file or directory`. ### Workaround: 1. Use the the master or beta (3.25.0-0.1.pre) channels. 2. Some users report `flutter clean` temporarily unwedged them. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: From PR #150742 To reproduce this build failure: 1. Enable native assets in the Flutter tool: `flutter config --enable-native-assets` 2. Create a Flutter project with the default template: `flutter create test_native_assets` 3. Add a build hook that does nothing (`hook/build.dart`). 4. Try to build/run the app: `flutter run --debug -d macos` Expect the build to succeed.
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…orks to sign. (flutter#150742) When the `"${native_assets_path}"*.framework` glob doesn't resolve anything, the bash will run the loop once with the original unglobbed value: `/path/to/native/assets/*.framework`. Skip this case to prevent the build from failing when there are no frameworks to sign. To reproduce this build failure: 1. Enable native assets in the Flutter tool: `flutter config --enable-native-assets` 2. Create a Flutter project with the default template: `flutter create test_native_assets` 3. Add a build hook that does nothing (`hook/build.dart`). 4. Try to build/run the app: `flutter run --debug -d macos`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
cp: stable
cherry pick this pull request to stable release candidate branch
tool
Affects the "flutter" command-line tool. See also t: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
"${native_assets_path}"*.frameworkglob doesn't resolve anything, bash will run the loop once with the original unglobbed value:/path/to/native/assets/*.framework. Skip this case to prevent the build from failing when there are no frameworks to sign.To reproduce this build failure:
flutter config --enable-native-assetsflutter create test_native_assetshook/build.dart).flutter run --debug -d macos