Skip to content

Fix transparent dividerColor breaks TabBar.tabAlignment #150350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jun 18, 2024
Merged

Fix transparent dividerColor breaks TabBar.tabAlignment #150350

auto-submit merged 1 commit into from
Jun 18, 2024

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Jun 17, 2024 •
edited
Loading

fixes TabBar.tabAlignment property does't work when dividerColor is transparent

Code sample

expand to view the code sample 
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: DefaultTabController(
        length: 2,
        child: Scaffold(
          appBar: AppBar(
            title: const Text('TabBar'),
            bottom: const TabBar(
              dividerColor: Colors.transparent,
              tabAlignment: TabAlignment.start,
              isScrollable: true,
              tabs: <Widget>[
                Tab(text: 'TAB 1'),
                Tab(text: 'TAB 2'),
              ],
            ),
          ),
          body: const TabBarView(
            children: <Widget>[
              SizedBox.expand(),
              SizedBox.expand(),
            ],
          ),
          floatingActionButton: FloatingActionButton(
            onPressed: () {},
            child: const Icon(Icons.add),
          ),
        ),
      ),
    );
  }
}

Before (dividerColor: Colors.transparent, tabAlignment: TabAlignment.start)

Screenshot 2024-06-17 at 15 44 33

After (dividerColor: Colors.transparent, tabAlignment: TabAlignment.start)

Screenshot 2024-06-17 at 15 44 55

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jun 17, 2024
@TahaTesser TahaTesser changed the title Fix transparent dividerColor breaks TabBar. tabAlignment Fix transparent dividerColor breaks TabBar.tabAlignment Jun 17, 2024
@TahaTesser TahaTesser marked this pull request as ready for review June 17, 2024 13:09
@TahaTesser TahaTesser requested a review from Piinks June 17, 2024 13:09
justinmc
justinmc approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question about a comment you added.

packages/flutter/lib/src/material/tabs.dart Outdated
final Color dividerColor = widget.dividerColor ?? tabBarTheme.dividerColor ?? _defaults.dividerColor!;
final double dividerHeight = widget.dividerHeight ?? tabBarTheme.dividerHeight ?? _defaults.dividerHeight!;
final bool showDivider = dividerColor != Colors.transparent && dividerHeight > 0;
final bool showDivider = dividerHeight > 0;
Copy link
Contributor

@justinmc justinmc Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the first comment you added above is not true, right? The divider will still be drawn even when it is transparent.

Copy link
Member Author

@TahaTesser TahaTesser Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch! You're right, this needs to be separate conditions. I just updated, the divider isn't drawn now when divider color is transparent.

@TahaTesser
Copy link
Member Author

TahaTesser commented Jun 18, 2024

Resolved test class conflict from another of my TabBar PR #150041

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2024
@auto-submit auto-submit bot merged commit 3359900 into flutter:master Jun 18, 2024
@TahaTesser TahaTesser deleted the scrollabe_tab_bar_transparent_divider branch June 18, 2024 12:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2024
@engine-flutter-autoroll
3359900 Fix transparent dividerColor breaks TabBar.tabAlignment (f…
de5d529 
…lutter/flutter#150350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2024
@engine-flutter-autoroll
3359900 Fix transparent dividerColor breaks TabBar.tabAlignment (f…
f9f430b 
…lutter/flutter#150350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2024
@engine-flutter-autoroll
3359900 Fix transparent dividerColor breaks TabBar.tabAlignment (f…
21521c5 
…lutter/flutter#150350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2024
@engine-flutter-autoroll
3359900 Fix transparent dividerColor breaks TabBar.tabAlignment (f…
ad7a7a6 
…lutter/flutter#150350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2024
@engine-flutter-autoroll
3359900 Fix transparent dividerColor breaks TabBar.tabAlignment (f…
3be202a 
…lutter/flutter#150350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2024
@engine-flutter-autoroll
3359900 Fix transparent dividerColor breaks TabBar.tabAlignment (f…
1c3f444 
…lutter/flutter#150350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 20, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2024
@engine-flutter-autoroll
3359900 Fix transparent dividerColor breaks TabBar.tabAlignment (f…
0bf443c 
…lutter/flutter#150350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 20, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2024
@engine-flutter-autoroll
3359900 Fix transparent dividerColor breaks TabBar.tabAlignment (f…
61db457 
…lutter/flutter#150350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 20, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2024
@engine-flutter-autoroll
3359900 Fix transparent dividerColor breaks TabBar.tabAlignment (f…
11c8ae5 
…lutter/flutter#150350)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 20, 2024
@engine-flutter-autoroll
Manual roll Flutter from ccf3abe to 6c06abb (21 revisions) (#6954)
a958207 
Manual roll requested by stuartmorgan@google.com

flutter/flutter@ccf3abe...6c06abb

2024-06-18 magder@google.com Add test for engine artifact framework permissions (flutter/flutter#148786)
2024-06-18 32538273+ValentinVignal@users.noreply.github.com Add test for icon_button.3.dart (flutter/flutter#149988)
2024-06-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78fdd06af541 to 74f42ca3544c (6 revisions) (flutter/flutter#150421)
2024-06-18 tessertaha@gmail.com Fix transparent `dividerColor` breaks `TabBar.tabAlignment` (flutter/flutter#150350)
2024-06-18 tessertaha@gmail.com Fix scrollable `TabBar` jittering (flutter/flutter#150041)
2024-06-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland 3: [CupertinoActionSheet] Match colors to native (#150386)" (flutter/flutter#150413)
2024-06-18 jason-simmons@users.noreply.github.com Extend the Windows web_tool_tests_1_2 shard timeout to 45 minutes (flutter/flutter#150393)
2024-06-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c4e5e230ecb to 78fdd06af541 (3 revisions) (flutter/flutter#150403)
2024-06-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from a4f266f7eb1a to 1c4e5e230ecb (8 revisions) (flutter/flutter#150399)
2024-06-18 parlough@gmail.com Rename doc file to use standard hyphens (flutter/flutter#150314)
2024-06-17 120297255+PurplePolyhedron@users.noreply.github.com Fix typo in `SliverLayoutDimensions.hashCode` where not all properties are used in the hash code. (flutter/flutter#150306)
2024-06-17 srawlins@google.com Fix doc comment references to 'this' (flutter/flutter#150379)
2024-06-17 Lexycon@users.noreply.github.com Add 'fail-fast' argument to flutter test (flutter/flutter#149587)
2024-06-17 dev@alestiago.com Update matchesGoldenFile documentation reference to goldenFileComparator (flutter/flutter#150343)
2024-06-17 dkwingsmt@users.noreply.github.com Reland 3: [CupertinoActionSheet] Match colors to native (flutter/flutter#150386)
2024-06-17 jhy03261997@gmail.com [a11y] Add semantics: button to bottom navigation bar items and dropdown menu items (flutter/flutter#149375)
2024-06-17 yinxulolol@gmail.com Reland "sliverGridDelegate mainAxisExtent add assert (#148470)"  (flutter/flutter#149720)
2024-06-17 36861262+QuncCccccc@users.noreply.github.com `ScaffoldBackgroundColor` should default to `ColorScheme.surface` (flutter/flutter#149772)
2024-06-17 katelovett@google.com Reland TreeSliver  (flutter/flutter#149839)
2024-06-17 dkwingsmt@users.noreply.github.com Reland: [CupertinoActionSheet] Add sliding tap gesture (flutter/flutter#150219)
2024-06-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5989f0215fed to a4f266f7eb1a (1 revision) (flutter/flutter#150377)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
3359900 Fix transparent dividerColor breaks TabBar.tabAlignment (f…
9b82d95 
…lutter/flutter#150350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@Piinks Piinks Awaiting requested review from Piinks

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TabBar.tabAlignment property does't work when dividerColor is transparent

2 participants

@TahaTesser @justinmc