Fix copy-paste-o in MethodChannel.invokeListMethod doc #149976
Conversation
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is a pure docs change, so it can't actually affect goldens — the diff must be due to some unrelated source of variation. It looks like the golden diffs are a single-pixel change in each of two tests: I think I don't have permissions to mark those results as positive, though. |
|
I am going to rebase this to trigger the checks again because I think that golden issue has been resolved at HEAD. |
This sentence didn't make a lot of sense as written. It looks like it was probably based on the doc of invokeMapMethod, and then incompletely adapted. So, fix it.
b616a56 to
24655d6
Compare
flutter/flutter@32081aa...14df7be 2024-06-11 109111084+yaakovschectman@users.noreply.github.com Revert "Add tests for scaffold drawer and end drawer" (flutter/flutter#150045) 2024-06-11 32538273+ValentinVignal@users.noreply.github.com Add tests for scaffold drawer and end drawer (flutter/flutter#149383) 2024-06-11 36861262+QuncCccccc@users.noreply.github.com Add high-contrast theme (flutter/flutter#149779) 2024-06-11 goderbauer@google.com Manual Pub Roll (flutter/flutter#150025) 2024-06-10 chris@bracken.jp [docs] Per-platform desktop triage instructions (flutter/flutter#150019) 2024-06-10 greg@zulip.com Fix copy-paste-o in MethodChannel.invokeListMethod doc (flutter/flutter#149976) 2024-06-10 34871572+gmackall@users.noreply.github.com Unpin `camera_android` and remove its only usage (flutter/flutter#150017) 2024-06-10 47866232+chunhtai@users.noreply.github.com Fixes a bug where NavigatorState.pop does not consider any possible s� (flutter/flutter#150014) 2024-06-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland: [CupertinoActionSheet] Match colors to native (#149568) (#150015)" (flutter/flutter#150021) 2024-06-10 dkwingsmt@users.noreply.github.com Reland: [CupertinoActionSheet] Match colors to native (#149568) (flutter/flutter#150015) 2024-06-10 15619084+vashworth@users.noreply.github.com Temporarily run Mac_arm64 framework_tests_misc on only Mac-13 (flutter/flutter#150009) 2024-06-10 47866232+chunhtai@users.noreply.github.com Fixes TextField hinttext in a11y_assessment (flutter/flutter#150007) 2024-06-10 kustermann@google.com Use const bool.fromEnvironment("dart.tool.dart2wasm") to detect dart2wasm (flutter/flutter#149996) 2024-06-10 engine-flutter-autoroll@skia.org Roll Packages from 8a2c4e4 to e95fe4a (3 revisions) (flutter/flutter#149997) 2024-06-10 ditman@gmail.com [web] Notify engine of handled PointerScrollEvents. (flutter/flutter#145500) 2024-06-10 greg@zulip.com Cut no-longer-accurate microtask reference in finalizeTree doc (flutter/flutter#149941) 2024-06-10 ttorii20@gmail.com Update hasTrailingSpaces (flutter/flutter#149698) 2024-06-10 mdebbar@google.com [web] Change `--web-renderer` default from `auto` to `canvaskit` (flutter/flutter#149773) 2024-06-10 jason-simmons@users.noreply.github.com Retain the toString method for subclasses of Key in profile/release mode (flutter/flutter#149926) 2024-06-10 mit@google.com Remove package:platform from issue template (flutter/flutter#149995) 2024-06-10 15619084+vashworth@users.noreply.github.com Revert "[CupertinoActionSheet] Match colors to native (#149568)" (flutter/flutter#149998) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This sentence didn't make a lot of sense as written. It looks like
it was probably based on the doc of invokeMapMethod, and then
incompletely adapted. So, fix it.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.