Remove abi key from local golden file testing #149696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
auto label is removed for flutter/flutter/149696, due to - The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 6, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 6, 2024
flutter/flutter@27e0656...4608a89 2024-06-06 leroux_bruno@yahoo.fr Fix InputDecorator suffixIcon color when in error and hovered (flutter/flutter#149643) 2024-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 32c3b9b7cbe1 to 92d0cd9370f7 (1 revision) (flutter/flutter#149789) 2024-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0edca2e9d3d2 to 32c3b9b7cbe1 (2 revisions) (flutter/flutter#149786) 2024-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from f51e0ad3abbe to 0edca2e9d3d2 (8 revisions) (flutter/flutter#149785) 2024-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from f37733035060 to f51e0ad3abbe (3 revisions) (flutter/flutter#149778) 2024-06-05 katelovett@google.com Remove abi key from local golden file testing (flutter/flutter#149696) 2024-06-05 47866232+chunhtai@users.noreply.github.com Fixes Router transaction to respect operation order (flutter/flutter#149763) 2024-06-05 yjbanov@google.com Send q once (flutter/flutter#149767) 2024-06-05 fluttergithubbot@gmail.com Marks Mac_ios rrect_blur_perf_ios__timeline_summary to be unflaky (flutter/flutter#149729) 2024-06-05 36861262+QuncCccccc@users.noreply.github.com Add `contrastLevel` parameter to `ColorScheme.fromSeed` (flutter/flutter#149705) 2024-06-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11a32d43e3f6 to f37733035060 (11 revisions) (flutter/flutter#149770) 2024-06-05 matanlurey@users.noreply.github.com Remove unused code from an older test artifact. (flutter/flutter#149746) 2024-06-05 36861262+QuncCccccc@users.noreply.github.com Create CarouselView widget - Part 1 (flutter/flutter#148094) 2024-06-05 andrewrkolos@gmail.com [flutter_tools] Remove additional listener on VM service that simply logged incoming messages (flutter/flutter#149756) 2024-06-05 goderbauer@google.com Fix signature for TokenTemplate.updateFile (flutter/flutter#149673) 2024-06-05 31859944+LongCatIsLooong@users.noreply.github.com Remove temporary LayoutBuilder migration flag, defer `markNeedsLayout` (flutter/flutter#149637) 2024-06-05 yjbanov@google.com Revert "make output of flutter run web tests verbose (#149694)" (flutter/flutter#149766) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
9 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
We have fiddled with this a bunch, and there is definitively no way to reliably include this, so I am removing it. Since CI does not cover all possible values, we can't consistently look up images for local testing. We thought removing it from the look up would work fine, and it did for most tests, but there were still some that could not find an image without it. A brief history on the abi key - added in #143621 - disabled in #148023 - added back in #148072 - we thought there was only an issue with alphabetizing keys - removed from local image look up in #149696 I updated the docs page to also discuss what makes a good key and what does not based on what we learned here.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149435
CI does not comprehensively cover all of the possible abi keys, so some folks can't test locally if their machine's abi does not match CI. This just removes it from the local testing look up. The right image will be summoned, and in CI we can still keep track of it.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.