[material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. #149586

davidhicks980 · 2024-06-03T11:01:04Z

_MenuAnchorState now removes itself from its parent regardless of whether _MenuAnchorState._isOpen is true.

Before, _MenuAnchorState would only detach itself when _MenuAnchorState._isOpen == true. This led to _MenuAnchorState being retained until an anchor's parent was disposed.

Before:

Screen.Recording.2024-06-03.at.6.28.24.AM.mov

After:

Screen.Recording.2024-06-03.at.6.45.56.AM.mov

Fixes #149584

I was a bit unsure what the best way of testing this change would be, and wanted feedback from the Flutter team. Is there a way for us to view at the instance count of _MenuAnchorState, or expose _MenuAnchorState._anchorChildren.length for testing?

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
[] I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Removed self from parent regardless of whether menu is open.

flutter-dashboard · 2024-06-03T11:01:08Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Piinks · 2024-06-05T18:24:55Z

@davidhicks980 thanks for sending the PR! Would you mind adding a test?

Piinks · 2024-06-06T18:42:02Z

@polina-c I am surprised the leak tracker did not already catch this. Do you know how we might be able to capture it in a test?

polina-c · 2024-06-06T19:01:13Z

@polina-c I am surprised the leak tracker did not already catch this. Do you know how we might be able to capture it in a test?

LeakTracker is scoped to catch not disposed leaks at the moment. It does not catch not GCed ones.
It is separate big effort to clean up Flutter Framework from notGCed leaks. And it is not part of leak tracker MVP.
This PR fixes notGCed leak.

Does it help?

Piinks · 2024-06-06T19:11:55Z

Ah ok, thank you for calrifying.

Piinks · 2024-06-06T19:16:50Z

I was looking at the original issue,

Expected results

There should only be one _MenuAnchorState for each menu anchor

Actual results

Detached _MenuAnchorStates are being retained

Maybe to test @davidhicks980 we could just access currentState without needing to expose _MenuAnchorState and just check it is not the same state after opening/closing/opening the menu?

davidhicks980 · 2024-06-07T00:13:03Z

@Piinks So I may be wrong about this, but I think the currentState would still correctly report that it has changed since the state attached to the visible MenuAnchor is changing, but the parent _MenuAnchorState would still be holding on to previous instances of the state as well.

To verify, I wrote this test with the unfixed menu and it did pass, but my test could also be flawed:

testWidgets('Nested anchor state should dispose after a menu is closed', (WidgetTester tester) async {
      State? oldState;
      GlobalKey stateKey = GlobalKey();
      await tester.pumpWidget(MaterialApp(
        home: Material(
          child: Center(
            child: MenuAnchor(
               controller: controller,
                builder: (context, controller, child) {
                  return TextButton(
                      onPressed: () {
                        if (controller.isOpen) {
                          controller.close();
                        } else {
                          controller.open();
                        }
                      },
                      child: const Text('Toggle Menu'));
                },
                menuChildren: [
                  SubmenuButton(
                    key: stateKey,
                    menuChildren: [
                      MenuItemButton(
                        onPressed: () {},
                        child: const Text('Item 1'),
                      ),
                      MenuItemButton(
                        onPressed: () {},
                        child: const Text('Item 2'),
                      ),
                    ],
                    child: const Text('Item 2'),
                  ),
                  SubmenuButton(
                    menuChildren: [
                      MenuItemButton(
                        onPressed: () {},
                        child: const Text('Item 1'),
                      ),
                      MenuItemButton(
                        onPressed: () {},
                        child: const Text('Item 2'),
                      ),
                    ],
                    child: const Text('Item 2'),
                  ),
                ]),
          ),
        ),
      ));
      controller.open();
      await tester.pump();
      oldState = stateKey.currentState;
      controller.close();
      await tester.pump();
      controller.open();
      await tester.pump();
      expect(stateKey.currentState, isNot(oldState));
    });

Added a test that pairs forces garbage collection on a weakly-referenced _MenuAnchorState to check whether it has been dereferenced when its parent is closed.

davidhicks980 · 2024-06-16T09:38:24Z

Okay, assuming checks pass, and forceGC works on CI, this should be good-to-go. I added a test that forces garbage collection on a weakly-referenced _MenuAnchorState, and it appears to correctly identify if a child state is retained by its parent.

ForceGC doesn't work on web

Piinks

Thanks for adding a test - this LGTM with just a few nits

packages/flutter/test/material/menu_anchor_test.dart

packages/flutter/lib/src/material/menu_anchor.dart

justinmc

Thank you for fixing this! Good catch. LGTM 👍

FYI @gspencergoog because MenuAnchor.

justinmc · 2024-06-18T19:45:54Z

packages/flutter/test/material/menu_anchor_test.dart

  });
+
+  testWidgets('Garbage collector destroys child _MenuAnchorState after parent is closed', (WidgetTester tester) async {
+      // Regression test for https://github.com/flutter/flutter/pull/149586


Should you link to the issue? #149584

packages/flutter/test/material/menu_anchor_test.dart

…nt when disposed. (flutter/flutter#149586)

* master: (213 commits) Fix: Memory leak in UndoHistory widget because it never de-registered itself as global UndoManager client (Resolves flutter#148291) (flutter#150661) [CupertinoActionSheet] Fix the layout (part 1) (flutter#149636) Remove discontinued `device_info` and `connectivity` plugins from `flutter_gallery`, roll pub packages (flutter#150585) [a11y] Update semantics in bottom_navigation_bar.dart (flutter#150576) Roll Flutter Engine from dda82d9 to 33415c6 (7 revisions) (flutter#150637) Reland 4: [CupertinoActionSheet] Match colors to native (flutter#150442) Enable SelectionArea double tap/triple tap gesture support for mobile platforms (flutter#149295) made SelectionArea alignment consistent between web and other platform (flutter#150037) Fix link hook typo (flutter#150194) Stop looking for .packages when analyzing (flutter#150349) Update flutter.dev links from misc packages to more permanent destinations (flutter#150532) Roll Flutter Engine from dd37cef to dda82d9 (9 revisions) (flutter#150582) Update Material token to the latest 4.1.0 (flutter#150382) Let the lockfile script generate lockfiles for kotlin gradle files as well (flutter#150471) Make popup menu hardcoded padding configurable (flutter#150506) [flutter_tools] un-hide the --dds flag (flutter#150280) [material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (flutter#149586) Add test for inherited_notifier.0.dart (flutter#150344) [CLI tool] in `flutter test`, consider `--flavor` when validating the cached asset bundle (flutter#150461) Test InputDecoration API examples (flutter#148560) ...

…ileTheme * master: (88 commits) Fix: Memory leak in UndoHistory widget because it never de-registered itself as global UndoManager client (Resolves flutter#148291) (flutter#150661) [CupertinoActionSheet] Fix the layout (part 1) (flutter#149636) Remove discontinued `device_info` and `connectivity` plugins from `flutter_gallery`, roll pub packages (flutter#150585) [a11y] Update semantics in bottom_navigation_bar.dart (flutter#150576) Roll Flutter Engine from dda82d9 to 33415c6 (7 revisions) (flutter#150637) Reland 4: [CupertinoActionSheet] Match colors to native (flutter#150442) Enable SelectionArea double tap/triple tap gesture support for mobile platforms (flutter#149295) made SelectionArea alignment consistent between web and other platform (flutter#150037) Fix link hook typo (flutter#150194) Stop looking for .packages when analyzing (flutter#150349) Update flutter.dev links from misc packages to more permanent destinations (flutter#150532) Roll Flutter Engine from dd37cef to dda82d9 (9 revisions) (flutter#150582) Update Material token to the latest 4.1.0 (flutter#150382) Let the lockfile script generate lockfiles for kotlin gradle files as well (flutter#150471) Make popup menu hardcoded padding configurable (flutter#150506) [flutter_tools] un-hide the --dds flag (flutter#150280) [material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (flutter#149586) Add test for inherited_notifier.0.dart (flutter#150344) [CLI tool] in `flutter test`, consider `--flavor` when validating the cached asset bundle (flutter#150461) Test InputDecoration API examples (flutter#148560) ...

…nt when disposed. (flutter/flutter#149586)

Roll Flutter from 6c06abb to e726eb4 (51 revisions) flutter/flutter@6c06abb...e726eb4 2024-06-25 engine-flutter-autoroll@skia.org Roll Packages from 711b4ac to 03f5f6d (21 revisions) (flutter/flutter#150779) 2024-06-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from afa7ce19bca8 to fbd92055f3a6 (1 revision) (flutter/flutter#150777) 2024-06-25 32538273+ValentinVignal@users.noreply.github.com Reland Add tests for form_text_field.1.dart (#150481) (#150696) (flutter/flutter#150750) 2024-06-25 104349824+huycozy@users.noreply.github.com Add an example for CupertinoPopupSurface (flutter/flutter#150357) 2024-06-25 danny@tuppeny.com [flutter_tools/dap] Handle app.stop errors when launching/attaching (flutter/flutter#149734) 2024-06-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from be7db94196fe to afa7ce19bca8 (18 revisions) (flutter/flutter#150762) 2024-06-25 sigurdm@google.com Remove dubious comment (flutter/flutter#150608) 2024-06-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual engine roll to 6884e83 (#150733)" (flutter/flutter#150746) 2024-06-25 34871572+gmackall@users.noreply.github.com Manual engine roll to 6884e83 (flutter/flutter#150733) 2024-06-24 goderbauer@google.com Linkify 'see also' sections (flutter/flutter#150734) 2024-06-24 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#150712) 2024-06-24 parlough@gmail.com Update flutter.dev links from framework to more permanent destinations (flutter/flutter#150531) 2024-06-24 jason-simmons@users.noreply.github.com Manual engine roll to be7db94196fe (flutter/flutter#150714) 2024-06-24 reidbaker@google.com allow adb to set canfail then use canFail=true for clearing logs (flutter/flutter#150517) 2024-06-24 reidbaker@google.com Update android_device.dart to have clearLogs not print to standard error (flutter/flutter#150197) 2024-06-24 goderbauer@google.com Update issue link in analysis_options.yaml (flutter/flutter#150395) 2024-06-24 srawlins@google.com Fix a number of broken doc comment references (flutter/flutter#150540) 2024-06-24 katelovett@google.com Fix flaky sliver tree test (flutter/flutter#150707) 2024-06-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add tests for form_text_field.1.dart (#150481)" (flutter/flutter#150696) 2024-06-24 32538273+ValentinVignal@users.noreply.github.com Add tests for form_text_field.1.dart (flutter/flutter#150481) 2024-06-22 matthew-carroll@users.noreply.github.com Fix: Memory leak in UndoHistory widget because it never de-registered itself as global UndoManager client (Resolves #148291) (flutter/flutter#150661) 2024-06-22 dkwingsmt@users.noreply.github.com [CupertinoActionSheet] Fix the layout (part 1) (flutter/flutter#149636) 2024-06-21 34871572+gmackall@users.noreply.github.com Remove discontinued `device_info` and `connectivity` plugins from `flutter_gallery`, roll pub packages (flutter/flutter#150585) 2024-06-21 jhy03261997@gmail.com [a11y] Update semantics in bottom_navigation_bar.dart (flutter/flutter#150576) 2024-06-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from dda82d905f37 to 33415c6ee7c2 (7 revisions) (flutter/flutter#150637) 2024-06-21 dkwingsmt@users.noreply.github.com Reland 4: [CupertinoActionSheet] Match colors to native (flutter/flutter#150442) 2024-06-21 rmolivares@renzo-olivares.dev Enable SelectionArea double tap/triple tap gesture support for mobile platforms (flutter/flutter#149295) 2024-06-21 limanegaya@gmail.com made SelectionArea alignment consistent between web and other platform (flutter/flutter#150037) 2024-06-21 moritz@suemmermann.de Fix link hook typo (flutter/flutter#150194) 2024-06-21 sigurdm@google.com Stop looking for .packages when analyzing (flutter/flutter#150349) 2024-06-20 parlough@gmail.com Update flutter.dev links from misc packages to more permanent destinations (flutter/flutter#150532) 2024-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd37cefd4a94 to dda82d905f37 (9 revisions) (flutter/flutter#150582) 2024-06-20 36861262+QuncCccccc@users.noreply.github.com Update Material token to the latest 4.1.0 (flutter/flutter#150382) 2024-06-20 34871572+gmackall@users.noreply.github.com Let the lockfile script generate lockfiles for kotlin gradle files as well (flutter/flutter#150471) 2024-06-20 bruno.leroux@gmail.com Make popup menu hardcoded padding configurable (flutter/flutter#150506) 2024-06-20 christopherfujino@gmail.com [flutter_tools] un-hide the --dds flag (flutter/flutter#150280) 2024-06-20 59215665+davidhicks980@users.noreply.github.com [material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (flutter/flutter#149586) 2024-06-20 32538273+ValentinVignal@users.noreply.github.com Add test for inherited_notifier.0.dart (flutter/flutter#150344) 2024-06-20 andrewrkolos@gmail.com [CLI tool] in `flutter test`, consider `--flavor` when validating the cached asset bundle (flutter/flutter#150461) 2024-06-20 82763757+NobodyForNothing@users.noreply.github.com Test InputDecoration API examples (flutter/flutter#148560) 2024-06-20 polinach@google.com Clean leaky tests. (flutter/flutter#150335) 2024-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9c497f178d3 to dd37cefd4a94 (2 revisions) (flutter/flutter#150537) 2024-06-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from a31279381b40 to f9c497f178d3 (9 revisions) (flutter/flutter#150528) 2024-06-19 32538273+ValentinVignal@users.noreply.github.com Add tests for about_list_tile.0.dart (flutter/flutter#150181) 2024-06-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0ad18fe4c0b5 to a31279381b40 (7 revisions) (flutter/flutter#150473) 2024-06-18 jhy03261997@gmail.com Revert "[a11y] Add semantics: button to bottom navigation bar items and dropdown menu items" (flutter/flutter#150445) ...

…disposed. (flutter#149586) `_MenuAnchorState` now removes itself from its parent regardless of whether `_MenuAnchorState._isOpen` is true. Before, _MenuAnchorState would only detach itself when `_MenuAnchorState._isOpen == true`. This led to _MenuAnchorState being retained until an anchor's parent was disposed. Before: https://github.com/flutter/flutter/assets/59215665/48f1617a-a3d0-49ab-a767-f41e3a30ea41 After: https://github.com/flutter/flutter/assets/59215665/31312bb6-49ec-4083-b8de-e9ae2a42a8b3 Fixes flutter#149584 I was a bit unsure what the best way of testing this change would be, and wanted feedback from the Flutter team. Is there a way for us to view at the instance count of `_MenuAnchorState`, or expose `_MenuAnchorState._anchorChildren.length` for testing? - [] I added new tests to check the change I am making, or this PR is [test-exempt].

…nt when disposed. (flutter/flutter#149586)

Update menu_anchor.dart

1fac415

Removed self from parent regardless of whether menu is open.

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jun 3, 2024

davidhicks980 mentioned this pull request Jun 3, 2024

[material/menu_anchor.dart] _MenuAnchorState is not always GC'd #149584

Closed

davidhicks980 added 4 commits June 16, 2024 05:25

Added forced GC test.

c1f9ef5

Added a test that pairs forces garbage collection on a weakly-referenced _MenuAnchorState to check whether it has been dereferenced when its parent is closed.

Renamed test

73f56ab

Reworded again to remove posessive words

6a1690a

Merge branch 'flutter:master' into patch-3

098b0f4

davidhicks980 added 5 commits June 16, 2024 05:57

Added test skip on kIsWeb

1a9ad65

ForceGC doesn't work on web

Added leak_tracker.dart dependency

7ef58fe

Fixed CI issues

c8bba37

Added multiple GC runs

0a68e0c

Merge branch 'master' into patch-3

35a6de5

Piinks reviewed Jun 18, 2024

View reviewed changes

packages/flutter/test/material/menu_anchor_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/menu_anchor_test.dart Show resolved Hide resolved

packages/flutter/lib/src/material/menu_anchor.dart Outdated Show resolved Hide resolved

Apply suggestions from code review

1db377e

Piinks approved these changes Jun 18, 2024

View reviewed changes

justinmc approved these changes Jun 18, 2024

View reviewed changes

Piinks reviewed Jun 20, 2024

View reviewed changes

packages/flutter/test/material/menu_anchor_test.dart Outdated Show resolved Hide resolved

Update packages/flutter/test/material/menu_anchor_test.dart

3b17343

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 20, 2024

auto-submit bot merged commit c2c1833 into flutter:master Jun 20, 2024

engine-flutter-autoroll mentioned this pull request Jun 20, 2024

Roll Flutter from 6c06abbb5576 to 80a65bd781bc (16 revisions) flutter/packages#6960

Closed

engine-flutter-autoroll mentioned this pull request Jun 21, 2024

Roll Flutter from 6c06abbb5576 to 9056c0b192bd (24 revisions) flutter/packages#6968

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 21, 2024

c2c1833 [material/menu_anchor.dart] Remove _MenuAnchorState from pare…

5760390

…nt when disposed. (flutter/flutter#149586)

engine-flutter-autoroll mentioned this pull request Jun 21, 2024

Roll Flutter from 6c06abbb5576 to 20459dda0d6d (25 revisions) flutter/packages#6969

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 21, 2024

c2c1833 [material/menu_anchor.dart] Remove _MenuAnchorState from pare…

ec591d1

…nt when disposed. (flutter/flutter#149586)

engine-flutter-autoroll mentioned this pull request Jun 22, 2024

Roll Flutter from 6c06abbb5576 to 4a84fb0fea9d (29 revisions) flutter/packages#6971

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 22, 2024

c2c1833 [material/menu_anchor.dart] Remove _MenuAnchorState from pare…

62d227e

…nt when disposed. (flutter/flutter#149586)

engine-flutter-autoroll mentioned this pull request Jun 22, 2024

Roll Flutter from 6c06abbb5576 to 88e6f6297487 (30 revisions) flutter/packages#6972

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 22, 2024

c2c1833 [material/menu_anchor.dart] Remove _MenuAnchorState from pare…

df7ad28

…nt when disposed. (flutter/flutter#149586)

engine-flutter-autoroll mentioned this pull request Jun 23, 2024

Roll Flutter from 6c06abbb5576 to 1cb003b8fb45 (31 revisions) flutter/packages#6974

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2024

c2c1833 [material/menu_anchor.dart] Remove _MenuAnchorState from pare…

de8590b

…nt when disposed. (flutter/flutter#149586)

engine-flutter-autoroll mentioned this pull request Jun 23, 2024

Roll Flutter from 6c06abbb5576 to 1cb003b8fb45 (31 revisions) flutter/packages#6975

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2024

c2c1833 [material/menu_anchor.dart] Remove _MenuAnchorState from pare…

2dca048

…nt when disposed. (flutter/flutter#149586)

engine-flutter-autoroll mentioned this pull request Jun 24, 2024

Roll Flutter from 6c06abbb5576 to 70e9b4185e3d (33 revisions) flutter/packages#6977

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2024

c2c1833 [material/menu_anchor.dart] Remove _MenuAnchorState from pare…

a558225

…nt when disposed. (flutter/flutter#149586)

engine-flutter-autoroll mentioned this pull request Jun 24, 2024

Roll Flutter from 6c06abbb5576 to 70e9b4185e3d (33 revisions) flutter/packages#6978

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2024

c2c1833 [material/menu_anchor.dart] Remove _MenuAnchorState from pare…

24aa4fc

…nt when disposed. (flutter/flutter#149586)

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Flutter from 6c06abbb5576 to 93c14565f0ec (49 revisions) flutter/packages#6985

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2024

c2c1833 [material/menu_anchor.dart] Remove _MenuAnchorState from pare…

191e003

…nt when disposed. (flutter/flutter#149586)

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Flutter from 6c06abbb5576 to f90f40a86619 (50 revisions) flutter/packages#6986

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2024

c2c1833 [material/menu_anchor.dart] Remove _MenuAnchorState from pare…

08f6832

…nt when disposed. (flutter/flutter#149586)

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Flutter from 6c06abbb5576 to e726eb401c2c (51 revisions) flutter/packages#6987

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2024

c2c1833 [material/menu_anchor.dart] Remove _MenuAnchorState from pare…

c7a9df3

…nt when disposed. (flutter/flutter#149586)

Piinks mentioned this pull request Jun 28, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

c2c1833 [material/menu_anchor.dart] Remove _MenuAnchorState from pare…

2bac5b8

…nt when disposed. (flutter/flutter#149586)

matanlurey mentioned this pull request Sep 9, 2024

Garbage collector test for menu_anchor sometimes flakes #154858

Open

[material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. #149586

[material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. #149586

Uh oh!

Conversation

davidhicks980 commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jun 3, 2024

Uh oh!

Piinks commented Jun 5, 2024

Uh oh!

Piinks commented Jun 6, 2024

Uh oh!

polina-c commented Jun 6, 2024

Uh oh!

Piinks commented Jun 6, 2024

Uh oh!

Piinks commented Jun 6, 2024

Expected results

Actual results

Uh oh!

davidhicks980 commented Jun 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidhicks980 commented Jun 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Jun 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

davidhicks980 commented Jun 3, 2024 •

edited

Loading

davidhicks980 commented Jun 7, 2024 •

edited

Loading

davidhicks980 commented Jun 16, 2024 •

edited

Loading