Skip to content

Extend 'flutter symbolize' to handle deferred loading units. #149315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 8 commits into from
Sep 16, 2024
Merged

Extend 'flutter symbolize' to handle deferred loading units. #149315

auto-submit merged 8 commits into from
Sep 16, 2024

Conversation

@sstrickl
Copy link
Contributor

@sstrickl sstrickl commented May 30, 2024 •
edited
Loading

Adds -u/--unit-id-debug-info arguments to flutter symbolize to pass paths to DWARF information for deferred loading units. The argument passed via -u should be of the form N:P, where N is the loading unit ID (an integer) and P is the path to the debug information for loading unit N. The DWARF information for the root loading unit can either be passed by -d/--debug-info as before or by --unit-id-debug-info 1:<path>.

Partial fix for #137527. Additional work is needed to adjust tools built on top of flutter symbolize to store and pass along this additional information appropriately when there are deferred loading units.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 30, 2024
@sstrickl sstrickl force-pushed the deferred-symbolize branch from 7379fdb to 90bf11f Compare May 30, 2024 13:59
@sstrickl sstrickl marked this pull request as ready for review May 30, 2024 14:07
christopherfujino
christopherfujino reviewed Jun 11, 2024
View reviewed changes
christopherfujino
christopherfujino reviewed Jun 11, 2024
View reviewed changes
christopherfujino
christopherfujino reviewed Jun 11, 2024
View reviewed changes
christopherfujino
christopherfujino reviewed Jun 11, 2024
View reviewed changes
@andrewkolos
Copy link
Contributor

andrewkolos commented Aug 8, 2024

@sstrickl Friendly ping.

@sstrickl
Copy link
Contributor Author

sstrickl commented Aug 9, 2024 •
edited
Loading

Thanks for the ping! Sorry, was on leave for a month and then forgot to re-check this once I returned. Looking at Christopher's responses now and will address them either code-wise or with words :)

@sstrickl sstrickl force-pushed the deferred-symbolize branch from 90bf11f to c511dcd Compare August 21, 2024 10:51
@sstrickl
Copy link
Contributor Author

sstrickl commented Aug 21, 2024

Okay, Christopher, I've taken a shot at addressing all your comments. PTAL and let me know if there's anything remaining, or if the changes don't address them adequately!

christopherfujino
christopherfujino approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkolos andrewkolos self-requested a review August 22, 2024 20:36
@christopherfujino
Copy link
Contributor

christopherfujino commented Aug 27, 2024

@andrewkolos friendly ping

andrewkolos
andrewkolos approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 29, 2024

auto label is removed for flutter/flutter/149315, Failed to merge flutter/flutter/149315 with Pull request flutter/flutter/149315 could not be merged: You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information..

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2024
@andrewkolos andrewkolos changed the base branch from main to master August 29, 2024 20:31
@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 29, 2024

auto label is removed for flutter/flutter/149315, due to - The status or check suite Mac_arm64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2024
@sstrickl
Copy link
Contributor Author

sstrickl commented Sep 2, 2024

So looking at the failures, they all are the .dSYM tests, which are just checking that if the .dSYM package directory exists, are failing. However, I'm not sure why, as we never createSync the directory it's looking for in the fresh MemoryFileSystem created using MemoryFileSystem.test(), but _fileSystem.directory(fileName).exists[Sync] and _fileSystem.isDirectory[Sync] both return true for it despite it not being there, and so validation succeeds and its not until the run actually tries to read the bytes out of the non-existent file deep within the non-existent .dSYM directory that fails. Hmm.

@sstrickl
Copy link
Contributor Author

sstrickl commented Sep 16, 2024

Coming back to this after a couple weeks OOO and just realized that I never called _handleDSYM on the path passed as --debug-info, if any. That's why those tests were failing. 🤦‍♀️

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 16, 2024
@auto-submit auto-submit bot merged commit c50b3fe into flutter:master Sep 16, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2024
@engine-flutter-autoroll
c50b3fe Extend 'flutter symbolize' to handle deferred loading units. (f…
abda67c 
…lutter/flutter#149315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 17, 2024
@engine-flutter-autoroll
c50b3fe Extend 'flutter symbolize' to handle deferred loading units. (f…
ab71949 
…lutter/flutter#149315)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 17, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 17, 2024
@engine-flutter-autoroll
c50b3fe Extend 'flutter symbolize' to handle deferred loading units. (f…
8e2e582 
…lutter/flutter#149315)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 17, 2024
@engine-flutter-autoroll
Roll Flutter from 5d83a98 to c4c9f47 (15 revisions) (#7656)
4f2b9cd 
flutter/flutter@5d83a98...c4c9f47

2024-09-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from a328f2362414 to 1376288f5c2a (1 revision) (flutter/flutter#155282)
2024-09-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 04bc90bff86c to a328f2362414 (2 revisions) (flutter/flutter#155280)
2024-09-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6b698138c600 to 04bc90bff86c (3 revisions) (flutter/flutter#155277)
2024-09-16 30870216+gaaclarke@users.noreply.github.com Added .keys to ColorSwatch (flutter/flutter#155262)
2024-09-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 362b9bcdedce to 6b698138c600 (4 revisions) (flutter/flutter#155267)
2024-09-16 engine-flutter-autoroll@skia.org Roll Packages from 330581f to df88c81 (7 revisions) (flutter/flutter#155261)
2024-09-16 sstrickl@google.com Extend 'flutter symbolize' to handle deferred loading units. (flutter/flutter#149315)
2024-09-16 christopherfujino@gmail.com Catch unable to start app exception (flutter/flutter#154970)
2024-09-16 magder@google.com Assert iOS framework artifact contains xcprivacy manifest (flutter/flutter#155187)
2024-09-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 52dcc8a16d8b to 362b9bcdedce (1 revision) (flutter/flutter#155241)
2024-09-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from af4fe97fa13a to 52dcc8a16d8b (1 revision) (flutter/flutter#155238)
2024-09-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9aaea5a4bd50 to af4fe97fa13a (1 revision) (flutter/flutter#155235)
2024-09-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from fe22a199aca3 to 9aaea5a4bd50 (1 revision) (flutter/flutter#155232)
2024-09-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from f5ccef12c15c to fe22a199aca3 (1 revision) (flutter/flutter#155229)
2024-09-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 622d4aec2e04 to f5ccef12c15c (1 revision) (flutter/flutter#155215)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
c50b3fe Extend 'flutter symbolize' to handle deferred loading units. (f…
e6bc6b9 
…lutter/flutter#149315)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
c50b3fe Extend 'flutter symbolize' to handle deferred loading units. (f…
fa8b559 
…lutter/flutter#149315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkolos andrewkolos andrewkolos approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sstrickl @andrewkolos @christopherfujino