Place flutter_gpu in the package cache.
#149299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
|
Wondering if it makes sense to add a unit test similar to https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/cache_test.dart#L367 that populates the |
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
May 30, 2024
…ci/android_debug. (#53107) Part of flutter/flutter#131711. Also, stops distributing `flutter_gpu` as part of the host artifacts, since it's not target-specific. This enables us to use the same distribution mechanism as the `sky_engine` package. Corresponding framework PR: flutter/flutter#149299
38533a6 to
35a2513
Compare
Member
Author
|
Added a test that verifies |
8346045 to
b5717dd
Compare
zanderso
approved these changes
Jun 3, 2024
| .listSync(recursive: true) | ||
| .whereType<Directory>() | ||
| .singleWhereOrNull((Directory directory) => directory.basename == 'pkg')!; | ||
| expect(dir, isNotNull); |
Member
There was a problem hiding this comment.
This is harmless(?) but redundant.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
hello-coder-xu
pushed a commit
to hello-coder-xu/flutter
that referenced
this pull request
Jun 4, 2024
…pdate * master: (168 commits) Fix the scrolling layout deviation of `CupertinoActionSheet` (flutter#149439) Roll Flutter Engine from 60a7bb2 to a6aa5d8 (2 revisions) (flutter#149627) Roll Flutter Engine from ea72558 to 60a7bb2 (2 revisions) (flutter#149623) Place `flutter_gpu` in the package cache. (flutter#149299) Switch to triage-* labels for platform package triage (flutter#149614) Roll pub packages (flutter#149617) Fixes multi line textfield hint text gets ellipsized (flutter#148423) Support failures-only and silent reporters in `flutter test` (flutter#148739) [CupertinoActionSheet] Fix overflow of the overscroll section when the user scrolls far (flutter#149542) Fix InputDecorator.prefixIcon color when disabled (flutter#149595) Added filter callback on dropdown menu (flutter#143939) update generated localized message files in the stocks test app (flutter#148741) Add a simplified SimpleCascadingMenuApp example (flutter#149147) Reland "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149303) Move some benchmarks from MotoG4 to Mokey (flutter#149567) Roll Packages from d8e8e8c to 11e192a (2 revisions) (flutter#149596) Cleanup triage reports from docs/ (flutter#149545) Roll Flutter Engine from d81edf6 to ea72558 (1 revision) (flutter#149590) Roll Flutter Engine from b0f4d74 to d81edf6 (1 revision) (flutter#149468) Roll Flutter Engine from 40b868e to b0f4d74 (1 revision) (flutter#149467) ...
hello-coder-xu
added a commit
to hello-coder-xu/flutter
that referenced
this pull request
Jun 6, 2024
…pdate * master: (168 commits) Fix the scrolling layout deviation of `CupertinoActionSheet` (flutter#149439) Roll Flutter Engine from 60a7bb2 to a6aa5d8 (2 revisions) (flutter#149627) Roll Flutter Engine from ea72558 to 60a7bb2 (2 revisions) (flutter#149623) Place `flutter_gpu` in the package cache. (flutter#149299) Switch to triage-* labels for platform package triage (flutter#149614) Roll pub packages (flutter#149617) Fixes multi line textfield hint text gets ellipsized (flutter#148423) Support failures-only and silent reporters in `flutter test` (flutter#148739) [CupertinoActionSheet] Fix overflow of the overscroll section when the user scrolls far (flutter#149542) Fix InputDecorator.prefixIcon color when disabled (flutter#149595) Added filter callback on dropdown menu (flutter#143939) update generated localized message files in the stocks test app (flutter#148741) Add a simplified SimpleCascadingMenuApp example (flutter#149147) Reland "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149303) Move some benchmarks from MotoG4 to Mokey (flutter#149567) Roll Packages from d8e8e8c to 11e192a (2 revisions) (flutter#149596) Cleanup triage reports from docs/ (flutter#149545) Roll Flutter Engine from d81edf6 to ea72558 (1 revision) (flutter#149590) Roll Flutter Engine from b0f4d74 to d81edf6 (1 revision) (flutter#149468) Roll Flutter Engine from 40b868e to b0f4d74 (1 revision) (flutter#149467) ...
hello-coder-xu
added a commit
to hello-coder-xu/flutter
that referenced
this pull request
Jun 9, 2024
…pdate * master: (181 commits) Fix the scrolling layout deviation of `CupertinoActionSheet` (flutter#149439) Roll Flutter Engine from 60a7bb2 to a6aa5d8 (2 revisions) (flutter#149627) Roll Flutter Engine from ea72558 to 60a7bb2 (2 revisions) (flutter#149623) Place `flutter_gpu` in the package cache. (flutter#149299) Switch to triage-* labels for platform package triage (flutter#149614) Roll pub packages (flutter#149617) Fixes multi line textfield hint text gets ellipsized (flutter#148423) Support failures-only and silent reporters in `flutter test` (flutter#148739) [CupertinoActionSheet] Fix overflow of the overscroll section when the user scrolls far (flutter#149542) Fix InputDecorator.prefixIcon color when disabled (flutter#149595) Added filter callback on dropdown menu (flutter#143939) update generated localized message files in the stocks test app (flutter#148741) Add a simplified SimpleCascadingMenuApp example (flutter#149147) Reland "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149303) Move some benchmarks from MotoG4 to Mokey (flutter#149567) Roll Packages from d8e8e8c to 11e192a (2 revisions) (flutter#149596) Cleanup triage reports from docs/ (flutter#149545) Roll Flutter Engine from d81edf6 to ea72558 (1 revision) (flutter#149590) Roll Flutter Engine from b0f4d74 to d81edf6 (1 revision) (flutter#149468) Roll Flutter Engine from 40b868e to b0f4d74 (1 revision) (flutter#149467) ...
hello-coder-xu
added a commit
to hello-coder-xu/flutter
that referenced
this pull request
Jun 11, 2024
* master: (181 commits) Fix the scrolling layout deviation of `CupertinoActionSheet` (flutter#149439) Roll Flutter Engine from 60a7bb2 to a6aa5d8 (2 revisions) (flutter#149627) Roll Flutter Engine from ea72558 to 60a7bb2 (2 revisions) (flutter#149623) Place `flutter_gpu` in the package cache. (flutter#149299) Switch to triage-* labels for platform package triage (flutter#149614) Roll pub packages (flutter#149617) Fixes multi line textfield hint text gets ellipsized (flutter#148423) Support failures-only and silent reporters in `flutter test` (flutter#148739) [CupertinoActionSheet] Fix overflow of the overscroll section when the user scrolls far (flutter#149542) Fix InputDecorator.prefixIcon color when disabled (flutter#149595) Added filter callback on dropdown menu (flutter#143939) update generated localized message files in the stocks test app (flutter#148741) Add a simplified SimpleCascadingMenuApp example (flutter#149147) Reland "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149303) Move some benchmarks from MotoG4 to Mokey (flutter#149567) Roll Packages from d8e8e8c to 11e192a (2 revisions) (flutter#149596) Cleanup triage reports from docs/ (flutter#149545) Roll Flutter Engine from d81edf6 to ea72558 (1 revision) (flutter#149590) Roll Flutter Engine from b0f4d74 to d81edf6 (1 revision) (flutter#149468) Roll Flutter Engine from 40b868e to b0f4d74 (1 revision) (flutter#149467) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #131711.
Fetch https://storage.googleapis.com/flutter_infra_release/flutter/${engine_version}/flutter_gpu.zip and extract it into the package cache.
Cannot function until flutter/engine#53107 has been merged/rolled into the framework.