Introduce ChipAnimationStyle to override default chips animations durations
#149245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleroux
reviewed
Jun 6, 2024
examples/api/test/material/chip/chip_attributes.chip_animation_style.0_test.dart
Outdated
Show resolved
Hide resolved
Contributor
|
A reason for requesting a revert of flutter/flutter/149245 could |
Contributor
|
Reason for revert: the newly-added unit test might cause the red tree |
Contributor
This has happened on several PRs this week. How are these tests passing in presubmit? cc @christopherfujino I'll file an infra bug |
9 tasks
auto-submit bot
added a commit
that referenced
this pull request
Jun 6, 2024
…mations durations (#149245)" (#149847) Reverts: #149245 Initiated by: QuncCccccc Reason for reverting: the newly-added unit test might cause the red tree Original PR Author: TahaTesser Reviewed By: {bleroux, Piinks} This change reverts the following previous change: fixes [Custom backgroundColor on Chip makes it flicker between state transitions](#146730) ### Example preview  https://github.com/flutter/flutter/assets/48603081/a4949ce7-f38b-4251-8201-ecc570ec447c
Contributor
Looks like we tested the wrong commit in presubmit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745894885153659393/+/u/flutter_doctor/stdout I don't think we even ran this test. Will follow up on the tracking issue. |
Contributor
That could have also caused the gold failures at head if some subset of golden file tests did not run in presubmit. Filed #149851 |
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2024
…ations durations (flutter/flutter#149245)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2024
…ations durations (flutter/flutter#149245)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2024
…ations durations (flutter/flutter#149245)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2024
…ations durations (flutter/flutter#149245)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2024
…ations durations (flutter/flutter#149245)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2024
…ations durations (flutter/flutter#149245)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 7, 2024
…ations durations (flutter/flutter#149245)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 7, 2024
Manual roll Flutter from 4608a89 to fc19ecf (38 revisions) Manual roll requested by dit@google.com flutter/flutter@4608a89...fc19ecf 2024-06-07 tessertaha@gmail.com Fix `SegmentedButton` clipping when drawing segments (flutter/flutter#149739) 2024-06-07 zanderso@users.noreply.github.com Shift consistently passing tests on mokey to prod (flutter/flutter#149902) 2024-06-07 polinach@google.com Prepare images for tests individually to enable clean up of cache. (flutter/flutter#149693) 2024-06-07 engine-flutter-autoroll@skia.org Roll Packages from 586faa6 to 8a2c4e4 (8 revisions) (flutter/flutter#149900) 2024-06-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98e9393bf2e9 to 1cdbebee1901 (4 revisions) (flutter/flutter#149899) 2024-06-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 087feab9922b to 98e9393bf2e9 (1 revision) (flutter/flutter#149875) 2024-06-07 21270878+elliette@users.noreply.github.com Refactor `widget_inspector_test.dart` (flutter/flutter#149850) 2024-06-07 32538273+ValentinVignal@users.noreply.github.com Add test for dropdown_menu.1.dart (flutter/flutter#149547) 2024-06-07 32538273+ValentinVignal@users.noreply.github.com Add test for standard_fab_location.0.dart (flutter/flutter#149225) 2024-06-07 dacoharkes@google.com [native_assets] Fix framework name deduplication (flutter/flutter#149761) 2024-06-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 47b15dfba1da to 087feab9922b (1 revision) (flutter/flutter#149871) 2024-06-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5d5e0ee9102c to 47b15dfba1da (2 revisions) (flutter/flutter#149870) 2024-06-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from fea8e51b0280 to 5d5e0ee9102c (2 revisions) (flutter/flutter#149867) 2024-06-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a0a49939c64 to fea8e51b0280 (2 revisions) (flutter/flutter#149865) 2024-06-07 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#149864) 2024-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from bf1a4877da0b to 5a0a49939c64 (1 revision) (flutter/flutter#149861) 2024-06-06 ian@hixie.ch Remove some vestigial /*!*/ comments (flutter/flutter#149361) 2024-06-06 jacksongardner@google.com Attempt to fix some web test flakiness. (flutter/flutter#149828) 2024-06-06 katelovett@google.com Remove abi key permanently from golden file testing (flutter/flutter#149858) 2024-06-06 dkwingsmt@users.noreply.github.com [CupertinoActionSheet] Add sliding tap gesture (flutter/flutter#149471) 2024-06-06 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#149852) 2024-06-06 hans.muller@gmail.com SliverResizingHeader (flutter/flutter#143325) 2024-06-06 15619084+vashworth@users.noreply.github.com Run tests on macOS 13 or 14 (flutter/flutter#149827) 2024-06-06 polinach@google.com Fix leaky test. (flutter/flutter#149823) 2024-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 31804a222f97 to bf1a4877da0b (3 revisions) (flutter/flutter#149848) 2024-06-06 vtrgalo@gmail.com Add support for setting the heading level for web semantics (#97894) (flutter/flutter#125771) 2024-06-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `ChipAnimationStyle` to override default chips animations durations (#149245)" (flutter/flutter#149847) 2024-06-06 kevinjchisholm@google.com 3.22.2 release notes (flutter/flutter#149818) 2024-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 25bcbb888939 to 31804a222f97 (3 revisions) (flutter/flutter#149837) 2024-06-06 tessertaha@gmail.com Introduce `ChipAnimationStyle` to override default chips animations durations (flutter/flutter#149245) 2024-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from f5a9690c6061 to 25bcbb888939 (1 revision) (flutter/flutter#149835) 2024-06-06 polinach@google.com Fix leaky test. (flutter/flutter#149822) 2024-06-06 magder@google.com Unpin archive package from tool, update to version without security advisories (flutter/flutter#149430) 2024-06-06 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#149630) 2024-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from d9684a37af06 to f5a9690c6061 (7 revisions) (flutter/flutter#149832) 2024-06-06 engine-flutter-autoroll@skia.org Roll Packages from 11e192a to 586faa6 (13 revisions) (flutter/flutter#149820) 2024-06-06 mdebbar@google.com Fix some links in the "Handling breaking change" section (flutter/flutter#149821) 2024-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 92d0cd9370f7 to d9684a37af06 (1 revision) (flutter/flutter#149793) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. ...
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
…mations durations (#149876) Reland - #149245 --- fixes [Custom backgroundColor on Chip makes it flicker between state transitions](#146730) ### Example preview  https://github.com/flutter/flutter/assets/48603081/a4949ce7-f38b-4251-8201-ecc570ec447c
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…mations durations (flutter#149876) Reland - flutter#149245 --- fixes [Custom backgroundColor on Chip makes it flicker between state transitions](flutter#146730) ### Example preview  https://github.com/flutter/flutter/assets/48603081/a4949ce7-f38b-4251-8201-ecc570ec447c
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…mations durations (flutter#149876) Reland - flutter#149245 --- fixes [Custom backgroundColor on Chip makes it flicker between state transitions](flutter#146730) ### Example preview  https://github.com/flutter/flutter/assets/48603081/a4949ce7-f38b-4251-8201-ecc570ec447c
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
…ations durations (flutter/flutter#149245)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Custom backgroundColor on Chip makes it flicker between state transitions
Example preview
Screen.Recording.2024-05-29.at.17.58.18.mov
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.