[web] Remove --dart-sdk flag to dart2wasm compiler #149129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dart2wasm only needs a platform file, which contains the compiled `dart:*` libraries. There's no need to specify a seperate `--dart-sdk` option (anymore). (See also https://dart-review.googlesource.com/c/sdk/+/366821)
osa1
approved these changes
May 27, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 28, 2024
…rom dart2wasm Flutter no longer uses the --dart-sdk option (see [0]). g3 usages will be removed in [1] [0] flutter/flutter#149129 [1] cl/637819163 Change-Id: Ic06bb30da45428367ddcbfaf165c8f046dcbaaa0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368306 Reviewed-by: Ömer Ağacan <omersa@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 28, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 28, 2024
flutter/flutter@0b31ffc...a1a33e6 2024-05-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6e0f812d82fe to b1751088c7e9 (1 revision) (flutter/flutter#149157) 2024-05-28 kustermann@google.com [web] Remove --dart-sdk flag to dart2wasm compiler (flutter/flutter#149129) 2024-05-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 416c619829a6 to 6e0f812d82fe (1 revision) (flutter/flutter#149155) 2024-05-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from cf201b119585 to 416c619829a6 (1 revision) (flutter/flutter#149148) 2024-05-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from dcc063c8deae to cf201b119585 (1 revision) (flutter/flutter#149143) 2024-05-27 engine-flutter-autoroll@skia.org Roll Packages from 7b423f5 to b7bcb4b (7 revisions) (flutter/flutter#149136) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
Dart2wasm only needs a platform file, which contains the compiled `dart:*` libraries. There's no need to specify a seperate `--dart-sdk` option (anymore). (See also https://dart-review.googlesource.com/c/sdk/+/366821)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dart2wasm only needs a platform file, which contains the compiled
dart:*libraries. There's no need to specify a seperate--dart-sdkoption (anymore).(See also https://dart-review.googlesource.com/c/sdk/+/366821)