Fix InputDecorator default hint text style on M3 #148944
Conversation
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #148944 at sha c1a4310d1ef325e3bce2316a25e86c79d18a82f4 |
|
@Renzo-Olivares This a follow-up PR to #148113 where I added the TODOs. |
There was a problem hiding this comment.
nit: period at the end of this sentence.
c1a4310 to
8627db8
Compare
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
cc @guidezpl This LGTM but wanted to get your input on this since I'm not too familiar with the m3 spec. |
guidezpl
left a comment
There was a problem hiding this comment.
Disreguard previous review, LGTM :)
|
@Renzo-Olivares The Google tests failures are probably legit. Can you please have a look? |
|
@bleroux I just looked through the google testing failures and they all look expected. I'll try to land this tomorrow. |
|
@bleroux I missed the golden changes when reviewing this. I took a look https://flutter-gold.skia.org/detail?grouping=name%3Dmaterial.m3_input_decorator.outline_icon_label.rtl%26source_type%3Dflutter&digest=0ebe1c484196c24b21ab16fc22738bab but am a little unsure. It looks like the floating label is being affected which I didn't expect. |
|
Reason for revert: This caused Skia golden changes that might be unexpected. We can reland once we confirm these changes are expected, or, fixed the changes to the floating label. |
This reverts commit b201fbd.
…149448) Reverts: #148944 Initiated by: loic-sharma Reason for reverting: This caused Skia golden changes that might be unexpected. We can reland once we confirm these changes are expected, or, fixed the changes to the floating label. Original PR Author: bleroux Reviewed By: {Renzo-Olivares, guidezpl} This change reverts the following previous change: ## Description This PRs makes the `InputDecoration.hintText` style compliant with the M3 spec. The hint style is not clearly specified in https://m3.material.io/components/text-fields/specs, but it is in the M3 Figma kit. ('hint' terminology came from the Material1 specification, since M2 the terminology is 'Placeholder'). See this Figma screenshot taken while focusing on the 'Placeholder' text (which corresponds to hint).  It seems that the intention is that the 'Placeholder' colors should be the same as the 'supporting text' ones, that is why is reused 'supporting text' tokens. ## Related Issue Fixes #148787. ## Tests Updates several tests.
## Description This PR is a partial reland of #148944 which was reverted in #149448. It makes the `InputDecoration.hintText` colors compliant with the M3 spec. The initial PR also changed the font style, I will land the font change in another PR to better track the golden changes. ## Related Issue Related to the color part of #148787. ## Tests Updates several tests.
## Description This PR is a partial reland of flutter#148944 which was reverted in flutter#149448. It makes the `InputDecoration.hintText` font style compliant with the M3 spec. (First part of the reland was merged in flutter#150278) ## Related Issue Fixes flutter#148787. ## Tests Updates several tests.
## Description This PR is a partial reland of flutter#148944 which was reverted in flutter#149448. It makes the `InputDecoration.hintText` font style compliant with the M3 spec. (First part of the reland was merged in flutter#150278) ## Related Issue Fixes flutter#148787. ## Tests Updates several tests.
Description
This PRs makes the
InputDecoration.hintTextstyle compliant with the M3 spec.The hint style is not clearly specified in https://m3.material.io/components/text-fields/specs, but it is in the M3 Figma kit.
('hint' terminology came from the Material1 specification, since M2 the terminology is 'Placeholder').
See this Figma screenshot taken while focusing on the 'Placeholder' text (which corresponds to hint).
It seems that the intention is that the 'Placeholder' colors should be the same as the 'supporting text' ones, that is why is reused 'supporting text' tokens.
Related Issue
Fixes #148787.
Tests
Updates several tests.