Skip to content

Try removing robolectric from integration_test tests #148803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
May 22, 2024
Merged

Try removing robolectric from integration_test tests #148803

auto-submit merged 5 commits into from
May 22, 2024

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented May 21, 2024 •
edited
Loading

May fix #148393.

There are reports on the robolectric issue tracker of >4.10.3 causing the error we are seeing
robolectric/robolectric#8158
The test doesn't actually need robolectric (and didn't originally use it, or flake before using it), but it was added in #144348. We can safely remove it by mocking the call to View.generateViewId(), so try removing it and see if flakes go away.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels May 21, 2024
@gmackall gmackall changed the title try it Try removing robolectric from integration_test tests May 21, 2024
@gmackall gmackall marked this pull request as ready for review May 21, 2024 22:53
@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@gmackall gmackall requested review from a team and goderbauer May 21, 2024 23:20
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2024
@gmackall
Copy link
Member Author

gmackall commented May 22, 2024

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

This is exclusively changes to a test

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented May 22, 2024

auto label is removed for flutter/flutter/148803, due to - The status or check suite Linux web_long_running_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2024
@auto-submit auto-submit bot merged commit eba7b97 into flutter:master May 22, 2024
@gmackall gmackall mentioned this pull request May 22, 2024
Closed
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 23, 2024
@hello-coder-xu
Merge branch 'fix/_floatingActionButtonVisibilityValue-update' of htt…
396e78f 
…ps://github.com/hello-coder-xu/flutter into fix/_floatingActionButtonVisibilityValue-update

* 'fix/_floatingActionButtonVisibilityValue-update' of https://github.com/hello-coder-xu/flutter:
  fix: update _floatingActionButtonVisibility only if floatingActionButton is not null
  [wiki migration] Remaining pages under docs/about/ (flutter#148782)
  Roll Flutter Engine from b6971cd to 8b094fb (3 revisions) (flutter#148883)
  Fix the second TextFormField to trigger onTapOutside (flutter#148206)
  Try removing robolectric from `integration_test` tests (flutter#148803)
  Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter#147160)
  [wiki migration] Tool team pages (flutter#148779)
  Roll Flutter Engine from c89defa to b6971cd (6 revisions) (flutter#148819)
  [native_assets] Add support for link hooks (flutter#148474)
  Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter#148864)
  Update tokens to 4.0.0 (flutter#148789)
  Move Linux web_long_running_tests_2_5 to bringup (flutter#148854)
  `CupertinoDialogRoute` leak fix (flutter#148774)
  Marks Windows plugin_test to be flaky (flutter#148835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
eba7b97 Try removing robolectric from integration_test tests (flutt…
ff711ef 
…er/flutter#148803)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
eba7b97 Try removing robolectric from integration_test tests (flutt…
9c84a8d 
…er/flutter#148803)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
eba7b97 Try removing robolectric from integration_test tests (flutt…
c4cc9f7 
…er/flutter#148803)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
Roll Flutter from 73bf206 to 8d955cd (24 revisions) (#6786)
1008d9e 
flutter/flutter@73bf206...8d955cd

2024-05-23 nate.w5687@gmail.com Update `FocusManager` platform check to include iOS (flutter/flutter#148612)
2024-05-23 matej.knopp@gmail.com [iOS] fix hot restart with native assets (flutter/flutter#148752)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) (flutter/flutter#148943)
2024-05-23 104349824+huycozy@users.noreply.github.com Fix DecoratedSliver sample code to reflect the description (flutter/flutter#148621)
2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Test raw autocomplete api examples (flutter/flutter#148234)
2024-05-23 32538273+ValentinVignal@users.noreply.github.com Add test for scaffold.0.dart and scaffold.2.dart (flutter/flutter#148166)
2024-05-23 sokolovskyi.konstantin@gmail.com Add tests for restorable_value.0.dart API example. (flutter/flutter#148676)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) (flutter/flutter#148919)
2024-05-22 31859944+LongCatIsLooong@users.noreply.github.com Allow `RenderObject.getTransformTo` to take an arbitrary RenderObject in the same tree (flutter/flutter#148897)
2024-05-22 kevinjchisholm@google.com 3.22.1 changelog updates (flutter/flutter#148895)
2024-05-22 helinx@google.com Add frame number and widget location map service extension (flutter/flutter#148702)
2024-05-22 31859944+LongCatIsLooong@users.noreply.github.com Remove an assert with false positives (flutter/flutter#148795)
2024-05-22 rmolivares@renzo-olivares.dev Revert "Fix the second TextFormField to trigger onTapOutside" (flutter/flutter#148909)
2024-05-22 katelovett@google.com [wiki migration] Remaining pages under docs/about/ (flutter/flutter#148782)
2024-05-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter/flutter#148883)
2024-05-22 42757204+wyqlxf@users.noreply.github.com Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148206)
2024-05-22 34871572+gmackall@users.noreply.github.com Try removing robolectric from `integration_test` tests (flutter/flutter#148803)
2024-05-22 victoreronmosele@gmail.com Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter/flutter#147160)
2024-05-22 katelovett@google.com [wiki migration] Tool team pages (flutter/flutter#148779)
2024-05-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter/flutter#148819)
2024-05-22 dacoharkes@google.com [native_assets] Add support for link hooks (flutter/flutter#148474)
2024-05-22 engine-flutter-autoroll@skia.org Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter/flutter#148864)
2024-05-22 36861262+QuncCccccc@users.noreply.github.com Update tokens to 4.0.0 (flutter/flutter#148789)
2024-05-22 zanderso@users.noreply.github.com Move Linux web_long_running_tests_2_5 to bringup (flutter/flutter#148854)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@gmackall @victorsanni
Try removing robolectric from integration_test tests (flutter#148803)
94ea01c 
May fix flutter#148393.

There are reports on the robolectric issue tracker of >`4.10.3` causing the error we are seeing
robolectric/robolectric#8158
The test doesn't actually need robolectric (and didn't originally use it, or flake before using it), but it was added in flutter#144348. We can safely remove it by mocking the call to `View.generateViewId()`, so try removing it and see if flakes go away.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
eba7b97 Try removing robolectric from integration_test tests (flutt…
9a5007a 
…er/flutter#148803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linux framework_tests_misc is 2.02% flaky

2 participants

@gmackall @reidbaker