Skip to content

Conversation

@derdilla
Copy link
Contributor

@derdilla derdilla commented May 3, 2024

Adds tests to the last two Snack Bar examples as part of #130459. Makes the last example more usable through the use of standard widgets and visual hierarchy. Constraints on options that are not required by the SnackBar contract have been removed (Overflow threshold works on fixed SnackBars).

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 3, 2024
@goderbauer goderbauer requested review from TahaTesser and bleroux May 7, 2024 22:11
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2024
@auto-submit auto-submit bot merged commit aaa4d33 into flutter:master May 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 24, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 24, 2024
flutter/flutter@8d955cd...8dd0831

2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from c6041cd9049c to 4ab442475223 (1 revision) (flutter/flutter#149039)
2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8d896f4feb76 to c6041cd9049c (1 revision) (flutter/flutter#149035)
2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from fe3b26294d8f to 8d896f4feb76 (1 revision) (flutter/flutter#149030)
2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from b4fb08f21757 to fe3b26294d8f (1 revision) (flutter/flutter#149028)
2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from f873230ce823 to b4fb08f21757 (2 revisions) (flutter/flutter#149025)
2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from d78f66753332 to f873230ce823 (1 revision) (flutter/flutter#149021)
2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 768c90ee5dc7 to d78f66753332 (3 revisions) (flutter/flutter#149011)
2024-05-23 nate.w5687@gmail.com Reland "Update `FocusManager` platform check to include iOS" (flutter/flutter#148984)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from ad12c5d02a8c to 768c90ee5dc7 (2 revisions) (flutter/flutter#149003)
2024-05-23 tessertaha@gmail.com Fix `SnackBar` action text button overlay color (flutter/flutter#148961)
2024-05-23 42757204+wyqlxf@users.noreply.github.com Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148930)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2a48302f6f4e to ad12c5d02a8c (3 revisions) (flutter/flutter#148993)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 964f087f288c to 2a48302f6f4e (1 revision) (flutter/flutter#148950)
2024-05-23 katelovett@google.com [wiki migration] Remaining pages under docs/contributing/ (flutter/flutter#148790)
2024-05-23 katelovett@google.com [wiki migration] Web team pages (flutter/flutter#148777)
2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Test remaining transitions api examples (flutter/flutter#148302)
2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Test snack bar examples (flutter/flutter#147774)
2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Add tests for material banner example (flutter/flutter#147733)
2024-05-23 engine-flutter-autoroll@skia.org Roll Packages from 6525441 to 1008d9e (6 revisions) (flutter/flutter#148980)
2024-05-23 goderbauer@google.com Revert "const vs. non-const widget build benchmark" (flutter/flutter#148970)
2024-05-23 ian@hixie.ch Remove hidden dependencies on HttpClient (flutter/flutter#148773)
2024-05-23 rmolivares@renzo-olivares.dev Revert "Update `FocusManager` platform check to include iOS" (flutter/flutter#148978)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
Adds tests to the last two Snack Bar examples as part of flutter#130459. Makes the [last example](https://api.flutter.dev/flutter/material/SnackBar-class.html#material.SnackBar.3) more usable through the use of standard widgets and visual hierarchy. Constraints on options that are not required by the SnackBar contract have been removed (Overflow threshold works on fixed SnackBars).
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants