Skip to content

Conversation

@eliasyishak
Copy link
Contributor

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

Proactive fix for issue:

More information can be found for the changes in this hotfix in the following diff

Changelog Description:

Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples

Bump the version for package:unified_analytics to 5.8.8+1 to better handle errors internal to the package that can crash the tool

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

This could potentially impact flutter developers as they are using the flutter tool

Workaround:

Is there a workaround for this issue?

No workaround, they would need to run the flutter tool again.

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

If this works correctly, there would be no errors from package:unified_analytics causing errors

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 17, 2024
@eliasyishak eliasyishak mentioned this pull request Apr 17, 2024
@christopherfujino
Copy link
Contributor

checksum failure:

Warning: one or more pubspecs have invalid dependencies. Please run "flutter update-packages --force-upgrade" to update them correctly.

@christopherfujino
Copy link
Contributor

checksum failure:

Warning: one or more pubspecs have invalid dependencies. Please run "flutter update-packages --force-upgrade" to update them correctly.

I ran update-packages locally and pushed a commit to update the checksum

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliasyishak
Copy link
Contributor Author

@christopherfujino awesome, thanks for handling that!

@eliasyishak
Copy link
Contributor Author

What are next steps for this PR? Do we still use the autosubmit label or will the release team take it over? @christopherfujino @itsjustkevin

@eliasyishak eliasyishak added the cp: review Cherry-picks in the review queue label Apr 18, 2024
@christopherfujino
Copy link
Contributor

What are next steps for this PR? Do we still use the autosubmit label or will the release team take it over? @christopherfujino @itsjustkevin

It's up to the release on-call to actually add autosubmit. unless the release team has a specific question we need to answer, our job should be done here.

@itsjustkevin itsjustkevin added cp: approved Approved cherry-pick request autosubmit Merge PR when tree becomes green via auto submit App labels Apr 19, 2024
@auto-submit auto-submit bot merged commit 27dfff1 into flutter:flutter-3.22-candidate.0 Apr 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: approved Approved cherry-pick request cp: review Cherry-picks in the review queue tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants