Refactor framework coverage tests #146210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
auto label is removed for flutter/flutter/146210, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
auto label is removed for flutter/flutter/146210, due to Pull request flutter/flutter/146210 is not in a mergeable state. |
e3b7e49 to
7088998
Compare
26 tasks
goderbauer
reviewed
Apr 8, 2024
|
|
||
| import 'package:path/path.dart' as path; | ||
|
|
||
| import '../test.dart'; |
Member
There was a problem hiding this comment.
This circular dependency (test.dart -> run_framework_coverage_tests.dart -> test.dart) is odd. Should the runFlutterTest live in a separate file that can be used by both?
Contributor
Author
There was a problem hiding this comment.
I moved the runFlutterTest function to the existing utils file. Does that seem like an appropriate place for the method? I could also make a more specific runner_utils file for functions relating to running the suites if that would be more helpful.
9 tasks
Contributor
Author
|
Holding off on merging this until the util refactor from #146592 is ironed out and lands |
…or_framework_tests
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 19, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 19, 2024
flutter/flutter@fb110b9...98685a0 2024-04-19 15619084+vashworth@users.noreply.github.com Replace CocoaPods deprecated `exists?` with `exist?` (flutter/flutter#147056) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ed7a2d6aed9 to 7fafbbf17c02 (2 revisions) (flutter/flutter#147046) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 25d773ea90c4 to 4ed7a2d6aed9 (3 revisions) (flutter/flutter#147038) 2024-04-19 6655696+guidezpl@users.noreply.github.com Update link branches to `main` (continued) (flutter/flutter#146985) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6234dd1984e to 25d773ea90c4 (1 revision) (flutter/flutter#147035) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from ff471881e90a to b6234dd1984e (2 revisions) (flutter/flutter#147029) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 442d14a7e840 to ff471881e90a (1 revision) (flutter/flutter#147025) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6e4a15d31769 to 442d14a7e840 (2 revisions) (flutter/flutter#147023) 2024-04-19 42216813+eliasyishak@users.noreply.github.com Opt out users from GA3 if opted out of GA4 (flutter/flutter#146453) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 61bf47d129bb to 6e4a15d31769 (1 revision) (flutter/flutter#147022) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 13a6ce419664 to 61bf47d129bb (4 revisions) (flutter/flutter#147017) 2024-04-18 ian@hixie.ch Add a breadcrumb for the pub autoroller (flutter/flutter#146786) 2024-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add generic type for result in PopScope (#139164)" (flutter/flutter#147015) 2024-04-18 70227235+ShrootBuck@users.noreply.github.com Redundant message fix (flutter/flutter#143978) 2024-04-18 103135467+sealesj@users.noreply.github.com Clean up flutterRoot (flutter/flutter#147010) 2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.1 to 4.3.2 (flutter/flutter#147011) 2024-04-18 15619084+vashworth@users.noreply.github.com Add Swift Package Manager as new opt-in feature for iOS and macOS (flutter/flutter#146256) 2024-04-18 103135467+sealesj@users.noreply.github.com Refactor framework coverage tests (flutter/flutter#146210) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 46ff024bff10 to 13a6ce419664 (3 revisions) (flutter/flutter#147006) 2024-04-18 jacksongardner@google.com Changing the renderer on the web target should change its build key. (flutter/flutter#147003) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6abfa565a9f9 to 46ff024bff10 (1 revision) (flutter/flutter#147005) 2024-04-18 47866232+chunhtai@users.noreply.github.com Add generic type for result in PopScope (flutter/flutter#139164) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from aa6f7411c219 to 6abfa565a9f9 (1 revision) (flutter/flutter#147002) 2024-04-18 chris@bracken.jp [tools] Make SnapshotType.platform non-nullable (flutter/flutter#146958) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8e802515b5a to aa6f7411c219 (1 revision) (flutter/flutter#146996) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2c3e9c8bfce6 to b8e802515b5a (2 revisions) (flutter/flutter#146993) 2024-04-18 engine-flutter-autoroll@skia.org Roll Packages from d39830e to 0e3809d (9 revisions) (flutter/flutter#146992) 2024-04-18 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in navigation rail (flutter/flutter#146988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
Refactor framework coverage tests in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing framework coverage tests Part of flutter#145482
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@fb110b9...98685a0 2024-04-19 15619084+vashworth@users.noreply.github.com Replace CocoaPods deprecated `exists?` with `exist?` (flutter/flutter#147056) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ed7a2d6aed9 to 7fafbbf17c02 (2 revisions) (flutter/flutter#147046) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 25d773ea90c4 to 4ed7a2d6aed9 (3 revisions) (flutter/flutter#147038) 2024-04-19 6655696+guidezpl@users.noreply.github.com Update link branches to `main` (continued) (flutter/flutter#146985) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6234dd1984e to 25d773ea90c4 (1 revision) (flutter/flutter#147035) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from ff471881e90a to b6234dd1984e (2 revisions) (flutter/flutter#147029) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 442d14a7e840 to ff471881e90a (1 revision) (flutter/flutter#147025) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6e4a15d31769 to 442d14a7e840 (2 revisions) (flutter/flutter#147023) 2024-04-19 42216813+eliasyishak@users.noreply.github.com Opt out users from GA3 if opted out of GA4 (flutter/flutter#146453) 2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 61bf47d129bb to 6e4a15d31769 (1 revision) (flutter/flutter#147022) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 13a6ce419664 to 61bf47d129bb (4 revisions) (flutter/flutter#147017) 2024-04-18 ian@hixie.ch Add a breadcrumb for the pub autoroller (flutter/flutter#146786) 2024-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add generic type for result in PopScope (#139164)" (flutter/flutter#147015) 2024-04-18 70227235+ShrootBuck@users.noreply.github.com Redundant message fix (flutter/flutter#143978) 2024-04-18 103135467+sealesj@users.noreply.github.com Clean up flutterRoot (flutter/flutter#147010) 2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.1 to 4.3.2 (flutter/flutter#147011) 2024-04-18 15619084+vashworth@users.noreply.github.com Add Swift Package Manager as new opt-in feature for iOS and macOS (flutter/flutter#146256) 2024-04-18 103135467+sealesj@users.noreply.github.com Refactor framework coverage tests (flutter/flutter#146210) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 46ff024bff10 to 13a6ce419664 (3 revisions) (flutter/flutter#147006) 2024-04-18 jacksongardner@google.com Changing the renderer on the web target should change its build key. (flutter/flutter#147003) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6abfa565a9f9 to 46ff024bff10 (1 revision) (flutter/flutter#147005) 2024-04-18 47866232+chunhtai@users.noreply.github.com Add generic type for result in PopScope (flutter/flutter#139164) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from aa6f7411c219 to 6abfa565a9f9 (1 revision) (flutter/flutter#147002) 2024-04-18 chris@bracken.jp [tools] Make SnapshotType.platform non-nullable (flutter/flutter#146958) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8e802515b5a to aa6f7411c219 (1 revision) (flutter/flutter#146996) 2024-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2c3e9c8bfce6 to b8e802515b5a (2 revisions) (flutter/flutter#146993) 2024-04-18 engine-flutter-autoroll@skia.org Roll Packages from d39830e to 0e3809d (9 revisions) (flutter/flutter#146992) 2024-04-18 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in navigation rail (flutter/flutter#146988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor framework coverage tests in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing framework coverage tests
Part of #145482
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.