Encode scrolling status into tree #14536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Feb 8, 2018
Contributor
There was a problem hiding this comment.
what if it scrolls unbounded?
Hixie
reviewed
Feb 8, 2018
Contributor
There was a problem hiding this comment.
minScrollExtent can be double.negativeInfinity and maxScrollExtent can be double.infinity, so I don't think this does what you want it to.
Contributor
|
Can we document this in more detail? I don't see anywhere where I would go to read up on what the protocol is for sending scroll progress over the wire to the engine. |
Hixie
reviewed
Feb 9, 2018
Contributor
There was a problem hiding this comment.
here and at least 5 other cases: put a comma after the member name, so it reads "foo, from where bar", rather than "foo from where bar".
Hixie
reviewed
Feb 9, 2018
Contributor
There was a problem hiding this comment.
surprising number of blank lines!
Contributor
|
|
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires flutter/engine#4647.
Instead of firing scrolling events, we will encode the current scroll status into the tree. This will make implementing a11y scrolling for iOS a lot easier (#11983).