Add a minTileHeight to ListTile widget so its height can be customized to less than the default height.
#145244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuncCccccc
reviewed
Mar 16, 2024
Contributor
QuncCccccc
left a comment
There was a problem hiding this comment.
Are there any issues that this PR is trying to fix? I'm just thinking whether we can make a smaller height by changing visualDensity and isDense. Also if we need to add this property, should we also add visual density adjustment to minTileHeight and add this property to ListTileThemeData?
Member
Author
Added
I tried isDense and the tile height is 48, i want to implement a tile with height to 32 for my use case.
I think if you set the minHeight explicitly, it makes sense to override the visual density.
added. |
QuncCccccc
reviewed
Mar 19, 2024
Contributor
QuncCccccc
left a comment
There was a problem hiding this comment.
This looks great! Just left a couple of small comments then we are good to go!
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2024
… customized to less than the default height. (flutter/flutter#145244)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 20, 2024
flutter/flutter@d31a85b...b96c13d 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from f42fc937028c to 883adfe2ef61 (1 revision) (flutter/flutter#145459) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 32ae508316a6 to f42fc937028c (1 revision) (flutter/flutter#145456) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1e89d04c6b52 to 32ae508316a6 (2 revisions) (flutter/flutter#145449) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from e96b2b0047f7 to 1e89d04c6b52 (1 revision) (flutter/flutter#145446) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 24b84203f6cc to e96b2b0047f7 (1 revision) (flutter/flutter#145444) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3f67bc531eef to 24b84203f6cc (1 revision) (flutter/flutter#145441) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00bfdb580b1b to 3f67bc531eef (1 revision) (flutter/flutter#145438) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from dce639a4c453 to 00bfdb580b1b (1 revision) (flutter/flutter#145435) 2024-03-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bd3a9241c2c5 to dce639a4c453 (3 revisions) (flutter/flutter#145429) 2024-03-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from bacb027aa824 to bd3a9241c2c5 (1 revision) (flutter/flutter#145427) 2024-03-19 chingjun@google.com Fix remote DDS in proxied devices. (flutter/flutter#145346) 2024-03-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7095e6a4a643 to bacb027aa824 (2 revisions) (flutter/flutter#145424) 2024-03-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 59138d5f8e88 to 7095e6a4a643 (1 revision) (flutter/flutter#145409) 2024-03-19 jhy03261997@gmail.com Add a `minTileHeight` to ListTile widget so its height can be customized to less than the default height. (flutter/flutter#145244) 2024-03-19 58190796+MitchellGoodwin@users.noreply.github.com Widget state properties (flutter/flutter#142151) 2024-03-19 164015983+goodmost@users.noreply.github.com chore: fix some comments (flutter/flutter#145397) 2024-03-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7ea6b003ffeb to 59138d5f8e88 (1 revision) (flutter/flutter#145404) 2024-03-19 engine-flutter-autoroll@skia.org Roll Packages from a757073 to a2f4ce0 (3 revisions) (flutter/flutter#145399) 2024-03-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from d8fbcfbd799c to 7ea6b003ffeb (2 revisions) (flutter/flutter#145398) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
… customized to less than the default height. (flutter/flutter#145244)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #145369
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.