Add helper widget parameter to InputDecoration #145157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @VatsalBhesaniya, thank you for your contribution! This seems like a reasonable feature to add given the text/widget pattern in |
gnprice
reviewed
Mar 19, 2024
Member
gnprice
left a comment
There was a problem hiding this comment.
Thanks @VatsalBhesaniya for adding this feature! I've gone through and reviewed it, and have just one small comment to add to @Renzo-Olivares's comments above. Other than those, this change all looks good to me.
Contributor
Author
Thanks for reviewing my PR! I appreciate you considering this addition and for the helpful comments. I've addressed all of them. I've also resolved merge conflicts that were present. |
gnprice
approved these changes
Mar 20, 2024
Member
gnprice
left a comment
There was a problem hiding this comment.
Thanks for the revision! LGTM.
Renzo-Olivares
approved these changes
Mar 20, 2024
Contributor
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM, thank you for the contribution!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 21, 2024
flutter/flutter@b96c13d...18340ea 2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7cdb240c4a16 to bad4a30e1c75 (2 revisions) (flutter/flutter#145551) 2024-03-21 engine-flutter-autoroll@skia.org Roll Packages from 23e56af to b7fbe68 (3 revisions) (flutter/flutter#145547) 2024-03-21 pascal@welsch.dev Add WidgetsApp.debugShowWidgetInspectorOverride again (deprecated) (flutter/flutter#145334) 2024-03-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll pub packages (#145509)" (flutter/flutter#145550) 2024-03-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#145509) 2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 14b67475cf80 to 7cdb240c4a16 (1 revision) (flutter/flutter#145533) 2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6de3d9b6196a to 14b67475cf80 (1 revision) (flutter/flutter#145529) 2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from c0d3ac3178fa to 6de3d9b6196a (1 revision) (flutter/flutter#145520) 2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23dc0cacc4db to c0d3ac3178fa (1 revision) (flutter/flutter#145519) 2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from a73e01364de0 to 23dc0cacc4db (2 revisions) (flutter/flutter#145517) 2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 45ed36c17bb7 to a73e01364de0 (1 revision) (flutter/flutter#145516) 2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34b304a27f73 to 45ed36c17bb7 (1 revision) (flutter/flutter#145513) 2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 912c61f30512 to 34b304a27f73 (1 revision) (flutter/flutter#145511) 2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98cfd9213332 to 912c61f30512 (1 revision) (flutter/flutter#145504) 2024-03-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#145476) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from fe6927c79dc3 to 98cfd9213332 (1 revision) (flutter/flutter#145498) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from d1fe8994dedf to fe6927c79dc3 (1 revision) (flutter/flutter#145493) 2024-03-20 bhesaniyavatsal@gmail.com Add helper widget parameter to InputDecoration (flutter/flutter#145157) 2024-03-20 34871572+gmackall@users.noreply.github.com Remove embedding v1 code in framework (flutter/flutter#144726) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1b52f57ca07c to d1fe8994dedf (8 revisions) (flutter/flutter#145491) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from f803f2adec54 to 1b52f57ca07c (1 revision) (flutter/flutter#145479) 2024-03-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland #128236 "Improve build output for all platforms" (#145376)" (flutter/flutter#145487) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc2b7a9076b4 to f803f2adec54 (1 revision) (flutter/flutter#145475) 2024-03-20 6655696+guidezpl@users.noreply.github.com Reland #128236 "Improve build output for all platforms" (flutter/flutter#145376) 2024-03-20 engine-flutter-autoroll@skia.org Roll Packages from a2f4ce0 to 23e56af (5 revisions) (flutter/flutter#145470) 2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 883adfe2ef61 to fc2b7a9076b4 (1 revision) (flutter/flutter#145469) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new field named
helperto the InputDecoration class. This field allows for specifying a widget containing contextual information about the InputDecorator.child's value. UnlikehelperText, which accepts a plain string,helpersupports widgets, enabling functionalities like tappable links for further explanation. This change aligns with the established pattern oferror,label,prefix, andsuffix.fixes #145163
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.