[flutter_tools] Catch rpc error in render frame with raster stats #144190

christopherfujino · 2024-02-27T00:43:45Z

Fixes #143010. This is intended to be cherrypicked into the 3.19 and 3.20 releases.

Long-term, we should deprecate this feature: #144191

eliasyishak · 2024-02-27T15:03:05Z

packages/flutter_tools/lib/src/resident_runner.dart

Will this always be the case for Impeller?

Yes, the whole feature will be deleted #144191

eliasyishak

LGTM, we should add a TODO where i commented if Impeller supports ResidentHandlers.debugFrameJankMetrics() in the future

auto-submit · 2024-02-27T18:14:22Z

auto label is removed for flutter/flutter/144190, due to - The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux firebase_android_embedding_v2_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2024-02-27T23:52:40Z

auto label is removed for flutter/flutter/144190, due to - The status or check suite Linux firebase_android_embedding_v2_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

…tats (flutter/flutter#144190)

Manual roll Flutter from c30f998 to d00bfe8 (32 revisions) Manual roll requested by bmparr@google.com flutter/flutter@c30f998...d00bfe8 2024-02-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (flutter/flutter#144340) 2024-02-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (flutter/flutter#144338) 2024-02-28 15619084+vashworth@users.noreply.github.com Reland "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144275) 2024-02-28 christopherfujino@gmail.com [flutter_tools] Catch rpc error in render frame with raster stats (flutter/flutter#144190) 2024-02-28 github@alexv525.com ð��¡ï¸� Guard Flutter Android app by disallow task affinity by default (flutter/flutter#144018) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (flutter/flutter#144316) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (flutter/flutter#144296) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (flutter/flutter#144293) 2024-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (flutter/flutter#144292) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (flutter/flutter#144290) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (flutter/flutter#144288) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (flutter/flutter#144285) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (flutter/flutter#144283) 2024-02-28 polinach@google.com Use const route for notAnnounced. (flutter/flutter#144050) 2024-02-28 tessertaha@gmail.com Add `tabs_utils.dart` class (flutter/flutter#143937) 2024-02-28 36861262+QuncCccccc@users.noreply.github.com Remove `bottomAppBarColor` from `ThemeData` (flutter/flutter#144080) 2024-02-27 richadlu001@gmail.com fix: unexpected chinese punctuation (flutter/flutter#143678) 2024-02-27 42216813+eliasyishak@users.noreply.github.com Clean up lint ignores (flutter/flutter#144229) 2024-02-27 jhy03261997@gmail.com Reland [a11y] Add isEnabled semantics flag to text field (flutter/flutter#143601) 2024-02-27 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `CupertinoContextMenu.previewBuilder` (flutter/flutter#143990) 2024-02-27 chris@bracken.jp [iOS] Fix naming in platform_view example (flutter/flutter#144247) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (flutter/flutter#144262) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144253) 2024-02-27 kustermann@google.com [web] Make flutter web profile builds always keep wasm symbols (flutter/flutter#144130) 2024-02-27 36861262+QuncCccccc@users.noreply.github.com Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#144001) 2024-02-27 tjrogertj@gmail.com bind missing add icon in platform_view example (flutter/flutter#132028) 2024-02-27 31859944+LongCatIsLooong@users.noreply.github.com Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (flutter/flutter#144207) 2024-02-27 31859944+LongCatIsLooong@users.noreply.github.com Remove strut migration flag from `TextPainter` (flutter/flutter#144242) 2024-02-27 15619084+vashworth@users.noreply.github.com Remove force Xcode debug workflow (flutter/flutter#144185) 2024-02-27 54558023+keyonghan@users.noreply.github.com Mark two other firebase targets as bringup: true (flutter/flutter#144234) 2024-02-27 15619084+vashworth@users.noreply.github.com Add FlutterMacOS.xcframework artifact (flutter/flutter#143244) 2024-02-27 jonahwilliams@google.com Re-enable Impeller goldens blocking. (flutter/flutter#144210) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

flutteractionsbot · 2024-03-04T20:29:44Z

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

flutteractionsbot · 2024-03-04T20:29:49Z

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

…utter#144190) Fixes flutter#143010. This is intended to be cherrypicked into the 3.19 and 3.20 releases. Long-term, we should deprecate this feature: flutter#144191

Tracking issue: #143010 Original PR: #144190 CP request: #144565

) Manual roll Flutter from c30f998 to d00bfe8 (32 revisions) Manual roll requested by bmparr@google.com flutter/flutter@c30f998...d00bfe8 2024-02-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (flutter/flutter#144340) 2024-02-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (flutter/flutter#144338) 2024-02-28 15619084+vashworth@users.noreply.github.com Reland "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144275) 2024-02-28 christopherfujino@gmail.com [flutter_tools] Catch rpc error in render frame with raster stats (flutter/flutter#144190) 2024-02-28 github@alexv525.com ð��¡ï¸� Guard Flutter Android app by disallow task affinity by default (flutter/flutter#144018) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (flutter/flutter#144316) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (flutter/flutter#144296) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (flutter/flutter#144293) 2024-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (flutter/flutter#144292) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (flutter/flutter#144290) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (flutter/flutter#144288) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (flutter/flutter#144285) 2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (flutter/flutter#144283) 2024-02-28 polinach@google.com Use const route for notAnnounced. (flutter/flutter#144050) 2024-02-28 tessertaha@gmail.com Add `tabs_utils.dart` class (flutter/flutter#143937) 2024-02-28 36861262+QuncCccccc@users.noreply.github.com Remove `bottomAppBarColor` from `ThemeData` (flutter/flutter#144080) 2024-02-27 richadlu001@gmail.com fix: unexpected chinese punctuation (flutter/flutter#143678) 2024-02-27 42216813+eliasyishak@users.noreply.github.com Clean up lint ignores (flutter/flutter#144229) 2024-02-27 jhy03261997@gmail.com Reland [a11y] Add isEnabled semantics flag to text field (flutter/flutter#143601) 2024-02-27 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `CupertinoContextMenu.previewBuilder` (flutter/flutter#143990) 2024-02-27 chris@bracken.jp [iOS] Fix naming in platform_view example (flutter/flutter#144247) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (flutter/flutter#144262) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144253) 2024-02-27 kustermann@google.com [web] Make flutter web profile builds always keep wasm symbols (flutter/flutter#144130) 2024-02-27 36861262+QuncCccccc@users.noreply.github.com Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#144001) 2024-02-27 tjrogertj@gmail.com bind missing add icon in platform_view example (flutter/flutter#132028) 2024-02-27 31859944+LongCatIsLooong@users.noreply.github.com Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (flutter/flutter#144207) 2024-02-27 31859944+LongCatIsLooong@users.noreply.github.com Remove strut migration flag from `TextPainter` (flutter/flutter#144242) 2024-02-27 15619084+vashworth@users.noreply.github.com Remove force Xcode debug workflow (flutter/flutter#144185) 2024-02-27 54558023+keyonghan@users.noreply.github.com Mark two other firebase targets as bringup: true (flutter/flutter#144234) 2024-02-27 15619084+vashworth@users.noreply.github.com Add FlutterMacOS.xcframework artifact (flutter/flutter#143244) 2024-02-27 jonahwilliams@google.com Re-enable Impeller goldens blocking. (flutter/flutter#144210) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

…tats (flutter/flutter#144190)

…r#144564) Tracking issue: flutter#143010 Original PR: flutter#144190 CP request: flutter#144565

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 27, 2024

christopherfujino marked this pull request as ready for review February 27, 2024 00:52

christopherfujino requested a review from eliasyishak February 27, 2024 00:59

eliasyishak reviewed Feb 27, 2024

View reviewed changes

eliasyishak approved these changes Feb 27, 2024

View reviewed changes

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2024

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2024

christopherfujino added 10 commits February 27, 2024 16:09

wip

f92d4d4

add failing test

8b430c9

fix test

60b2e21

fix more

05bf460

fix more

e07570c

fix more

5618a15

fix more

4a9f666

fix more

1073c52

fix

6c9dd6b

clean up test

789953c

christopherfujino force-pushed the catch-rpc-error-in-render-frame-with-raster-stats branch from dc898ef to 789953c Compare February 28, 2024 00:09

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2024

auto-submit bot merged commit f89b4f1 into flutter:master Feb 28, 2024

engine-flutter-autoroll mentioned this pull request Feb 28, 2024

Manual roll Flutter from c30f998eb5db to d00bfe820eef (32 revisions) flutter/packages#6222

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024

f89b4f1 [flutter_tools] Catch rpc error in render frame with raster s…

8b5e3ab

…tats (flutter/flutter#144190)

christopherfujino deleted the catch-rpc-error-in-render-frame-with-raster-stats branch March 4, 2024 20:24

christopherfujino added cp: stable cherry pick this pull request to stable release candidate branch cp: beta cherry pick this pull request to beta release candidate branch labels Mar 4, 2024

christopherfujino mentioned this pull request Mar 4, 2024

[CP-stable] catch rpc error in render frame with raster stats #144564

Merged

auto-submit bot pushed a commit that referenced this pull request Mar 5, 2024

[CP-stable] catch rpc error in render frame with raster stats (#144564)

481d49b

Tracking issue: #143010 Original PR: #144190 CP request: #144565

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

f89b4f1 [flutter_tools] Catch rpc error in render frame with raster s…

0befa29

…tats (flutter/flutter#144190)

danielatego pushed a commit to danielatego/flutter that referenced this pull request Jun 6, 2024

[CP-stable] catch rpc error in render frame with raster stats (flutte…

ed575ea

…r#144564) Tracking issue: flutter#143010 Original PR: flutter#144190 CP request: flutter#144565

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[flutter_tools] Catch rpc error in render frame with raster stats #144190

[flutter_tools] Catch rpc error in render frame with raster stats #144190

Uh oh!

christopherfujino commented Feb 27, 2024 •

edited

Loading

Uh oh!

eliasyishak Feb 27, 2024

Uh oh!

christopherfujino Feb 27, 2024 •

edited

Loading

Uh oh!

eliasyishak left a comment

Uh oh!

auto-submit bot commented Feb 27, 2024

Uh oh!

auto-submit bot commented Feb 27, 2024

Uh oh!

flutteractionsbot commented Mar 4, 2024

Uh oh!

flutteractionsbot commented Mar 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[flutter_tools] Catch rpc error in render frame with raster stats #144190

[flutter_tools] Catch rpc error in render frame with raster stats #144190

Uh oh!

Conversation

christopherfujino commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eliasyishak Feb 27, 2024

Choose a reason for hiding this comment

Uh oh!

christopherfujino Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eliasyishak left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Feb 27, 2024

Uh oh!

auto-submit bot commented Feb 27, 2024

Uh oh!

flutteractionsbot commented Mar 4, 2024

Uh oh!

flutteractionsbot commented Mar 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

christopherfujino commented Feb 27, 2024 •

edited

Loading

christopherfujino Feb 27, 2024 •

edited

Loading