Skip to content

Explain MaterialColor's constructor better.#14407

Merged
Hixie merged 1 commit into
flutter:masterfrom
Hixie:color-docs
Feb 3, 2018
Merged

Explain MaterialColor's constructor better.#14407
Hixie merged 1 commit into
flutter:masterfrom
Hixie:color-docs

Conversation

@Hixie

@Hixie Hixie commented Feb 1, 2018

Copy link
Copy Markdown
Contributor

Fixes #14393

@Hixie

Hixie commented Feb 2, 2018

Copy link
Copy Markdown
Contributor Author

@DaveShuckerow would you mind giving an LGTM if this indeed satisfies your question? Thanks!

@DaveShuckerow DaveShuckerow self-requested a review February 2, 2018 16:52

@DaveShuckerow DaveShuckerow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks well-documented to me

@Hixie Hixie merged commit 21ee1a2 into flutter:master Feb 3, 2018
@Hixie Hixie deleted the color-docs branch February 3, 2018 00:01
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs confusion: is MaterialColor.primary a color index or a color value?

3 participants