Skip to content

Use inlining annotations on important methods for all targets #143923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkustermann merged 1 commit into from
Feb 22, 2024
Merged

Use inlining annotations on important methods for all targets #143923

mkustermann merged 1 commit into from
Feb 22, 2024

Conversation

@mkustermann
Copy link
Member

@mkustermann mkustermann commented Feb 22, 2024

No description provided.

@mkustermann mkustermann requested a review from mraleph February 22, 2024 08:33
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 22, 2024

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 22, 2024
mraleph
mraleph approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@mraleph mraleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment

@matanlurey
Copy link
Contributor

matanlurey commented Feb 22, 2024

test-exempt: non-semantic changes

@mkustermann
Copy link
Member Author

mkustermann commented Feb 22, 2024

Thanks, @matanlurey !

@mkustermann mkustermann merged commit b09ca49 into flutter:master Feb 22, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
b09ca49 Use inlining annotations on important methods for all targets (…
bb2b795 
…flutter/flutter#143923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
b09ca49 Use inlining annotations on important methods for all targets (…
6a21c00 
…flutter/flutter#143923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
b09ca49 Use inlining annotations on important methods for all targets (…
d1cb877 
…flutter/flutter#143923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
b09ca49 Use inlining annotations on important methods for all targets (…
30d3fb0 
…flutter/flutter#143923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
b09ca49 Use inlining annotations on important methods for all targets (…
7fa3747 
…flutter/flutter#143923)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
Roll Flutter from 41581c9 to 39585e6 (31 revisions) (#6194)
fe6111b 
flutter/flutter@41581c9...39585e6

2024-02-23 jonahwilliams@google.com Re-enable Impeller goldens blocking. (flutter/flutter#144023)
2024-02-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0f3ad23b84ed to 5f99a6c3289e (16 revisions) (flutter/flutter#144028)
2024-02-23 engine-flutter-autoroll@skia.org Roll Packages from 078c2a3 to 7df2085 (3 revisions) (flutter/flutter#144030)
2024-02-23 15619084+vashworth@users.noreply.github.com Run tests on iOS 17 exclusively (flutter/flutter#144022)
2024-02-23 15619084+vashworth@users.noreply.github.com Retry button tap in [FlutterUITests testFlutterViewWarm] (flutter/flutter#143967)
2024-02-23 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `InteractiveViewer.alignPanAxis` (flutter/flutter#142500)
2024-02-23 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `KeepAliveHandle.release` (flutter/flutter#143961)
2024-02-23 goderbauer@google.com Remove deprecated AnimatedListItemBuilder, AnimatedListRemovedItemBuilder (flutter/flutter#143974)
2024-02-23 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 06448ee8165f to 0f3ad23b84ed (16 revisions) (flutter/flutter#143989)
2024-02-23 katelovett@google.com Remove deprecated TimelineSummary.writeSummaryToFile (flutter/flutter#143983)
2024-02-23 54558023+keyonghan@users.noreply.github.com Remove unused drone_dimension field (flutter/flutter#143984)
2024-02-23 goderbauer@google.com Remove deprecated MediaQuery.boldTextOverride (flutter/flutter#143960)
2024-02-22 goderbauer@google.com Revert engine back to 06448ee8165f4ff6579ef9510ac69322eda896ac (flutter/flutter#143986)
2024-02-22 katelovett@google.com Remove deprecated FlutterDriver.enableAccessibility (flutter/flutter#143979)
2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from cb6115d3a6ab to c5d2e011652b (3 revisions) (flutter/flutter#143980)
2024-02-22 36861262+QuncCccccc@users.noreply.github.com Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" (flutter/flutter#143973)
2024-02-22 110420204+dsanagustin@users.noreply.github.com Add CloseButtonTooltip to the 'X' button on a SnackBar (flutter/flutter#143934)
2024-02-22 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/flutter#143971)
2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (flutter/flutter#143972)
2024-02-22 kustermann@google.com Use inlining annotations on important methods for all targets (flutter/flutter#143923)
2024-02-22 31859944+LongCatIsLooong@users.noreply.github.com Add missing `TextPainter.strutStyle` to paragraph style (flutter/flutter#143771)
2024-02-22 zanderso@users.noreply.github.com Shift Moto G4 staging tests to A02s (flutter/flutter#143957)
2024-02-22 sokolovskyi.konstantin@gmail.com Add CurvedAnimation disposals in some widgets (flutter/flutter#143790)
2024-02-22 andrew@divineflame.com Fix documentation typo in basic.dart (flutter/flutter#143887)
2024-02-22 pateltirth454@gmail.com Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
2024-02-22 derekx@google.com Support using lightweight Flutter Engines to run tests (flutter/flutter#141726)
2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9250bfdb38c5 to 06448ee8165f (1 revision) (flutter/flutter#143943)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutter/flutter#143946)
2024-02-22 engine-flutter-autoroll@skia.org Roll Packages from 48048f6 to 078c2a3 (11 revisions) (flutter/flutter#143935)
2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7777480eb94d to 9250bfdb38c5 (8 revisions) (flutter/flutter#143933)
2024-02-22 bernaferrari2@gmail.com Reland Add UI Benchmarks (#143542) (flutter/flutter#143799)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll @LouiseHsu
Roll Flutter from 41581c9 to 39585e6 (31 revisions) (flutter#6194)
84dc5ff 
flutter/flutter@41581c9...39585e6

2024-02-23 jonahwilliams@google.com Re-enable Impeller goldens blocking. (flutter/flutter#144023)
2024-02-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0f3ad23b84ed to 5f99a6c3289e (16 revisions) (flutter/flutter#144028)
2024-02-23 engine-flutter-autoroll@skia.org Roll Packages from 078c2a3 to 7df2085 (3 revisions) (flutter/flutter#144030)
2024-02-23 15619084+vashworth@users.noreply.github.com Run tests on iOS 17 exclusively (flutter/flutter#144022)
2024-02-23 15619084+vashworth@users.noreply.github.com Retry button tap in [FlutterUITests testFlutterViewWarm] (flutter/flutter#143967)
2024-02-23 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `InteractiveViewer.alignPanAxis` (flutter/flutter#142500)
2024-02-23 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `KeepAliveHandle.release` (flutter/flutter#143961)
2024-02-23 goderbauer@google.com Remove deprecated AnimatedListItemBuilder, AnimatedListRemovedItemBuilder (flutter/flutter#143974)
2024-02-23 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 06448ee8165f to 0f3ad23b84ed (16 revisions) (flutter/flutter#143989)
2024-02-23 katelovett@google.com Remove deprecated TimelineSummary.writeSummaryToFile (flutter/flutter#143983)
2024-02-23 54558023+keyonghan@users.noreply.github.com Remove unused drone_dimension field (flutter/flutter#143984)
2024-02-23 goderbauer@google.com Remove deprecated MediaQuery.boldTextOverride (flutter/flutter#143960)
2024-02-22 goderbauer@google.com Revert engine back to 06448ee8165f4ff6579ef9510ac69322eda896ac (flutter/flutter#143986)
2024-02-22 katelovett@google.com Remove deprecated FlutterDriver.enableAccessibility (flutter/flutter#143979)
2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from cb6115d3a6ab to c5d2e011652b (3 revisions) (flutter/flutter#143980)
2024-02-22 36861262+QuncCccccc@users.noreply.github.com Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" (flutter/flutter#143973)
2024-02-22 110420204+dsanagustin@users.noreply.github.com Add CloseButtonTooltip to the 'X' button on a SnackBar (flutter/flutter#143934)
2024-02-22 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/flutter#143971)
2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (flutter/flutter#143972)
2024-02-22 kustermann@google.com Use inlining annotations on important methods for all targets (flutter/flutter#143923)
2024-02-22 31859944+LongCatIsLooong@users.noreply.github.com Add missing `TextPainter.strutStyle` to paragraph style (flutter/flutter#143771)
2024-02-22 zanderso@users.noreply.github.com Shift Moto G4 staging tests to A02s (flutter/flutter#143957)
2024-02-22 sokolovskyi.konstantin@gmail.com Add CurvedAnimation disposals in some widgets (flutter/flutter#143790)
2024-02-22 andrew@divineflame.com Fix documentation typo in basic.dart (flutter/flutter#143887)
2024-02-22 pateltirth454@gmail.com Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
2024-02-22 derekx@google.com Support using lightweight Flutter Engines to run tests (flutter/flutter#141726)
2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9250bfdb38c5 to 06448ee8165f (1 revision) (flutter/flutter#143943)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutter/flutter#143946)
2024-02-22 engine-flutter-autoroll@skia.org Roll Packages from 48048f6 to 078c2a3 (11 revisions) (flutter/flutter#143935)
2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7777480eb94d to 9250bfdb38c5 (8 revisions) (flutter/flutter#143933)
2024-02-22 bernaferrari2@gmail.com Reland Add UI Benchmarks (#143542) (flutter/flutter#143799)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
b09ca49 Use inlining annotations on important methods for all targets (…
0b29621 
…flutter/flutter#143923)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mraleph mraleph mraleph approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkustermann @matanlurey @mraleph