Fixes in flutter framework code to address the mixin issue raised in Dart issue 31984 #14392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR cannot land until we have a fix for dart issue dart-lang/sdk#32019 |
| /// impractical (e.g. because you want to mix in other classes as well). | ||
| // TODO(ianh): Remove this class once https://github.com/dart-lang/sdk/issues/15101 is fixed | ||
| abstract class RenderProxyBoxMixin extends RenderBox with RenderObjectWithChildMixin<RenderBox> { | ||
| abstract class RenderProxyBoxMixin<T extends RenderBox> extends RenderBox with RenderObjectWithChildMixin<T> { |
Contributor
There was a problem hiding this comment.
Here and elsewhere, I think you need to mark these with @optionalTypeArgs to allow them to be used without a type parameter.
…pect a generic type to be specified at the points where the mixin is applied. This suppresses the analyzer warnings.
Hixie
reviewed
Feb 1, 2018
| _WidgetTicker(TickerCallback onTick, this._creator, { String debugLabel }) : super(onTick, debugLabel: debugLabel); | ||
|
|
||
| final TickerProviderStateMixin _creator; | ||
| final TickerProviderStateMixin<StatefulWidget> _creator; |
Contributor
There was a problem hiding this comment.
this shouldn't be necessary any more right?
Contributor
|
|
mraleph
reviewed
Feb 1, 2018
| /// [TickerProviderStateMixin] instead. | ||
| abstract class SingleTickerProviderStateMixin extends State<dynamic> implements TickerProvider { // ignore: TYPE_ARGUMENT_NOT_MATCHING_BOUNDS, https://github.com/dart-lang/sdk/issues/25232 | ||
| @optionalTypeArgs | ||
| abstract class SingleTickerProviderStateMixin<T extends StatefulWidget> extends State<T> implements TickerProvider { // ignore: TYPE_ARGUMENT_NOT_MATCHING_BOUNDS, https://github.com/dart-lang/sdk/issues/25232 |
Member
There was a problem hiding this comment.
I think you could remove // ignore: here and below.
Hixie
reviewed
Feb 5, 2018
| /// impractical (e.g. because you want to mix in other classes as well). | ||
| // TODO(ianh): Remove this class once https://github.com/dart-lang/sdk/issues/15101 is fixed | ||
| abstract class RenderProxyBoxMixin extends RenderBox with RenderObjectWithChildMixin<RenderBox> { | ||
| /// TODO(ianh): Remove this class once https://github.com/dart-lang/sdk/issues/15101 is fixed |
Contributor
There was a problem hiding this comment.
This should be two slashes, not three.
a-siva
added a commit
to a-siva/flutter
that referenced
this pull request
Feb 15, 2018
up the latest Dart roll - Resubmit flutter#14392 to fix compilation errors
Merged
a-siva
added a commit
that referenced
this pull request
Feb 15, 2018
up the latest Dart roll - Resubmit #14392 to fix compilation errors
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
up the latest Dart roll - Resubmit flutter#14392 to fix compilation errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the flutter framework part of the issue raised in dart-lang/sdk#31984.
This pulls all the relevant changes from #14327 without the generic type changes at the mixin application sites.