Adds missing style to PopupMenuButton
#143392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuncCccccc
approved these changes
Mar 5, 2024
Contributor
QuncCccccc
left a comment
There was a problem hiding this comment.
LGTM:) Thanks for the contribution!
Member
Author
|
Thanks a lot for the review! 🙌 <3 |
Member
Author
|
Not relevant to this PR but wanted ask something about contributor access. Justin was happy to sponsor me but next set of process didn't happen, no follow-ups here - #143319 (comment) any other way to reach out to him, don't want to make it look like spam. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 6, 2024
flutter/flutter@3b5a2ec...8f84f3f 2024-03-06 engine-flutter-autoroll@skia.org Roll Packages from 2aa6e3f to 9b88dbc (8 revisions) (flutter/flutter#144693) 2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 370e7d5866d9 to b6efe0dd88fe (1 revision) (flutter/flutter#144668) 2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from d374c78bcf52 to 370e7d5866d9 (1 revision) (flutter/flutter#144661) 2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from effcf97a1f7c to d374c78bcf52 (5 revisions) (flutter/flutter#144659) 2024-03-06 greg@zulip.com Fill in SliverConstraints fields missing from ==, hashCode, toString (flutter/flutter#143661) 2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49bc1577f317 to effcf97a1f7c (10 revisions) (flutter/flutter#144653) 2024-03-05 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.0.2 to 4.1.0 (flutter/flutter#144174) 2024-03-05 15619084+vashworth@users.noreply.github.com Fix embedding FlutterMacOS.framework for macOS add2app via cocoapods (flutter/flutter#144248) 2024-03-05 andrewrkolos@gmail.com Enable asset transformation feature in hot reload workflow (excluding Web) (flutter/flutter#144161) 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3e8b0deffe4e to 49bc1577f317 (5 revisions) (flutter/flutter#144639) 2024-03-05 hans.muller@gmail.com Updated the smiley TextButton example again (flutter/flutter#144630) 2024-03-05 pateltirth454@gmail.com Adds missing `style` to `PopupMenuButton` (flutter/flutter#143392) 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7c785884903 to 3e8b0deffe4e (1 revision) (flutter/flutter#144629) 2024-03-05 goderbauer@google.com Add regression test for TabBar crash (flutter/flutter#144627) 2024-03-05 engine-flutter-autoroll@skia.org Roll Packages from 0625827 to 2aa6e3f (5 revisions) (flutter/flutter#144628) 2024-03-05 andrewrkolos@gmail.com remove unused `firstBuildTime` parameter in `DevFS::update` (flutter/flutter#144576) 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8916bb32b7b8 to a7c785884903 (1 revision) (flutter/flutter#144624) 2024-03-05 goderbauer@google.com Revert "_DefaultTabControllerState should dispose all created TabContoller instances. (#136608)" (flutter/flutter#144579) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
@piedcipher Sorry, I totally missed those replies. I've sent a message to sponsor you on the server-support channel: https://discord.com/channels/608014603317936148/611619879153565715/1215053910562316348 |
LouiseHsu
pushed a commit
to LouiseHsu/packages
that referenced
this pull request
Mar 7, 2024
flutter/flutter@3b5a2ec...8f84f3f 2024-03-06 engine-flutter-autoroll@skia.org Roll Packages from 2aa6e3f to 9b88dbc (8 revisions) (flutter/flutter#144693) 2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 370e7d5866d9 to b6efe0dd88fe (1 revision) (flutter/flutter#144668) 2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from d374c78bcf52 to 370e7d5866d9 (1 revision) (flutter/flutter#144661) 2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from effcf97a1f7c to d374c78bcf52 (5 revisions) (flutter/flutter#144659) 2024-03-06 greg@zulip.com Fill in SliverConstraints fields missing from ==, hashCode, toString (flutter/flutter#143661) 2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49bc1577f317 to effcf97a1f7c (10 revisions) (flutter/flutter#144653) 2024-03-05 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.0.2 to 4.1.0 (flutter/flutter#144174) 2024-03-05 15619084+vashworth@users.noreply.github.com Fix embedding FlutterMacOS.framework for macOS add2app via cocoapods (flutter/flutter#144248) 2024-03-05 andrewrkolos@gmail.com Enable asset transformation feature in hot reload workflow (excluding Web) (flutter/flutter#144161) 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3e8b0deffe4e to 49bc1577f317 (5 revisions) (flutter/flutter#144639) 2024-03-05 hans.muller@gmail.com Updated the smiley TextButton example again (flutter/flutter#144630) 2024-03-05 pateltirth454@gmail.com Adds missing `style` to `PopupMenuButton` (flutter/flutter#143392) 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7c785884903 to 3e8b0deffe4e (1 revision) (flutter/flutter#144629) 2024-03-05 goderbauer@google.com Add regression test for TabBar crash (flutter/flutter#144627) 2024-03-05 engine-flutter-autoroll@skia.org Roll Packages from 0625827 to 2aa6e3f (5 revisions) (flutter/flutter#144628) 2024-03-05 andrewrkolos@gmail.com remove unused `firstBuildTime` parameter in `DevFS::update` (flutter/flutter#144576) 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8916bb32b7b8 to a7c785884903 (1 revision) (flutter/flutter#144624) 2024-03-05 goderbauer@google.com Revert "_DefaultTabControllerState should dispose all created TabContoller instances. (#136608)" (flutter/flutter#144579) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing
styletoPopupMenuButton.Fixes: #114709
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.