Skip to content

Layout animated GIFs only once #143188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Feb 9, 2024
Merged

Layout animated GIFs only once #143188

auto-submit merged 2 commits into from
Feb 9, 2024

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Feb 8, 2024

Fixes #138610.

When RenderImage receives a new Image it only needs to fire up the layout machinery when the dimensions of the image have changed compared to the previous image. If the dimensions are the same, a repaint is sufficient.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 8, 2024
jonahwilliams
jonahwilliams approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 9, 2024
@auto-submit auto-submit bot merged commit 0aa9b5e into flutter:master Feb 9, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
eb5c0b6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
78bb83c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
1055305
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
d4f3bcd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
b85b994
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
03bf0a1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
4d9c07a
@HansMuller HansMuller mentioned this pull request Feb 9, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
45efc8c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
631f164
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
b446c38
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
29eda48
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
cef5754
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
792529a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
9ed6d24
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
70b40fc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
eff7c01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
7136ce6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
bfda405
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
a94887b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
d929f02
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
d3804d2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
3a8b8f1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
e0b9f02
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
2c36f82
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
f9a5e9e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
195ff7d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
b7617e7
@goderbauer goderbauer deleted the stopRelayoutsForAnimatedGifs branch March 8, 2024 22:18
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
0aa9b5e Layout animated GIFs only once (flutter/flutter#143188)
49f9a0d
@matthew-carroll matthew-carroll mentioned this pull request Jan 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gif image markNeedsLayout every frame.

3 participants

@goderbauer @jonahwilliams @LongCatIsLooong