Revert "Add SingleChildScrollView for NavigationRail"
#143097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fd7f45a.
Member
Author
Contributor
|
auto label is removed for flutter/flutter/143097, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
Thanks so much @goderbauer for the help! I was investigating how to fix the regression🤣. |
johnpryan
approved these changes
Feb 7, 2024
Member
Author
|
@QuncCccccc can you add a test to the framework that covers this particular use case so we don't break it again? |
Contributor
Yes! Adding one. Update: #143108 |
Contributor
Oh just noticed the demo tests actually can catch the exception. Should we add M3 demo to customer testing as well? |
Member
Author
|
Adding the M3 demo tests to customer testing sounds reasonable since we don't want to break that demo. You can register them here: https://github.com/flutter/tests |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 8, 2024
Roll Flutter from 8431cae to eb5d0a4 (33 revisions) flutter/flutter@8431cae...eb5d0a4 2024-02-08 engine-flutter-autoroll@skia.org Roll Packages from e4ea6bf to 29d8cc0 (5 revisions) (flutter/flutter#143161) 2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d524588c0f9 to f53fbd8393ce (1 revision) (flutter/flutter#143160) 2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22e1241e9823 to 6d524588c0f9 (3 revisions) (flutter/flutter#143147) 2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 084bd0b8f5ac to 22e1241e9823 (1 revision) (flutter/flutter#143140) 2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 104804aa374e to 084bd0b8f5ac (1 revision) (flutter/flutter#143139) 2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 45137ea6ba29 to 104804aa374e (1 revision) (flutter/flutter#143138) 2024-02-08 jacksongardner@google.com Pass along web renderer into debugging options in the test command. (flutter/flutter#143128) 2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ea7bd07328b to 45137ea6ba29 (2 revisions) (flutter/flutter#143135) 2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 322a461dc74f to 4ea7bd07328b (2 revisions) (flutter/flutter#143131) 2024-02-07 36861262+QuncCccccc@users.noreply.github.com Add a unit test for `NavigationRail` (flutter/flutter#143108) 2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1ba9f329f76 to 322a461dc74f (2 revisions) (flutter/flutter#143123) 2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Improve build output for all platforms" (flutter/flutter#143125) 2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from e4a5acc14b44 to b1ba9f329f76 (2 revisions) (flutter/flutter#143120) 2024-02-07 6655696+guidezpl@users.noreply.github.com Improve build output for all platforms (flutter/flutter#128236) 2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19ae46afed69 to e4a5acc14b44 (7 revisions) (flutter/flutter#143112) 2024-02-07 ybz975218925@gmail.com Fixed cursor blinking during selection. (flutter/flutter#141380) 2024-02-07 magder@google.com Remove Cirrus check for web test concurrency (flutter/flutter#143046) 2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enforce a policy on supported Gradle, Java, AGP, and KGP versions" (flutter/flutter#143114) 2024-02-07 34871572+gmackall@users.noreply.github.com Enforce a policy on supported Gradle, Java, AGP, and KGP versions (flutter/flutter#142000) 2024-02-07 jacksongardner@google.com Fix inputs and outputs for `WebReleaseBundle` (flutter/flutter#143023) 2024-02-07 ian@hixie.ch Various improvements to text-editing-related documentation. (flutter/flutter#142561) 2024-02-07 goderbauer@google.com Revert "Add `SingleChildScrollView` for `NavigationRail`" (flutter/flutter#143097) 2024-02-07 34871572+gmackall@users.noreply.github.com Restore log dumps for gradle OOM crashes, and set a value for `MaxMetaspaceSize` (flutter/flutter#143085) 2024-02-07 15619084+vashworth@users.noreply.github.com Move Mac_build_test flutter_gallery__transition_perf_e2e_ios out of staging (flutter/flutter#142987) 2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from fafd8e55eb4b to 19ae46afed69 (1 revision) (flutter/flutter#143094) 2024-02-07 ian@hixie.ch Add a test for the isAvailableForEnvironment logic (flutter/flutter#142251) 2024-02-07 32538273+ValentinVignal@users.noreply.github.com Add the number of mismatched pixels to golden tests output (flutter/flutter#142975) 2024-02-07 goderbauer@google.com Add indexInParent to SemanticsNode debug information (flutter/flutter#142826) 2024-02-07 magder@google.com Remove unused devicelab task gradle_non_android_plugin_test (flutter/flutter#142742) 2024-02-07 34871572+gmackall@users.noreply.github.com Make generate_gradle_lockfiles also write the gradle wrapper file (flutter/flutter#142329) 2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6807342305e4 to fafd8e55eb4b (1 revision) (flutter/flutter#143086) 2024-02-07 andrewrkolos@gmail.com Remove redundant `rootDirectoryPath` parameter in `DevFS::update` (flutter/flutter#143034) 2024-02-07 maRci002@users.noreply.github.com Handle transitions to AppLifecycleState.detached in lifecycle state generation (flutter/flutter#142523) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #137415
Reverting due to #143061. this is breaking some existing use cases, see also flutter/samples#2157. If we try this again, we need to add this in less breaking way.
Fixes #143061