Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimer… #143079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MitchellGoodwin
left a comment
There was a problem hiding this comment.
Thank you for putting this together. Sorry it took some time to get to it. Mostly LGTM with some comments.
Contributor
Author
|
Thanks, @MitchellGoodwin for your feedback. I have made the changes according to the comments. Please check. |
Contributor
Author
|
Hi @MitchellGoodwin |
MitchellGoodwin
approved these changes
Apr 23, 2024
Contributor
MitchellGoodwin
left a comment
There was a problem hiding this comment.
LGTM! Sorry it took so long to review.
justinmc
reviewed
May 1, 2024
Contributor
justinmc
left a comment
There was a problem hiding this comment.
Mostly just a bunch of quick small stuff here, otherwise this looks good. Thanks for the PR!
Contributor
|
Hey @varunkamanibosc would you like to keep working on this PR and address the above feedback? |
Contributor
Author
|
Hi @Piinks |
Contributor
Author
|
Hi @justinmc |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 29, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 29, 2024
flutter/flutter@a1a33e6...c85fa6a 2024-05-29 polinach@google.com Clean leak in editable_text_test.dart. (flutter/flutter#149223) 2024-05-29 sokolovskyi.konstantin@gmail.com Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180) 2024-05-29 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220) 2024-05-29 hany212mohamed@gmail.com Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568) 2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224) 2024-05-29 yinxulolol@gmail.com sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470) 2024-05-29 luis901101@gmail.com Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767) 2024-05-28 737941+loic-sharma@users.noreply.github.com Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207) 2024-05-28 polinach@google.com Remove opt out for CurvedAnimation. (flutter/flutter#147594) 2024-05-28 31859944+LongCatIsLooong@users.noreply.github.com Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062) 2024-05-28 polinach@google.com Clean leaky test. (flutter/flutter#149199) 2024-05-28 34871572+gmackall@users.noreply.github.com Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198) 2024-05-28 leroux_bruno@yahoo.fr fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161) 2024-05-28 77919688+varunkamanibosc@users.noreply.github.com Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimer� (flutter/flutter#143079) 2024-05-28 jmccandless@google.com Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006) 2024-05-28 31859944+LongCatIsLooong@users.noreply.github.com Remove `TextEditingController` private member access (flutter/flutter#149042) 2024-05-28 engine-flutter-autoroll@skia.org Roll Packages from b7bcb4b to a933c30 (1 revision) (flutter/flutter#149184) 2024-05-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169) 2024-05-28 kevmoo@users.noreply.github.com [tool] Use kebabCase directly (flutter/flutter#149150) 2024-05-28 katelovett@google.com [wiki migration] Leftover wiki pages and links (flutter/flutter#148989) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
flutter#143079) It's now possible to override the default selection overlay with CupertinoDatePicker.selectionOverlayBuilder and CupertinoTimerPicker.selectionOverlayBuilder.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a new optional parameter to
CupertinoDatePickerandCupertinoTimerPickercalledselectionOverlayBuilder. This parameter will allow us to override the default selection overlay.Fixing: #79559
Pre-launch Checklist
///).