Skip to content

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Jan 18, 2024

Fixes #141347
This PR is to add a "clear text" tooltip for the clear button on SearchAnchor's search view and also add a clearButtonTooltip entry for material_localizations.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: internationalization Supporting other languages or locales. (aka i18n) labels Jan 18, 2024
@QuncCccccc QuncCccccc requested a review from HansMuller January 19, 2024 01:48
@QuncCccccc QuncCccccc marked this pull request as ready for review January 19, 2024 01:48
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2024
@auto-submit auto-submit bot merged commit e86c1c8 into flutter:master Jan 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 24, 2024
flutter/flutter@5b673c2...19b06f4

2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c592dbfa032 to ba3a70ce7722 (2 revisions) (flutter/flutter#142130)
2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 700235c85d4a to 7c592dbfa032 (2 revisions) (flutter/flutter#142108)
2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from da96f9de3f69 to 700235c85d4a (1 revision) (flutter/flutter#142100)
2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 220416cfa6ca to da96f9de3f69 (5 revisions) (flutter/flutter#142098)
2024-01-24 ybz975218925@gmail.com Don't change the height of the Textfield's labelStyle when it focused. (flutter/flutter#141943)
2024-01-24 polinach@google.com Ignore a leak. (flutter/flutter#141737)
2024-01-24 xilaizhang@google.com [github actions] FINALLY fix the mysterious token error in github actions (flutter/flutter#142058)
2024-01-24 jacksongardner@google.com Revert "Add abifilters to our gradle templates" (flutter/flutter#142089)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0b9b538bd458 to 220416cfa6ca (2 revisions) (flutter/flutter#142079)
2024-01-23 34871572+gmackall@users.noreply.github.com Add abifilters to our gradle templates (flutter/flutter#135529)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11a16d83ab6c to 0b9b538bd458 (2 revisions) (flutter/flutter#142076)
2024-01-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.2.0 to 4.3.0 (flutter/flutter#142075)
2024-01-23 andrewrkolos@gmail.com consolidate AssetBundle::entries and AssetBundle::entryKinds into a new type, `AssetBundleEntry` (flutter/flutter#142029)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 57d6b518f920 to 11a16d83ab6c (4 revisions) (flutter/flutter#142071)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 994054143fc3 to 57d6b518f920 (3 revisions) (flutter/flutter#142067)
2024-01-23 christopherfujino@gmail.com [flutter_tools] fix language_version_test and enable shuffle (flutter/flutter#142009)
2024-01-23 ian@hixie.ch Merge flutter_goldens_client into flutter_goldens (flutter/flutter#141900)
2024-01-23 chingjun@google.com Allow overriding the native assets yaml file in the resident runner. (flutter/flutter#142016)
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b229878c57f5 to 994054143fc3 (1 revision) (flutter/flutter#142059)
2024-01-23 jhy03261997@gmail.com Update material banner maxScaleFactor to meet GAR requirement  (flutter/flutter#142015)
2024-01-23 36861262+QuncCccccc@users.noreply.github.com Add tooltip for the clear button on `SearchAnchor`'s search view (flutter/flutter#141804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@AlexV525
Copy link
Member

@QuncCccccc Is there any plan to fill in precise sentences for other languages with this field?

@QuncCccccc
Copy link
Contributor Author

@QuncCccccc Is there any plan to fill in precise sentences for other languages with this field?

Hi! #154959 just landed:)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SearchAnchor search view close and clear buttons don't have hover tooltips

3 participants