Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

Reverts #141673

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jan 17, 2024
@jonahwilliams jonahwilliams merged commit 9bbff1b into master Jan 17, 2024
@jonahwilliams jonahwilliams deleted the revert-141673-flutter-engine-flutter-autoroll-30d0695f-6b9e-41e1-a7e5-29a550665a5b-1705474146 branch January 17, 2024 16:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 18, 2024
flutter/flutter@def6af0...f77f824

2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49fa2cb9024f to b75d6d80d813 (1 revision) (flutter/flutter#141771)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 49c6ca211aa4 to 49fa2cb9024f (1 revision) (flutter/flutter#141762)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 873449c27d5a to 49c6ca211aa4 (1 revision) (flutter/flutter#141760)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from bfdc0c5b2826 to 873449c27d5a (1 revision) (flutter/flutter#141759)
2024-01-18 andrewrkolos@gmail.com Catch UnsupportedError thrown when user provides an asset directory path containing invalid characters (flutter/flutter#141214)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48f89ac064ac to bfdc0c5b2826 (1 revision) (flutter/flutter#141752)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 924c17245a78 to 48f89ac064ac (2 revisions) (flutter/flutter#141751)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98c16b430e6b to 924c17245a78 (1 revision) (flutter/flutter#141749)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73a2de5da53f to 98c16b430e6b (16 revisions) (flutter/flutter#141744)
2024-01-18 zanderso@users.noreply.github.com Move mac pixel 7 pro test to presubmit: false (flutter/flutter#141747)
2024-01-18 yjbanov@google.com [web] prepare layers_test.dart for flutter/engine#49786 (flutter/flutter#141731)
2024-01-17 polinach@google.com Remove non-needed bot and increase time out for leak_tracking. (flutter/flutter#141712)
2024-01-17 36861262+QuncCccccc@users.noreply.github.com Add `headerHeight` for `SearchAnchor` (flutter/flutter#141223)
2024-01-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/flutter#141715)
2024-01-17 andrewrkolos@gmail.com Make test file systems/platforms used in asset_bundle_test.dart less dependent on the host platform (flutter/flutter#141657)
2024-01-17 dacoharkes@google.com Native assets: roll deps (flutter/flutter#141684)
2024-01-17 godofredoc@google.com Run build tests on both x64 and arm64. (flutter/flutter#141206)
2024-01-17 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 (flutter/flutter#141706)
2024-01-17 yjbanov@google.com [web] prepare for flutter/engine#49786 (flutter/flutter#141700)
2024-01-17 fluttergithubbot@gmail.com Marks Windows framework_tests_misc_leak_tracking to be unflaky (flutter/flutter#141676)
2024-01-17 goderbauer@google.com Label "flutter_localizations" PRs with "framework" (flutter/flutter#141654)
2024-01-17 31859944+LongCatIsLooong@users.noreply.github.com Fix Tooltip show delay when mouse moves to one Tooltip from another (flutter/flutter#141656)
2024-01-17 engine-flutter-autoroll@skia.org Roll Packages from 7dd0fcb to 1a2b780 (6 revisions) (flutter/flutter#141683)
2024-01-17 gspencergoog@users.noreply.github.com Fix the --empty flag to not try working with non-app templates (flutter/flutter#141632)
2024-01-17 jonahwilliams@google.com Revert "Roll Flutter Engine from 73a2de5da53f to c7e328518bc0 (5 revisions)" (flutter/flutter#141691)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants