-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Add contexts to mac_ios targets. #141494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contexts to mac_ios targets. #141494
Conversation
This is required to remove explicit contexts from recipes.
ricardoamador
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| contexts: >- | ||
| [ | ||
| "osx_sdk" | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to android_virtual_device.
keyonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/flutter@8e94423...def6af0 2024-01-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73a2de5da53f to c7e328518bc0 (5 revisions) (flutter/flutter#141673) 2024-01-17 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 1382ff79dd6d to 73a2de5da53f (2 revisions) (flutter/flutter#141667) 2024-01-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4b6b7ec8e48 to 1382ff79dd6d (7 revisions) (flutter/flutter#141664) 2024-01-17 sokolovskyi.konstantin@gmail.com TrainHoppingAnimation should dispatch creation and disposal events. (flutter/flutter#141635) 2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from d4b6b7ec8e48 to 021a5ff5eae6 (5 revisions)" (flutter/flutter#141659) 2024-01-17 christopherfujino@gmail.com [flutter_tools] Fix analyze size on arm64 (flutter/flutter#141317) 2024-01-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4b6b7ec8e48 to 021a5ff5eae6 (5 revisions) (flutter/flutter#141651) 2024-01-16 dnfield@google.com Update TESTOWNERS iskakaushik -> dnfield (flutter/flutter#141649) 2024-01-16 31859944+LongCatIsLooong@users.noreply.github.com Allow selection in composing region (flutter/flutter#140516) 2024-01-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from eab7bd3b0999 to d4b6b7ec8e48 (1 revision) (flutter/flutter#141643) 2024-01-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from f20657354d8b to eab7bd3b0999 (12 revisions) (flutter/flutter#141638) 2024-01-16 anis.alibegic@gmail.com Fixed few typos (flutter/flutter#141543) 2024-01-16 godofredoc@google.com Add contexts to mac_ios targets. (flutter/flutter#141494) 2024-01-16 reidbaker@google.com handle rc versions of gradle in version compare (flutter/flutter#141612) 2024-01-16 barpac02@gmail.com Delete redundant `settings.ext.flutterSdkPath` (flutter/flutter#141509) 2024-01-16 engine-flutter-autoroll@skia.org Roll Packages from d21f3b8 to 7dd0fcb (2 revisions) (flutter/flutter#141630) 2024-01-16 barpac02@gmail.com Reference GitHub issue in TODO comment (flutter/flutter#141582) 2024-01-16 barpac02@gmail.com migrate {min,target,compile}SdkVersion to {min,target,compile}Sdk (flutter/flutter#141537) 2024-01-16 magder@google.com Sort Swift imports in templates (flutter/flutter#141487) 2024-01-16 polinach@google.com Ignore or fix leaks. (flutter/flutter#141468) 2024-01-16 intspt@qq.com Solve the problem that <Flutter/Flutter.h> cannot be imported when a pod transitive depends on Flutter (flutter/flutter#125610) 2024-01-16 93368594+imp-sike@users.noreply.github.com Fix #141061: Add 'color' property to `DrawerButton` and `EndDrawerButton` (flutter/flutter#141159) 2024-01-15 engine-flutter-autoroll@skia.org Roll Packages from d74d687 to d21f3b8 (5 revisions) (flutter/flutter#141573) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This is required to remove explicit contexts from recipes.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.